New issue
Advanced search Search tips

Issue 813209 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Re-enable excluded Mojo unit tests

Project Member Reported by oksamyt@chromium.org, Feb 16 2018

Issue description

//testing/buildbot/test_suite_exceptions.pyl has exceptions for mojo_unittests (see https://chromium-review.googlesource.com/c/chromium/src/+/919364).

This bug is for finding out which of these bots can be removed from the excluded list if the tests pass there and looking at the failures to figure out why the bots were excluded.
 
Description: Show this description
Status: Untriaged
Summary: Re-enable excluded Mojo unit tests (was: Merge Mojo unit test suites)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1940dc5fc671f2aa1a369349a5ee8654bcc8160

commit c1940dc5fc671f2aa1a369349a5ee8654bcc8160
Author: Ken Rockot <rockot@chromium.org>
Date: Wed Feb 21 12:49:23 2018

Fix message leaks in some Mojo tests

Bug:  813209 
Change-Id: Ibff09c20e6be0b3494eb27b3edbc732292335578
Reviewed-on: https://chromium-review.googlesource.com/924586
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538075}
[modify] https://crrev.com/c1940dc5fc671f2aa1a369349a5ee8654bcc8160/mojo/edk/system/message_unittest.cc
[modify] https://crrev.com/c1940dc5fc671f2aa1a369349a5ee8654bcc8160/mojo/public/c/system/tests/core_unittest_pure_c.c

Owner: oksamyt@chromium.org
Status: Assigned (was: Untriaged)
chromium.memory tests were re-enabled in this change:
https://bugs.chromium.org/p/chromium/issues/detail?id=482593
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f996211aa6fd5bf71f94a85ea49b8c513cba49d

commit 7f996211aa6fd5bf71f94a85ea49b8c513cba49d
Author: Oksana Zhuravlova <oksamyt@chromium.org>
Date: Wed Feb 28 04:23:08 2018

Removed all bot exclusions and modifications for mojo_unittests

Also increased the default timeout for mojo_unittests
to 300 seconds so that overrides are not necessary.

Bug:  813209 
Change-Id: Ifdec6a33d3271c38739b976efde319fcca3b9500
Reviewed-on: https://chromium-review.googlesource.com/936050
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539710}
[modify] https://crrev.com/7f996211aa6fd5bf71f94a85ea49b8c513cba49d/testing/buildbot/chromium.android.fyi.json
[modify] https://crrev.com/7f996211aa6fd5bf71f94a85ea49b8c513cba49d/testing/buildbot/chromium.android.json
[modify] https://crrev.com/7f996211aa6fd5bf71f94a85ea49b8c513cba49d/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/7f996211aa6fd5bf71f94a85ea49b8c513cba49d/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/7f996211aa6fd5bf71f94a85ea49b8c513cba49d/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/7f996211aa6fd5bf71f94a85ea49b8c513cba49d/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/7f996211aa6fd5bf71f94a85ea49b8c513cba49d/testing/buildbot/test_suites.pyl

Status: Fixed (was: Started)

Sign in to add a comment