New issue
Advanced search Search tips

Issue 813188 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

NULL

Project Member Reported by ClusterFuzz, Feb 16 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4838165264465920

Fuzzer: libFuzzer_template_url_parser_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Incorrect-function-pointer-type
Crash Address: 
Crash State:
  NULL
Sanitizer: undefined (UBSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=525358:525394

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4838165264465920

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Feb 17 2018

Labels: M-65
Project Member

Comment 2 by sheriffbot@chromium.org, Feb 17 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 17 2018

Labels: Pri-1

Comment 4 by gov...@chromium.org, Feb 17 2018

Cc: awhalley@chromium.org
+awhalley@, PTAL and assign to appropriate dev pls. Thank you.

Comment 5 by och...@chromium.org, Feb 19 2018

Cc: -awhalley@chromium.org
Labels: -Type-Bug-Security -Restrict-View-SecurityTeam -Security_Severity-Medium -Security_Impact-Beta -ReleaseBlock-Stable ReleaseBlockStable Type-Bug
Owner: och...@chromium.org
Status: Assigned (was: Untriaged)
Doesn't look like a security bug.

I think the type of LLVMFuzzerInitiailize is wrong here: https://cs.chromium.org/chromium/src/testing/libfuzzer/fuzzers/template_url_parser_fuzzer.cc?q=template_url_parser_fuzzer&sq=package:chromium&dr&l=37. argc should be a "int *", not "int".
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b527d070abae69331733a6e17a766820ef65002

commit 9b527d070abae69331733a6e17a766820ef65002
Author: Oliver Chang <ochang@chromium.org>
Date: Mon Feb 19 03:35:59 2018

template_url_parser_fuzzer: Fix type of LLVMFuzzerInitialize.

TBR=inferno@chromium.org

Bug:  813188 
Change-Id: I70b1d84cc6e9f0538b7faac7ba27ce09c5bffab6
Reviewed-on: https://chromium-review.googlesource.com/923922
Reviewed-by: Oliver Chang <ochang@chromium.org>
Commit-Queue: Oliver Chang <ochang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537576}
[modify] https://crrev.com/9b527d070abae69331733a6e17a766820ef65002/testing/libfuzzer/fuzzers/template_url_parser_fuzzer.cc

Comment 7 by och...@chromium.org, Feb 19 2018

Labels: -ReleaseBlockStable
Project Member

Comment 8 by ClusterFuzz, Feb 19 2018

ClusterFuzz has detected this issue as fixed in range 537575:537576.

Detailed report: https://clusterfuzz.com/testcase?key=4838165264465920

Fuzzer: libFuzzer_template_url_parser_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Incorrect-function-pointer-type
Crash Address: 
Crash State:
  NULL
Sanitizer: undefined (UBSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=525358:525376
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=537575:537576

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4838165264465920

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Feb 19 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4838165264465920 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment