New issue
Advanced search Search tips

Issue 813117 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"Memlog/MemlogBrowserTest.EndToEnd/14" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Feb 16 2018

Issue description

"Memlog/MemlogBrowserTest.EndToEnd/14" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLwsSBUZsYWtlIiRNZW1sb2cvTWVtbG9nQnJvd3NlclRlc3QuRW5kVG9FbmQvMTQM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f344088f3f614cc77de502e3afcdb469523ac5e5

commit f344088f3f614cc77de502e3afcdb469523ac5e5
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Sat Feb 17 02:25:27 2018

Disable flaking endToEnd test on Windows.

TBR=erikchen@chromium.org

Bug:  813117 
Change-Id: I08b627b284d88cc6b50b96cfb75f9399fb8a67f7
Reviewed-on: https://chromium-review.googlesource.com/924758
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537508}
[modify] https://crrev.com/f344088f3f614cc77de502e3afcdb469523ac5e5/chrome/browser/profiling_host/memlog_browsertest.cc

Labels: -Sheriff-Chromium
Owner: erikc...@chromium.org
Status: Assigned (was: Untriaged)
erikchen@ do you have an idea on who may be able to address this flaking test?
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08f7783b4bd199ad17ec8f1d8a56978853d6b2dd

commit 08f7783b4bd199ad17ec8f1d8a56978853d6b2dd
Author: Erik Chen <erikchen@chromium.org>
Date: Sun Feb 18 00:00:26 2018

Fix 2 bugs in OOP HP implementation. Re-enable tests on Windows.

The re-entrancy flag was missing for PartitionAlloc and Oilpan hooks. There was
an extra call to AllocatorShimLogFree() in HookFree().

Change-Id: Ida86b9e0e3ba33679ba353baccd47f5fcf93685c
Bug:  813117 
TBR: primiano@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/924885
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537554}
[modify] https://crrev.com/08f7783b4bd199ad17ec8f1d8a56978853d6b2dd/chrome/browser/profiling_host/memlog_browsertest.cc
[modify] https://crrev.com/08f7783b4bd199ad17ec8f1d8a56978853d6b2dd/chrome/browser/profiling_host/profiling_test_driver.cc
[modify] https://crrev.com/08f7783b4bd199ad17ec8f1d8a56978853d6b2dd/chrome/common/profiling/memlog_allocator_shim.cc
[modify] https://crrev.com/08f7783b4bd199ad17ec8f1d8a56978853d6b2dd/chrome/common/profiling/memlog_allocator_shim.h

Status: Fixed (was: Started)

Sign in to add a comment