New issue
Advanced search Search tips

Issue 813116 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Android accessibility: identify nodes containing an image

Project Member Reported by dmazz...@chromium.org, Feb 16 2018

Issue description

Android accessibility: expose nodes with an image.

Select-to-speak on Android wants to know what nodes in the
accessibility tree contain an image. We can't rely on
exposing this in the class name or role, because sometimes
an image might be inside a button, link, or other leaf-level
UI element. Add a new custom flag
"AccessibilityNodeInfo.hasImage" indicating if it has an image.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81619b38b921770676abcd90509b4ad6f19d3da9

commit 81619b38b921770676abcd90509b4ad6f19d3da9
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Tue Feb 20 07:29:51 2018

Android accessibility: expose nodes with an image.

Select-to-speak on Android wants to know what nodes in the
accessibility tree contain an image. We can't rely on
exposing this in the class name or role, because sometimes
an image might be inside a button, link, or other leaf-level
UI element. Add a new custom flag
"AccessibilityNodeInfo.hasImage" indicating if it has an image.

BUG= 813116 

Change-Id: Ia4d3779eecc534ebf997c655a817c5fd06a22d5a
Reviewed-on: https://chromium-review.googlesource.com/923207
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537732}
[modify] https://crrev.com/81619b38b921770676abcd90509b4ad6f19d3da9/content/browser/accessibility/accessibility_tree_formatter_android.cc
[modify] https://crrev.com/81619b38b921770676abcd90509b4ad6f19d3da9/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/81619b38b921770676abcd90509b4ad6f19d3da9/content/browser/accessibility/browser_accessibility_android.h
[modify] https://crrev.com/81619b38b921770676abcd90509b4ad6f19d3da9/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/81619b38b921770676abcd90509b4ad6f19d3da9/content/browser/accessibility/web_contents_accessibility_android.cc
[modify] https://crrev.com/81619b38b921770676abcd90509b4ad6f19d3da9/content/public/android/java/src/org/chromium/content/browser/accessibility/KitKatWebContentsAccessibility.java
[modify] https://crrev.com/81619b38b921770676abcd90509b4ad6f19d3da9/content/public/android/java/src/org/chromium/content/browser/accessibility/OWebContentsAccessibility.java
[modify] https://crrev.com/81619b38b921770676abcd90509b4ad6f19d3da9/content/public/android/java/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityImpl.java
[modify] https://crrev.com/81619b38b921770676abcd90509b4ad6f19d3da9/content/test/data/accessibility/html/img-expected-android.txt
[modify] https://crrev.com/81619b38b921770676abcd90509b4ad6f19d3da9/content/test/data/accessibility/html/img.html
[modify] https://crrev.com/81619b38b921770676abcd90509b4ad6f19d3da9/ui/accessibility/ax_role_properties.cc
[modify] https://crrev.com/81619b38b921770676abcd90509b4ad6f19d3da9/ui/accessibility/ax_role_properties.h

Status: Fixed (was: Started)

Sign in to add a comment