Reevaluate newly failing tests in ash_unittest --mash |
||||||
Issue descriptionFor various reasons ash_unittests --mash wasn't actually running any tests. This of course means new failures have crept in. In order to get the tests running on the bot again I'm disabling all the newly failing tests. The failing tests need to recategorized and more specific bugs filed.
,
Feb 16 2018
,
Feb 20 2018
James, would you be willing to categorize and make sure we have more specific bugs filed for these?
,
Feb 20 2018
I'll take care of it.
,
Feb 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1028c78bc5889e71729f11215258d89889f3464a commit 1028c78bc5889e71729f11215258d89889f3464a Author: James Cook <jamescook@chromium.org> Date: Wed Feb 21 18:45:29 2018 cros: Update ash_unittests filter file for mash None of the tests in the ash_unittests_mash suite have been running for several months, due to a typo in the filter file. During that time some tests have regressed. Clean up the filter file and map the failing tests to new or existing crbugs. Also change some tests to use ASSERT_EQ instead of EXPECT_EQ so they cleanly fail instead of crashing (for example, accessing an array or referencing a base::Optional). Bug: 813115 Test: ash_unittests --mash Change-Id: If324023f36cb7ffe441d4967c89c7f59f9e7d848 Reviewed-on: https://chromium-review.googlesource.com/927808 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#538162} [modify] https://crrev.com/1028c78bc5889e71729f11215258d89889f3464a/ash/display/display_manager_unittest.cc [modify] https://crrev.com/1028c78bc5889e71729f11215258d89889f3464a/ash/login/ui/login_password_view_test.cc [modify] https://crrev.com/1028c78bc5889e71729f11215258d89889f3464a/ash/wm/window_manager_unittest.cc [modify] https://crrev.com/1028c78bc5889e71729f11215258d89889f3464a/testing/buildbot/filters/ash_unittests_mash.filter
,
Feb 21 2018
,
Feb 26 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Feb 16 2018