New issue
Advanced search Search tips

Issue 813115 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Reevaluate newly failing tests in ash_unittest --mash

Project Member Reported by sky@chromium.org, Feb 16 2018

Issue description

For various reasons ash_unittests --mash wasn't actually running any tests. This of course means new failures have crept in. In order to get the tests running on the bot again I'm disabling all the newly failing tests. The failing tests need to recategorized and more specific bugs filed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d2747c881ff6e842cfaaec6c700f2dbaea68724

commit 1d2747c881ff6e842cfaaec6c700f2dbaea68724
Author: Scott Violet <sky@chromium.org>
Date: Fri Feb 16 18:18:29 2018

Gets ash_unittests --mash actually running tests again

Apparently a line like:

// foo

in the filter file results in all the other lines of the filter file
being ignored. This meant ash_unittests --mash on the bots wasn't
running any tests. Fixing the line shows a bunch of new tests are
failing. I've added them to the end and file a bug to recategorize
them.

I'll fix the bug in the filter file parsing separately.

BUG= 813115 
TEST=test only changes

Change-Id: If27f6e0738c4571c60e16bf87db6ba5cfac5cea3
Reviewed-on: https://chromium-review.googlesource.com/924270
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537352}
[modify] https://crrev.com/1d2747c881ff6e842cfaaec6c700f2dbaea68724/testing/buildbot/filters/ash_unittests_mash.filter

Labels: Proj-Mustash

Comment 3 by sky@chromium.org, Feb 20 2018

Owner: jamescook@chromium.org
Status: Assigned (was: Untriaged)
James, would you be willing to categorize and make sure we have more specific bugs filed for these?
Components: Internals>MUS
Labels: -Pri-3 -Proj-Mustash Proj-Mustash-Mash Pri-2
Status: Started (was: Assigned)
I'll take care of it.

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1028c78bc5889e71729f11215258d89889f3464a

commit 1028c78bc5889e71729f11215258d89889f3464a
Author: James Cook <jamescook@chromium.org>
Date: Wed Feb 21 18:45:29 2018

cros: Update ash_unittests filter file for mash

None of the tests in the ash_unittests_mash suite have been running for
several months, due to a typo in the filter file. During that time some
tests have regressed. Clean up the filter file and map the failing
tests to new or existing crbugs.

Also change some tests to use ASSERT_EQ instead of EXPECT_EQ so they
cleanly fail instead of crashing (for example, accessing an array or
referencing a base::Optional).

Bug:  813115 
Test: ash_unittests --mash
Change-Id: If324023f36cb7ffe441d4967c89c7f59f9e7d848
Reviewed-on: https://chromium-review.googlesource.com/927808
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538162}
[modify] https://crrev.com/1028c78bc5889e71729f11215258d89889f3464a/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/1028c78bc5889e71729f11215258d89889f3464a/ash/login/ui/login_password_view_test.cc
[modify] https://crrev.com/1028c78bc5889e71729f11215258d89889f3464a/ash/wm/window_manager_unittest.cc
[modify] https://crrev.com/1028c78bc5889e71729f11215258d89889f3464a/testing/buildbot/filters/ash_unittests_mash.filter

Status: Fixed (was: Started)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment