New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Today
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature

Blocking:
issue 800418



Sign in to add a comment

Implement 'running in Chrome' toast for TWA

Project Member Reported by owe...@chromium.org, Feb 16

Issue description

We need some disclaimer that the content is running inside Chrome, likely a toast.

Need to first agree on UI then implement
 
Blockedon: -800418
Blocking: 800418
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1f3e06f07823f78ea19fcab5cb17b8dc862b441

commit f1f3e06f07823f78ea19fcab5cb17b8dc862b441
Author: Peter E Conn <peconn@chromium.org>
Date: Wed Jun 13 10:10:45 2018

🤝 Notify user that a Trusted Web Activity is running in Chrome.

Notify the user via Toast that an opened Trusted Web Activity is part
of Chrome and therefore will have access to their cookies, autofill
data, etc.

This is shown at most once per week for a single app.

Bug:  813100 
Change-Id: I7f921637ffa042ff4d0f076ad4ca007708f06879
Reviewed-on: https://chromium-review.googlesource.com/1097399
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566784}
[modify] https://crrev.com/f1f3e06f07823f78ea19fcab5cb17b8dc862b441/chrome/android/java/src/org/chromium/chrome/browser/browserservices/OriginVerifier.java
[add] https://crrev.com/f1f3e06f07823f78ea19fcab5cb17b8dc862b441/chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java
[modify] https://crrev.com/f1f3e06f07823f78ea19fcab5cb17b8dc862b441/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
[modify] https://crrev.com/f1f3e06f07823f78ea19fcab5cb17b8dc862b441/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
[modify] https://crrev.com/f1f3e06f07823f78ea19fcab5cb17b8dc862b441/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/f1f3e06f07823f78ea19fcab5cb17b8dc862b441/chrome/android/java_sources.gni

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d7caeff902c8d8ed98cddb60e355bfd4694d5f0

commit 2d7caeff902c8d8ed98cddb60e355bfd4694d5f0
Author: Peter E Conn <peconn@chromium.org>
Date: Fri Jun 22 14:28:21 2018

🤝 Remove period from Running in Chrome notice.

Bug:  813100 
Change-Id: Ia5e544af26ec221f026c40ed342ab41cc3c3d959
Reviewed-on: https://chromium-review.googlesource.com/1111855
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569609}
[modify] https://crrev.com/2d7caeff902c8d8ed98cddb60e355bfd4694d5f0/chrome/android/java/strings/android_chrome_strings.grd

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/967fc76c423a5e86fc2e04b4655aa463d2ae7c12

commit 967fc76c423a5e86fc2e04b4655aa463d2ae7c12
Author: Peter E Conn <peconn@chromium.org>
Date: Thu Jul 12 16:28:53 2018

🤝 Add flag to force showing TWA disclosure.

Add a flag to force showing the disclosure for developer convenience.
Also trigger even when there isn't an active tab yet.

Bug:  813100 
Change-Id: I3ccd820d58f82040723a8f8a72097262ba374b82
Reviewed-on: https://chromium-review.googlesource.com/1116922
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574591}
[modify] https://crrev.com/967fc76c423a5e86fc2e04b4655aa463d2ae7c12/chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
[modify] https://crrev.com/967fc76c423a5e86fc2e04b4655aa463d2ae7c12/chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java
[modify] https://crrev.com/967fc76c423a5e86fc2e04b4655aa463d2ae7c12/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

Comment 6 by peconn@chromium.org, Today (14 hours ago)

Status: WontFix (was: Available)
With the refactor (Issue 871266) we've moved over to using a persistent Snackbar like pre-installed WebAPKs.

Sign in to add a comment