New issue
Advanced search Search tips

Issue 813098 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

We should split external/wpt/editing/run/removeformat.html into smaller tests

Project Member Reported by tnagel@chromium.org, Feb 16 2018

Issue description

Comment 1 by flackr@chromium.org, Feb 16 2018

 Issue 813099  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a697f1e46b693e1df3ddc437369b03d5c6956c3

commit 2a697f1e46b693e1df3ddc437369b03d5c6956c3
Author: Thiemo Nagel <tnagel@chromium.org>
Date: Fri Feb 16 17:17:18 2018

Mark removeformat.html as flaky

BUG=813098
TBR=editing-dev

Change-Id: I9005cfc1cf4011ee0b424cb7f06270786115a386
Reviewed-on: https://chromium-review.googlesource.com/924221
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537334}
[modify] https://crrev.com/2a697f1e46b693e1df3ddc437369b03d5c6956c3/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by tnagel@chromium.org, Feb 16 2018

Cc: editing-dev@chromium.org
I've tried bisecting this on my Linux box. There may be a regression that increased the flakiness but even 100 commits back flakiness was already at 1%. I'll leave this one to the experts.

#537167: 2/200 failures
#537237: 2/100 failures
Components: Blink>Editing

Comment 5 by yosin@chromium.org, Feb 19 2018

Status: Available (was: Untriaged)
Summary: We should split external/wpt/editing/run/removeformat.html into smaller tests (was: external/wpt/editing/run/removeformat.html is flaky on WebKit Linux Trusty Leak)
removeformat.html has may tests cases, 150+, in external/wpt/editing/data/removeformat.js.

We should split them into small pieces to avoid timeout in try bot. 
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88ad961030580148d9e24f377f0b87f8582b7641

commit 88ad961030580148d9e24f377f0b87f8582b7641
Author: Samuel Huang <huangs@chromium.org>
Date: Wed Sep 05 14:51:16 2018

[Sheriff] wpt/editing/run: Allow removeformat.html to timeout again.

In https://chromium-review.googlesource.com/c/chromium/src/+/1205917:
"Set longer timeout to all tests in wpt/editing/run/", the test
external/wpt/editing/run/removeformat.html 's Timeout expectation was
removed (along with reference to crbug.com/813098). Likely as a result,
WebKit Linux Trusty Leak is flaking in webkit_layout_test for
removeformat.html. This CL undos the particular change to remove noise.

TBR=tkent@chromium.org,yoichio@chormium.org

Bug: 813098
Change-Id: I632084ec48cd8e3fb670a8d20c1210440b13fdc7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1207011
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588863}
[modify] https://crrev.com/88ad961030580148d9e24f377f0b87f8582b7641/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment