New issue
Advanced search Search tips

Issue 813082 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Uploading to test-results broken

Project Member Reported by jbudorick@chromium.org, Feb 16 2018

Issue description

Seeing the following:

Traceback (most recent call last):
  File "/mnt/data/b/rr/tmpAomefP/rw/checkout/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py", line 216, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/rr/tmpAomefP/rw/checkout/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py", line 207, in main
    options.test_results_server, attrs, files, 120)
  File "/mnt/data/b/rr/tmpAomefP/rw/checkout/scripts/slave/recipe_modules/test_results/resources/test_results_uploader.py", line 51, in upload_test_results
    timeout_secs)
  File "/mnt/data/b/rr/tmpAomefP/rw/checkout/scripts/slave/recipe_modules/test_results/resources/test_results_uploader.py", line 135, in _retry_exp_backoff
    % (e.code, e.filename, e.read()))
test_results_uploader.PermanentError: Received HTTP status 400 loading "https://test-results.appspot.com/testfile/upload": strconv.Atoi: parsing "null": invalid syntax

This appears to be affecting uploads to the the production instance across a variety of bots, e.g.

  https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/67486
  https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%281%29/77169
  https://ci.chromium.org/buildbot/chromium.mac/Mac10.9%20Tests/54047

This appears to be the same error we saw on the staging instance in https://bugs.chromium.org/p/chromium/issues/detail?id=812332

 
Status: Started (was: Assigned)
looking now
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/86f411683f5453cbb74e91ffa98a6f2dc6ffef72

commit 86f411683f5453cbb74e91ffa98a6f2dc6ffef72
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Fri Feb 16 20:01:52 2018

[test-results] Survive null build_id in test results json uploads

Bug:  813082 
Change-Id: Ib8189484a2840dab39a2ab2e975815fa697d8e59
Reviewed-on: https://chromium-review.googlesource.com/924332
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/86f411683f5453cbb74e91ffa98a6f2dc6ffef72/go/src/infra/appengine/test-results/model/full_result.go

Status: Fixed (was: Started)

Sign in to add a comment