New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 813079 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature


Sign in to add a comment

Support F16-backed images in SharedBitmap

Project Member Reported by zakerinasab@chromium.org, Feb 16 2018

Issue description

SharedBitmap represents the shared memory used to transfer software bitmaps in a TransferableResource. To correctly propagate wide gamut images, we need SharedBitmap to support half float backed images.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/246a9f657730668ef37fd28805b8f6fc629817cd

commit 246a9f657730668ef37fd28805b8f6fc629817cd
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Wed Mar 07 22:07:52 2018

Add ResourceFormat to SharedBitmap

This is a spin off from chromium-review.googlesource.com/c/chromium/src/+/924168.
This change plumbs ResourceFormat in SharedBitmap as a prerequisite for supporting
half-float backed images. This CL is not supposed to change any existing behavior.

TBR=junov@chromium.org

Bug:  813079 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I349a15d4c63269a61eb2dbe72cca2eadc0f4e2a9
Reviewed-on: https://chromium-review.googlesource.com/946523
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541602}
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/cc/layers/heads_up_display_layer_impl.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/cc/layers/texture_layer_unittest.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/cc/raster/bitmap_raster_buffer_provider.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/cc/resources/display_resource_provider.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/cc/resources/layer_tree_resource_provider.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/cc/resources/layer_tree_resource_provider.h
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/cc/resources/layer_tree_resource_provider_unittest.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/cc/resources/resource_pool.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/cc/resources/resource_provider.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/cc/resources/resource_provider_unittest.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/cc/resources/video_resource_updater.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/cc/resources/video_resource_updater_unittest.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/components/viz/client/client_shared_bitmap_manager.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/components/viz/client/client_shared_bitmap_manager.h
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/components/viz/common/quads/shared_bitmap.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/components/viz/common/quads/shared_bitmap.h
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/components/viz/common/resources/bitmap_allocation.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/components/viz/common/resources/bitmap_allocation.h
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/components/viz/common/resources/resource_format_utils.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/components/viz/common/resources/resource_format_utils.h
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/components/viz/common/resources/shared_bitmap_manager.h
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/components/viz/common/resources/transferable_resource.h
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/components/viz/service/display/renderer_pixeltest.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/components/viz/service/display/software_renderer_unittest.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/components/viz/service/display_embedder/server_shared_bitmap_manager.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/components/viz/service/display_embedder/server_shared_bitmap_manager.h
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/components/viz/service/display_embedder/server_shared_bitmap_manager_unittest.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/components/viz/service/display_embedder/software_output_device_win.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/components/viz/test/test_shared_bitmap_manager.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/components/viz/test/test_shared_bitmap_manager.h
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/content/renderer/pepper/pepper_compositor_host.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/content/renderer/pepper/pepper_graphics_2d_host.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/content/shell/test_runner/test_plugin.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/content/test/test_blink_web_unit_test_support.h
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/third_party/WebKit/Source/platform/graphics/OffscreenCanvasResourceProvider.cpp
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/third_party/WebKit/Source/platform/graphics/gpu/ImageLayerBridge.cpp
[modify] https://crrev.com/246a9f657730668ef37fd28805b8f6fc629817cd/third_party/WebKit/public/platform/Platform.h

Status: Fixed (was: Assigned)

Sign in to add a comment