Maintain the maximum number of iterations in aura::WindowOcclusionTracker |
|||
Issue descriptionWhen a window tree changes, WindowOcclusionTracker recomputes occlusion states and notifies WindowDelegates. If those WindowDelegates change the window tree in response to an occlusion state change, occlusion states are computed again. |kMaxRecomputeOcclusion| sets a limit on the number of iterations that can occur. If too much iteration occur, a crash report is generated. We should make sure that we don't receive such crash reports, and then remove the code that generates them.
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/455eacbb9908bc2b7a260dacceef0b584244378b commit 455eacbb9908bc2b7a260dacceef0b584244378b Author: Francois Doray <fdoray@chromium.org> Date: Thu Aug 09 13:48:15 2018 aura: DCHECK when occlusion is recomputed too many times. Before this CL, recomputing occlusion too many times before occlusion states became stable caused a call to DumpWithoutCrashing(). Now that we didn't get any crash reports in the last 6 months, this CL replaces the DumpWithoutCrashing() with a simple DCHECK. Bug: 813076 Change-Id: I2ec8c5fa89a1646367035c3585df091a9a4f76cc Reviewed-on: https://chromium-review.googlesource.com/1168024 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#581887} [modify] https://crrev.com/455eacbb9908bc2b7a260dacceef0b584244378b/ui/aura/test/window_occlusion_tracker_test_api.cc [modify] https://crrev.com/455eacbb9908bc2b7a260dacceef0b584244378b/ui/aura/test/window_occlusion_tracker_test_api.h [modify] https://crrev.com/455eacbb9908bc2b7a260dacceef0b584244378b/ui/aura/window_occlusion_tracker.cc [modify] https://crrev.com/455eacbb9908bc2b7a260dacceef0b584244378b/ui/aura/window_occlusion_tracker.h [modify] https://crrev.com/455eacbb9908bc2b7a260dacceef0b584244378b/ui/aura/window_occlusion_tracker_unittest.cc
,
Aug 9
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Feb 16 2018