Squad: Remove use of MutableComputedStyle() to the extent possible |
||||
Issue descriptionWe would like ComputedStyle objects to be immutable after style recalc. Remove unnecessary instances of MutableComputedStyle() and figure out how to handle current modification of ComputedStyle for animations and during layout.
,
Feb 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0aca50f1552c882bc72ed5c419085fa975847a9c commit 0aca50f1552c882bc72ed5c419085fa975847a9c Author: Rune Lillesveen <futhark@chromium.org> Date: Fri Feb 16 17:30:05 2018 [Squad] Unnecessary use of mutable style in vp propagation. Also a couple of other places where ComputedStyle could be made immutable. Bug: 813068 Change-Id: I7cebac7951adbf65dbb057ef7b75d4ddab62e90c Reviewed-on: https://chromium-review.googlesource.com/924145 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#537340} [modify] https://crrev.com/0aca50f1552c882bc72ed5c419085fa975847a9c/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp [modify] https://crrev.com/0aca50f1552c882bc72ed5c419085fa975847a9c/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/0aca50f1552c882bc72ed5c419085fa975847a9c/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
,
Feb 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19812d547416623322b05ecb9cbd710b3924c045 commit 19812d547416623322b05ecb9cbd710b3924c045 Author: Rune Lillesveen <futhark@chromium.org> Date: Mon Feb 19 14:50:45 2018 [Squad] RtlOrdering() on viewport style is never used. We used to inherit RtlOrdering() from the viewport style, but documentElement now sets RtlOrdering() from initial style instead. Remove the unnecessary modification of the viewport style. Gets rid of one MutableStyleRef(). TEST=fast/text/international/iso-8859-8-* Bug: 813068 Change-Id: I96a24950a8a27fac9b97c60a7fe3b220c4523429 Reviewed-on: https://chromium-review.googlesource.com/924035 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#537650} [modify] https://crrev.com/19812d547416623322b05ecb9cbd710b3924c045/third_party/WebKit/Source/core/dom/Document.cpp
,
Feb 19 2018
,
Mar 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f8d7da096aaff6a8c39cb33ca09fb41a4077cb9 commit 6f8d7da096aaff6a8c39cb33ca09fb41a4077cb9 Author: Rune Lillesveen <futhark@chromium.org> Date: Mon Mar 26 20:11:44 2018 [Squad] Clone ComputedStyle before changing for overscroll test. To prepare for immutable ComputedStyle objects. Bug: 813068 Change-Id: Id5b4a57940712adfc9d353634856bc32e4ef2a0d Reviewed-on: https://chromium-review.googlesource.com/979810 Reviewed-by: Stefan Zager <szager@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#545867} [modify] https://crrev.com/6f8d7da096aaff6a8c39cb33ca09fb41a4077cb9/third_party/WebKit/Source/core/input/OverscrollBehaviorTest.cpp
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15e299fd19da9cf6f74dbcb78b6bc4865f7a5a35 commit 15e299fd19da9cf6f74dbcb78b6bc4865f7a5a35 Author: Rune Lillesveen <futhark@chromium.org> Date: Tue Mar 27 12:14:55 2018 [Squad] Get rid of empty state flag on parent style. We stored the previous match state for :empty, for elements affected by :empty selectors, on their computed style. For :empty in non-rightmost compound selectors, we would set the flag on on an already calculated computed style. That required the ComputedStyle to be mutable. Also, this flag didn't really work as we weren't trying to detect when an element changed between empty and non-empty state. Instead, modify CheckForEmptyStyleChange to check if there are any element or non-empty text nodes before/after the added/removed node. If there are, no :empty selector matching needs to be updated. Bug: 813068 Change-Id: Ic2e7c9a855067267d84c50c71215114a834e92ae Reviewed-on: https://chromium-review.googlesource.com/980946 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#546086} [modify] https://crrev.com/15e299fd19da9cf6f74dbcb78b6bc4865f7a5a35/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 [modify] https://crrev.com/15e299fd19da9cf6f74dbcb78b6bc4865f7a5a35/third_party/WebKit/Source/core/css/SelectorChecker.cpp [modify] https://crrev.com/15e299fd19da9cf6f74dbcb78b6bc4865f7a5a35/third_party/WebKit/Source/core/css/StyleEngineTest.cpp [modify] https://crrev.com/15e299fd19da9cf6f74dbcb78b6bc4865f7a5a35/third_party/WebKit/Source/core/dom/Element.cpp [modify] https://crrev.com/15e299fd19da9cf6f74dbcb78b6bc4865f7a5a35/third_party/WebKit/Source/core/dom/Element.h [modify] https://crrev.com/15e299fd19da9cf6f74dbcb78b6bc4865f7a5a35/third_party/WebKit/Source/core/style/ComputedStyle.cpp [modify] https://crrev.com/15e299fd19da9cf6f74dbcb78b6bc4865f7a5a35/third_party/WebKit/Source/core/style/ComputedStyle.h
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9709668ac0e706df25830b4e2006aff2ada3262d commit 9709668ac0e706df25830b4e2006aff2ada3262d Author: Rune Lillesveen <futhark@chromium.org> Date: Tue Mar 27 13:21:37 2018 [Squad] Retrieve old ComputedStyle as const. No need to use MutableComputedStyle there. Bug: 813068 Change-Id: If1ce7d3048af3ae7085ad09dd04350a5d4f1dd67 Reviewed-on: https://chromium-review.googlesource.com/980537 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#546094} [modify] https://crrev.com/9709668ac0e706df25830b4e2006aff2ada3262d/third_party/WebKit/Source/core/dom/Element.cpp
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6090709cbc1a2e94abb89ee25418e35ee15c2f96 commit 6090709cbc1a2e94abb89ee25418e35ee15c2f96 Author: Rune Lillesveen <futhark@chromium.org> Date: Thu Mar 29 01:29:46 2018 [Squad] Remove AnimationPropertiesLocked. This flag was added to try to narrow down the source of a crasher. I could not find any reports on DCHECKs triggered by this. Removing as this requires mutating the ComputedStyle after it's been set on the LayoutObject which we are trying to get rid of. Bug: 813068, 783598 Change-Id: I8bd02b143c6aaf820837721072e21e2324362f90 Reviewed-on: https://chromium-review.googlesource.com/984874 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#546692} [modify] https://crrev.com/6090709cbc1a2e94abb89ee25418e35ee15c2f96/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 [modify] https://crrev.com/6090709cbc1a2e94abb89ee25418e35ee15c2f96/third_party/WebKit/Source/core/dom/Element.cpp [modify] https://crrev.com/6090709cbc1a2e94abb89ee25418e35ee15c2f96/third_party/WebKit/Source/core/style/ComputedStyle.cpp
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0bd914408e05810598cf18999781c98ea1f112e5 commit 0bd914408e05810598cf18999781c98ea1f112e5 Author: Rune Lillesveen <futhark@chromium.org> Date: Thu Mar 29 02:04:35 2018 [Squad] Modify LayoutObject direction in cloned style. Gets rid of MutableStyleRef() in test. Bug: 813068 Change-Id: I3ee3d2e13223164c2b3ca32c69989f3f573e0cf4 Reviewed-on: https://chromium-review.googlesource.com/984877 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#546698} [modify] https://crrev.com/0bd914408e05810598cf18999781c98ea1f112e5/third_party/WebKit/Source/core/html/forms/HTMLFormControlElementTest.cpp
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4b06ef324b3c86ffbccdb7bd28ff67fc968cdba commit f4b06ef324b3c86ffbccdb7bd28ff67fc968cdba Author: Rune Lillesveen <futhark@chromium.org> Date: Tue Apr 03 07:53:22 2018 [Squad] Clone ComputedStyle adjusting autosizing in test. Getting rid of another mutable style access. Bug: 813068 Change-Id: Ied084dcce6c9477ce43763ba42dd4256e87efa25 Reviewed-on: https://chromium-review.googlesource.com/983953 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#547642} [modify] https://crrev.com/f4b06ef324b3c86ffbccdb7bd28ff67fc968cdba/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/831eb55c9824a394f896d3666ccf0f67d28f58a7 commit 831eb55c9824a394f896d3666ccf0f67d28f58a7 Author: Rune Lillesveen <futhark@chromium.org> Date: Tue Apr 03 11:02:26 2018 [Squad] Remove mutable style access in TextAutosizer. Bug: 813068 Change-Id: If8b7489c69b85237d422c6b3d030fdd79ca7017a Reviewed-on: https://chromium-review.googlesource.com/983955 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#547667} [modify] https://crrev.com/831eb55c9824a394f896d3666ccf0f67d28f58a7/third_party/WebKit/Source/core/layout/TextAutosizer.cpp [modify] https://crrev.com/831eb55c9824a394f896d3666ccf0f67d28f58a7/third_party/WebKit/Source/core/layout/TextAutosizer.h
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26ee06d6bf2b972eff49d756495e542469346e73 commit 26ee06d6bf2b972eff49d756495e542469346e73 Author: Rune Lillesveen <futhark@chromium.org> Date: Fri Apr 13 09:18:18 2018 [Squad] Remove MutableStyle from NG column test. Bug: 813068 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I420609e50155f7ef313a5a8ac25e067911d2c9a0 Reviewed-on: https://chromium-review.googlesource.com/1000452 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Aleks Totic <atotic@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#550559} [modify] https://crrev.com/26ee06d6bf2b972eff49d756495e542469346e73/third_party/blink/renderer/core/layout/ng/ng_column_layout_algorithm_test.cc
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60079363ee111bcdc6cbba7170ae31b9c726c15e commit 60079363ee111bcdc6cbba7170ae31b9c726c15e Author: Rune Lillesveen <futhark@chromium.org> Date: Fri Apr 13 09:19:49 2018 [Squad] Remove MutableStyle from PaintLayerTest. Bug: 813068 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2f6ac184988b6040b2a5bd82c562201c06c1581e Reviewed-on: https://chromium-review.googlesource.com/1000372 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#550560} [modify] https://crrev.com/60079363ee111bcdc6cbba7170ae31b9c726c15e/third_party/blink/renderer/core/paint/paint_layer_test.cc
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4464ab2aeb417fbfb2a10966929246922270e45c commit 4464ab2aeb417fbfb2a10966929246922270e45c Author: Rune Lillesveen <futhark@chromium.org> Date: Fri Apr 13 09:33:00 2018 [Squad] Clone ComputedStyle adjusting autosizing in test. Getting rid of yet another mutable style access. Bug: 813068 Change-Id: I227ccf577d0c0c90bc871c5eee3b768a6f140656 Reviewed-on: https://chromium-review.googlesource.com/1000732 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#550564} [modify] https://crrev.com/4464ab2aeb417fbfb2a10966929246922270e45c/third_party/blink/renderer/core/exported/web_frame_test.cc
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8caed3d480197d5d93c648219903004d61b7750 commit d8caed3d480197d5d93c648219903004d61b7750 Author: Rune Lillesveen <futhark@chromium.org> Date: Fri Apr 13 11:25:38 2018 [Squad] Use separate initial style for viewport resolver. Use a separate ComputedStyle object as initial style base for resolving font relative units for @viewport rules. When we used the ComputedStyle on LayoutView for this, it had to be mutable since length resolution may set HasViewportUnits. Use a mutable member of ViewportResolver instead so that we can eventually make the LayoutObject member immutable. Bug: 813068 Change-Id: I385e2f0ea387d9c4d5e75fa576ab7f79a2b14c98 Reviewed-on: https://chromium-review.googlesource.com/1000692 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#550590} [modify] https://crrev.com/d8caed3d480197d5d93c648219903004d61b7750/third_party/blink/renderer/core/css/document_style_sheet_collection.cc [modify] https://crrev.com/d8caed3d480197d5d93c648219903004d61b7750/third_party/blink/renderer/core/css/resolver/viewport_style_resolver.cc [modify] https://crrev.com/d8caed3d480197d5d93c648219903004d61b7750/third_party/blink/renderer/core/css/resolver/viewport_style_resolver.h [modify] https://crrev.com/d8caed3d480197d5d93c648219903004d61b7750/third_party/blink/renderer/core/css/style_engine.cc [modify] https://crrev.com/d8caed3d480197d5d93c648219903004d61b7750/third_party/blink/renderer/core/css/style_engine.h [modify] https://crrev.com/d8caed3d480197d5d93c648219903004d61b7750/third_party/blink/renderer/core/page/page.cc [modify] https://crrev.com/d8caed3d480197d5d93c648219903004d61b7750/third_party/blink/renderer/core/page/page.h
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26ee06d6bf2b972eff49d756495e542469346e73 commit 26ee06d6bf2b972eff49d756495e542469346e73 Author: Rune Lillesveen <futhark@chromium.org> Date: Fri Apr 13 09:18:18 2018 [Squad] Remove MutableStyle from NG column test. Bug: 813068 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I420609e50155f7ef313a5a8ac25e067911d2c9a0 Reviewed-on: https://chromium-review.googlesource.com/1000452 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Aleks Totic <atotic@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#550559} [modify] https://crrev.com/26ee06d6bf2b972eff49d756495e542469346e73/third_party/blink/renderer/core/layout/ng/ng_column_layout_algorithm_test.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60079363ee111bcdc6cbba7170ae31b9c726c15e commit 60079363ee111bcdc6cbba7170ae31b9c726c15e Author: Rune Lillesveen <futhark@chromium.org> Date: Fri Apr 13 09:19:49 2018 [Squad] Remove MutableStyle from PaintLayerTest. Bug: 813068 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2f6ac184988b6040b2a5bd82c562201c06c1581e Reviewed-on: https://chromium-review.googlesource.com/1000372 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#550560} [modify] https://crrev.com/60079363ee111bcdc6cbba7170ae31b9c726c15e/third_party/blink/renderer/core/paint/paint_layer_test.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4464ab2aeb417fbfb2a10966929246922270e45c commit 4464ab2aeb417fbfb2a10966929246922270e45c Author: Rune Lillesveen <futhark@chromium.org> Date: Fri Apr 13 09:33:00 2018 [Squad] Clone ComputedStyle adjusting autosizing in test. Getting rid of yet another mutable style access. Bug: 813068 Change-Id: I227ccf577d0c0c90bc871c5eee3b768a6f140656 Reviewed-on: https://chromium-review.googlesource.com/1000732 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#550564} [modify] https://crrev.com/4464ab2aeb417fbfb2a10966929246922270e45c/third_party/blink/renderer/core/exported/web_frame_test.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8caed3d480197d5d93c648219903004d61b7750 commit d8caed3d480197d5d93c648219903004d61b7750 Author: Rune Lillesveen <futhark@chromium.org> Date: Fri Apr 13 11:25:38 2018 [Squad] Use separate initial style for viewport resolver. Use a separate ComputedStyle object as initial style base for resolving font relative units for @viewport rules. When we used the ComputedStyle on LayoutView for this, it had to be mutable since length resolution may set HasViewportUnits. Use a mutable member of ViewportResolver instead so that we can eventually make the LayoutObject member immutable. Bug: 813068 Change-Id: I385e2f0ea387d9c4d5e75fa576ab7f79a2b14c98 Reviewed-on: https://chromium-review.googlesource.com/1000692 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#550590} [modify] https://crrev.com/d8caed3d480197d5d93c648219903004d61b7750/third_party/blink/renderer/core/css/document_style_sheet_collection.cc [modify] https://crrev.com/d8caed3d480197d5d93c648219903004d61b7750/third_party/blink/renderer/core/css/resolver/viewport_style_resolver.cc [modify] https://crrev.com/d8caed3d480197d5d93c648219903004d61b7750/third_party/blink/renderer/core/css/resolver/viewport_style_resolver.h [modify] https://crrev.com/d8caed3d480197d5d93c648219903004d61b7750/third_party/blink/renderer/core/css/style_engine.cc [modify] https://crrev.com/d8caed3d480197d5d93c648219903004d61b7750/third_party/blink/renderer/core/css/style_engine.h [modify] https://crrev.com/d8caed3d480197d5d93c648219903004d61b7750/third_party/blink/renderer/core/page/page.cc [modify] https://crrev.com/d8caed3d480197d5d93c648219903004d61b7750/third_party/blink/renderer/core/page/page.h
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bb6eaac49783c416dc9f76d240d7f5c9f5bd377 commit 6bb6eaac49783c416dc9f76d240d7f5c9f5bd377 Author: Rune Lillesveen <futhark@chromium.org> Date: Tue Apr 24 14:10:34 2018 [Squad] Get rid of mutable style in ng block tests. Also removed outdated FIXME. Bug: 813068 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I93fbe971f2d3a419b2fdcd15512073d841ea1104 Reviewed-on: https://chromium-review.googlesource.com/1025712 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#553089} [modify] https://crrev.com/6bb6eaac49783c416dc9f76d240d7f5c9f5bd377/third_party/blink/renderer/core/layout/layout_object.h [modify] https://crrev.com/6bb6eaac49783c416dc9f76d240d7f5c9f5bd377/third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm_test.cc
,
Apr 25 2018
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ad20078a57aee33334ea1aef1af0ee109e5a94f commit 2ad20078a57aee33334ea1aef1af0ee109e5a94f Author: Rune Lillesveen <futhark@chromium.org> Date: Wed Apr 25 09:18:04 2018 [Squad] Get rid of MutableStyleRef() in fullscreen code. We set writing-mode based on parent layout objects, but now modify the ComputedStyle before SetStyle to avoid non-const access to LayoutObject ComputedStyle member. This is part of the work to make the ComputedStyle member of LayoutObject const. Bug: 813068 Change-Id: Id1128c036e05532067a87a33f8b5f8b4b75ab8da Reviewed-on: https://chromium-review.googlesource.com/1024838 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#553492} [modify] https://crrev.com/2ad20078a57aee33334ea1aef1af0ee109e5a94f/third_party/blink/renderer/core/layout/layout_full_screen.cc [modify] https://crrev.com/2ad20078a57aee33334ea1aef1af0ee109e5a94f/third_party/blink/renderer/core/layout/layout_full_screen.h [modify] https://crrev.com/2ad20078a57aee33334ea1aef1af0ee109e5a94f/third_party/blink/renderer/core/layout/layout_object.cc [modify] https://crrev.com/2ad20078a57aee33334ea1aef1af0ee109e5a94f/third_party/blink/renderer/core/layout/layout_object.h
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1b06666866a207acc3a263a83f787267b56ad05 commit f1b06666866a207acc3a263a83f787267b56ad05 Author: Rune Lillesveen <futhark@chromium.org> Date: Wed Apr 25 12:03:59 2018 [Squad] style_ in StyleResolverState is always mutable. The style_ member of StyleResolverState is a ComputedStyle which is being built. There's no reason to have a separate Mutable* method to access it, we can always return it non-const. Bug: 813068 Change-Id: I7282441f2cac2e37ace98d0ee0709baf1ec656ea Reviewed-on: https://chromium-review.googlesource.com/1026682 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#553517} [modify] https://crrev.com/f1b06666866a207acc3a263a83f787267b56ad05/third_party/blink/renderer/core/css/resolver/style_adjuster.cc [modify] https://crrev.com/f1b06666866a207acc3a263a83f787267b56ad05/third_party/blink/renderer/core/css/resolver/style_resolver.cc [modify] https://crrev.com/f1b06666866a207acc3a263a83f787267b56ad05/third_party/blink/renderer/core/css/resolver/style_resolver_state.h
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9aa33c1d8d269d44490d2114736eb57eded120ab commit 9aa33c1d8d269d44490d2114736eb57eded120ab Author: Rune Lillesveen <futhark@chromium.org> Date: Thu Apr 26 14:24:58 2018 [Squad] Propagate thumb appearance during style recalc. We used to modify ComputedStyle in-place for LayoutSliderThumb on every layout. Instead, propagate appearance from input element thumb during style recalc. Also moved appearance inheritance for slider container element into html.css. Gets rid of MutableStyleRef() calls. Bug: 813068 Change-Id: Id82fa55c6854e19cd3c56f2746953c1c5d7d42e5 Reviewed-on: https://chromium-review.googlesource.com/1029857 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#554018} [add] https://crrev.com/9aa33c1d8d269d44490d2114736eb57eded120ab/third_party/WebKit/LayoutTests/fast/forms/range/slider-horizontal-to-vertical-expected.html [add] https://crrev.com/9aa33c1d8d269d44490d2114736eb57eded120ab/third_party/WebKit/LayoutTests/fast/forms/range/slider-horizontal-to-vertical.html [modify] https://crrev.com/9aa33c1d8d269d44490d2114736eb57eded120ab/third_party/blink/renderer/core/css/html.css [modify] https://crrev.com/9aa33c1d8d269d44490d2114736eb57eded120ab/third_party/blink/renderer/core/html/forms/range_input_type.cc [modify] https://crrev.com/9aa33c1d8d269d44490d2114736eb57eded120ab/third_party/blink/renderer/core/html/forms/slider_thumb_element.cc [modify] https://crrev.com/9aa33c1d8d269d44490d2114736eb57eded120ab/third_party/blink/renderer/core/html/forms/slider_thumb_element.h [modify] https://crrev.com/9aa33c1d8d269d44490d2114736eb57eded120ab/third_party/blink/renderer/core/layout/layout_slider.cc [modify] https://crrev.com/9aa33c1d8d269d44490d2114736eb57eded120ab/third_party/blink/renderer/core/layout/layout_slider.h [modify] https://crrev.com/9aa33c1d8d269d44490d2114736eb57eded120ab/third_party/blink/renderer/core/layout/layout_slider_thumb.cc [modify] https://crrev.com/9aa33c1d8d269d44490d2114736eb57eded120ab/third_party/blink/renderer/core/layout/layout_slider_thumb.h
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b508331caa152f812c216849fb1abffe60ca5fa commit 2b508331caa152f812c216849fb1abffe60ca5fa Author: Rune Lillesveen <futhark@chromium.org> Date: Fri Apr 27 13:21:33 2018 [Squad] Remove inner editor height/width reset hack. Height and width of ComputedStyle is no longer modified during layout. Remove the reset. Bug: 813068 Change-Id: Iab32d5b0dc2c852f0314013aa2d1d14c87a78c77 Reviewed-on: https://chromium-review.googlesource.com/1032595 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#554369} [modify] https://crrev.com/2b508331caa152f812c216849fb1abffe60ca5fa/third_party/blink/renderer/core/layout/layout_text_control.cc
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/848bc5ce0a70a5cf681723dfa52ce874ea7926c4 commit 848bc5ce0a70a5cf681723dfa52ce874ea7926c4 Author: Rune Lillesveen <futhark@chromium.org> Date: Fri Apr 27 20:22:11 2018 [Squad] Adjust vertical sliders style at computed time. Moved flex-direction adjustment from layout method to a computed style custom hook. We temporarily switched between rtl and ltr for each layout requiring the ComputedStyle to be mutable. The test that failed before adding this hack no longer fails without it, so removing. TEST=fast/forms/range/input-appearance-range-rtl.html Bug: 813068 Change-Id: I698859f10fba32aa02f8b5b61d07bd24557667b1 Reviewed-on: https://chromium-review.googlesource.com/1032553 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#554486} [modify] https://crrev.com/848bc5ce0a70a5cf681723dfa52ce874ea7926c4/third_party/blink/renderer/core/html/forms/slider_thumb_element.cc [modify] https://crrev.com/848bc5ce0a70a5cf681723dfa52ce874ea7926c4/third_party/blink/renderer/core/html/forms/slider_thumb_element.h [modify] https://crrev.com/848bc5ce0a70a5cf681723dfa52ce874ea7926c4/third_party/blink/renderer/core/layout/layout_slider_container.cc
,
Apr 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df4c167cba637f1d5c9feb6e66a49efc16bce3d4 commit df4c167cba637f1d5c9feb6e66a49efc16bce3d4 Author: Rune Lillesveen <futhark@chromium.org> Date: Sat Apr 28 00:10:12 2018 No need for SetUnique on parent for attr() content. When we had style sharing, we could not share ComputedStyle between elements which had pseudo ::before or ::after which relied on attr() content values from the originating element. This is not necessary for MatchedPropertiesCache since we don't share the pseudo style cache like we would do for shared ComputedStyle objects. This gets rid of a dependency on mutable parent ComputedStyle. Bug: 813068 Change-Id: I4b03e5b05c9bca595188d6506fdd2907e854596a Reviewed-on: https://chromium-review.googlesource.com/1032940 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#554574} [modify] https://crrev.com/df4c167cba637f1d5c9feb6e66a49efc16bce3d4/third_party/blink/renderer/core/css/ComputedStyleExtraFields.json5 [modify] https://crrev.com/df4c167cba637f1d5c9feb6e66a49efc16bce3d4/third_party/blink/renderer/core/css/resolver/style_builder_custom.cc
,
Apr 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17005ce5a2e98caed08193844f33e71496dd84ea commit 17005ce5a2e98caed08193844f33e71496dd84ea Author: Rune Lillesveen <futhark@chromium.org> Date: Sun Apr 29 23:26:57 2018 [Squad] Remove unnecessary user-modify update. With [1], user-modify is updated as part of style recalc for the inner editor element, and the inner editor element recalc is triggered from LayoutTextControl::StyleDidChange(). This removes the last mutable style access from LayoutTextControl. [1] https://crrev.com/4ef836ad2e67ce25e263514bcda94f808bfb02d6 Bug: 813068 Change-Id: I923e0081b2bb2a796b512e23a027550c35b045e4 Reviewed-on: https://chromium-review.googlesource.com/1034052 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#554678} [modify] https://crrev.com/17005ce5a2e98caed08193844f33e71496dd84ea/third_party/blink/renderer/core/layout/layout_text_control.cc [modify] https://crrev.com/17005ce5a2e98caed08193844f33e71496dd84ea/third_party/blink/renderer/core/layout/layout_text_control.h
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c85b62118cf82ce2758aa47a8ca082bc0c40496 commit 7c85b62118cf82ce2758aa47a8ca082bc0c40496 Author: Rune Lillesveen <futhark@chromium.org> Date: Wed May 02 17:33:27 2018 [Squad] Update text combine font on setting style. Updating the font on paint required mutable access to the ComputedStyle member of LayoutObject. Instead, update the font when style is computed or when the text is modified. Note that we still need a mutable style from the parent, but that is trivial to fix once all other mutable access to LayoutObject's ComputedStyle is gone. Bug: 813068 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id9bb1eb3a89cf20a36d91a5182323d8f450e9f55 Reviewed-on: https://chromium-review.googlesource.com/1033748 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Dominik Röttsches <drott@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#555455} [modify] https://crrev.com/7c85b62118cf82ce2758aa47a8ca082bc0c40496/third_party/blink/renderer/core/editing/commands/set_character_data_command_test.cc [modify] https://crrev.com/7c85b62118cf82ce2758aa47a8ca082bc0c40496/third_party/blink/renderer/core/layout/layout_text_combine.cc [modify] https://crrev.com/7c85b62118cf82ce2758aa47a8ca082bc0c40496/third_party/blink/renderer/core/layout/layout_text_combine.h [modify] https://crrev.com/7c85b62118cf82ce2758aa47a8ca082bc0c40496/third_party/blink/renderer/core/paint/inline_text_box_painter.cc
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c535a3597e30618afe0517771b255f21d7d9fa6 commit 1c535a3597e30618afe0517771b255f21d7d9fa6 Author: Rune Lillesveen <futhark@chromium.org> Date: Thu May 03 08:31:44 2018 [Squad] Use logical width/height override for media controls. Gets rid of mutable style access from layout. Bug: 813068 Change-Id: Ie6af46ed9a0be75b692a8443929fe3de1db774df Reviewed-on: https://chromium-review.googlesource.com/1039571 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#555679} [modify] https://crrev.com/1c535a3597e30618afe0517771b255f21d7d9fa6/third_party/blink/renderer/core/layout/layout_media.cc
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f4fa0962b8bc490ce3bf0e2005a99282e2f4b56 commit 9f4fa0962b8bc490ce3bf0e2005a99282e2f4b56 Author: Rune Lillesveen <futhark@chromium.org> Date: Thu May 03 11:36:49 2018 [Squad] Remove logical width override for input placeholder. Relying on normal layout for widths works. Gets rid of mutable style access for input placeholders. TEST=fast/forms Bug: 813068 Change-Id: Ie8501137f9c9ed5ef04505ca5147ad691f0cfaed Reviewed-on: https://chromium-review.googlesource.com/1039785 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#555693} [modify] https://crrev.com/9f4fa0962b8bc490ce3bf0e2005a99282e2f4b56/third_party/blink/renderer/core/layout/layout_text_control_multi_line.cc
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29a56c3a3b67ce57b3d32fbddb02b9fe46418961 commit 29a56c3a3b67ce57b3d32fbddb02b9fe46418961 Author: Rune Lillesveen <futhark@chromium.org> Date: Thu May 03 14:58:36 2018 [Squad] Use SetOverrideLogicalWidth for single line placeholder. We need the special-cased width because of some icon taking up space for input type="search". However, we should not modify computed style to do so. Instead use SetOverrideLogicalWidth(). Gets rid of MutableStyleRef() access. TEST=fast/forms/placeholder-position.html Bug: 813068 Change-Id: I93886bc8c53ff84b3c37a0cc543ab7dc274a758f Reviewed-on: https://chromium-review.googlesource.com/1041932 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#555729} [modify] https://crrev.com/29a56c3a3b67ce57b3d32fbddb02b9fe46418961/third_party/blink/renderer/core/layout/layout_text_control_single_line.cc
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c9f4e091a45c71383aad585a5848f94757f6c19 commit 3c9f4e091a45c71383aad585a5848f94757f6c19 Author: Rune Lillesveen <futhark@chromium.org> Date: Thu May 10 09:44:44 2018 [Squad] Get rid of mutable style access in list item markers. Instead of modifying ComputedStyle in place for margins, clone the style if necessary before setting the new margins. UpdateMarginsAndContent() has been modified to call ComputePreferredLogicalWidths() in the case of dirty preferred widths because that method will call UpdateContent() and UpdateMargins(). We had problems with UpdateMargins() being re-entered causing the style member of LayoutObject to change multiple times during the process when MinPreferredLogicalWidth() was called during UpdateMargins(). Bug: 813068 Change-Id: I902de039f6291ca56c47f88b1f69eee06afb18ca Reviewed-on: https://chromium-review.googlesource.com/1051807 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: cathie chen <cathiechen@tencent.com> Cr-Commit-Position: refs/heads/master@{#557483} [modify] https://crrev.com/3c9f4e091a45c71383aad585a5848f94757f6c19/third_party/blink/renderer/core/layout/layout_list_item.cc [modify] https://crrev.com/3c9f4e091a45c71383aad585a5848f94757f6c19/third_party/blink/renderer/core/layout/layout_list_marker.cc
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc834db47871842b7961247dff3cce0dd9b358dd commit bc834db47871842b7961247dff3cce0dd9b358dd Author: Rune Lillesveen <futhark@chromium.org> Date: Mon May 14 11:17:21 2018 [Squad] Get rid of MutableStyleRef() in list items. Clone and reset ComputedStyle When modifying the style of anonymous layout objects inside list items. Bug: 813068 Change-Id: Icd0d9d93d0e64fd130cfb5ba151bce7c34bfb234 Reviewed-on: https://chromium-review.googlesource.com/1053727 Reviewed-by: cathie chen <cathiechen@tencent.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#558257} [add] https://crrev.com/bc834db47871842b7961247dff3cce0dd9b358dd/third_party/WebKit/LayoutTests/external/wpt/css/css-display/display-list-item-height-after-dom-change.html [modify] https://crrev.com/bc834db47871842b7961247dff3cce0dd9b358dd/third_party/blink/renderer/core/layout/layout_list_item.cc
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16a2164f7370d08a07206bcb2001668e56269af5 commit 16a2164f7370d08a07206bcb2001668e56269af5 Author: Rune Lillesveen <futhark@chromium.org> Date: Mon May 14 19:37:46 2018 [Squad] Immutable style for LayoutMenuList inner_block. The anonymous block inside LayoutMenuList had its ComputedStyle modified in place. Instead, clone it for modification if necessary. Also, optimized a bit by not modifying the style when the active option text is modified if the option style does not change. Bug: 813068 Change-Id: I25e6aca96e795c7c822dd62f03c946be480f3020 Reviewed-on: https://chromium-review.googlesource.com/1057328 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#558417} [modify] https://crrev.com/16a2164f7370d08a07206bcb2001668e56269af5/third_party/blink/renderer/core/layout/layout_menu_list.cc [modify] https://crrev.com/16a2164f7370d08a07206bcb2001668e56269af5/third_party/blink/renderer/core/layout/layout_menu_list.h
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd496fe66288aa7d21846d3cbe9d5ca86d84e6ca commit dd496fe66288aa7d21846d3cbe9d5ca86d84e6ca Author: Rune Lillesveen <futhark@chromium.org> Date: Tue May 15 21:09:36 2018 [Squad] Make kPseudoIdFirstLineInherited an internal pseudo. Gets rid of MutableStyleRef() access where we called SetHasPseudo() for the inherited first-line styles in order to not return early from GetCachedPseudoStyle. TEST=fast/css/invalidation/first-line-change-inline-color-inherited.html Bug: 813068 Change-Id: Ib34d8ae23e6203ccb27511fb3f5580d8d3002500 Reviewed-on: https://chromium-review.googlesource.com/1059249 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#558831} [modify] https://crrev.com/dd496fe66288aa7d21846d3cbe9d5ca86d84e6ca/third_party/blink/renderer/core/css/ComputedStyleExtraFields.json5 [modify] https://crrev.com/dd496fe66288aa7d21846d3cbe9d5ca86d84e6ca/third_party/blink/renderer/core/layout/layout_object.cc [modify] https://crrev.com/dd496fe66288aa7d21846d3cbe9d5ca86d84e6ca/third_party/blink/renderer/core/style/computed_style_constants.h
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8725541d0c5eca5da98d89936e32b1ecbaad6ec6 commit 8725541d0c5eca5da98d89936e32b1ecbaad6ec6 Author: Rune Lillesveen <futhark@chromium.org> Date: Tue May 15 21:15:02 2018 [Squad] Remove unnecessary option/optgroup style code. After the change to recalc style for reattachment in the style recalc step also for elements with custom style hooks, we no longer need to have this special code for non-attached style for options/optgroups with slots. This also means we don't need to re-retrieve the non-attached style for the LayoutTreeBuilder. Bug: 813068 Change-Id: I978a429dd43d00863ca8987054b7902c2e9318f5 Reviewed-on: https://chromium-review.googlesource.com/1059517 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#558834} [modify] https://crrev.com/8725541d0c5eca5da98d89936e32b1ecbaad6ec6/third_party/blink/renderer/core/dom/layout_tree_builder.cc [modify] https://crrev.com/8725541d0c5eca5da98d89936e32b1ecbaad6ec6/third_party/blink/renderer/core/html/forms/html_option_element.cc [modify] https://crrev.com/8725541d0c5eca5da98d89936e32b1ecbaad6ec6/third_party/blink/renderer/core/html/forms/html_option_element.h [modify] https://crrev.com/8725541d0c5eca5da98d89936e32b1ecbaad6ec6/third_party/blink/renderer/core/html/forms/html_select_element.cc [modify] https://crrev.com/8725541d0c5eca5da98d89936e32b1ecbaad6ec6/third_party/blink/renderer/core/html/forms/html_select_element.h [modify] https://crrev.com/8725541d0c5eca5da98d89936e32b1ecbaad6ec6/third_party/blink/renderer/core/html/html_slot_element.cc
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5702d12b4fd7796a3a188d5b0c45a7ef5067a496 commit 5702d12b4fd7796a3a188d5b0c45a7ef5067a496 Author: Rune Lillesveen <futhark@chromium.org> Date: Mon Sep 03 08:05:22 2018 Make ComputedStyle const when possible. Bug: 813068 Change-Id: I6e486865e443643f0efd4d1bceaea6d6c3ecc4c2 Reviewed-on: https://chromium-review.googlesource.com/1201582 Reviewed-by: Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#588346} [modify] https://crrev.com/5702d12b4fd7796a3a188d5b0c45a7ef5067a496/third_party/blink/renderer/core/dom/element.cc [modify] https://crrev.com/5702d12b4fd7796a3a188d5b0c45a7ef5067a496/third_party/blink/renderer/core/dom/element.h [modify] https://crrev.com/5702d12b4fd7796a3a188d5b0c45a7ef5067a496/third_party/blink/renderer/core/layout/layout_object.cc [modify] https://crrev.com/5702d12b4fd7796a3a188d5b0c45a7ef5067a496/third_party/blink/renderer/core/layout/layout_object.h [modify] https://crrev.com/5702d12b4fd7796a3a188d5b0c45a7ef5067a496/third_party/blink/renderer/core/layout/layout_scrollbar.cc [modify] https://crrev.com/5702d12b4fd7796a3a188d5b0c45a7ef5067a496/third_party/blink/renderer/core/style/computed_style.cc [modify] https://crrev.com/5702d12b4fd7796a3a188d5b0c45a7ef5067a496/third_party/blink/renderer/core/style/computed_style.h |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Feb 16 2018