Text.app is suggested for opening AMR audio file in Downloads |
|||||||||||
Issue descriptionSplit from Issue 810986 . Chrome Version: 66.0.3350.0 Repro Steps: (1) Put an .amr file into Downloads. (2) Right-click it and choose "Open with...". (3) See the task list in "Open with..." dialog. Expected: Only lists audio player or editor apps, but not obvious. Actual: "Open with Text" appears in the list. Note: mimeType of the file is "application/octet-stream". Text.app supports ["application/javascript", "application/json", "application/x-shellscript", "application/xml", "text/*"] as MIME type, as well as the file name extensions. https://github.com/googlearchive/text-app/blob/master/manifest.json (I also saw "Word (Install)" but out of this bug's scope.)
,
Feb 16 2018
,
Feb 22 2018
,
Feb 22 2018
,
Feb 28 2018
,
Mar 1 2018
,
Mar 28 2018
,
Oct 31
,
Nov 19
,
Nov 21
,
Nov 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8100d4b5a4f5b6f4a6957acd57a1b167022c5cae commit 8100d4b5a4f5b6f4a6957acd57a1b167022c5cae Author: Anand K. Mistry <amistry@chromium.org> Date: Mon Nov 26 01:18:13 2018 Add AMR to the MIME sniffer's list of extra magic numbers. Shell scripts start with "#!", therefore the primary list of magic numbers recognises these as text/plain. However, AMR files also start with "#!", which causes them to be misidentified. BUG= 813059 Change-Id: Icabf35126053a0e65c4d3a45c663c9122eb4a7a9 Reviewed-on: https://chromium-review.googlesource.com/c/1348887 Reviewed-by: Asanka Herath <asanka@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#610748} [modify] https://crrev.com/8100d4b5a4f5b6f4a6957acd57a1b167022c5cae/net/base/mime_sniffer.cc [modify] https://crrev.com/8100d4b5a4f5b6f4a6957acd57a1b167022c5cae/net/base/mime_sniffer_unittest.cc
,
Nov 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8379101d13697f031977c088ce671bab88a4a1ab commit 8379101d13697f031977c088ce671bab88a4a1ab Author: Anand K. Mistry <amistry@chromium.org> Date: Mon Nov 26 02:50:28 2018 Re-sniff AMR files to correctly identify them. AMR files begin with "#!", which looks like a shell script, which causes the primary sniffer to think the file is plain text. Re-sniff using the expanded types sniffer to properly detect the file as AMR. BUG= 813059 Change-Id: Ic4843ce0773a0cba028dde7f134ad32215cacd5d Reviewed-on: https://chromium-review.googlesource.com/c/1349129 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610752} [modify] https://crrev.com/8379101d13697f031977c088ce671bab88a4a1ab/extensions/browser/api/file_handlers/mime_util.cc [modify] https://crrev.com/8379101d13697f031977c088ce671bab88a4a1ab/extensions/browser/api/file_handlers/mime_util_unittest.cc
,
Nov 26
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by yamaguchi@chromium.org
, Feb 16 2018