New issue
Advanced search Search tips

Issue 813034 link

Starred by 1 user
Status: Fixed
Owner:
weili@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Compat



Sign in to add a comment

[Missing Test]: Glyphs are not rendered correctly in print preview / PDF

Project Member Reported by krajshree@chromium.org, Feb 16 2018 
Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
----
https://chromium.googlesource.com/chromium/src.git/+/a3533592984bdb788d1335a223b37e125a07c99c

Ref Bug: 
---------
https://bugs.chromium.org/p/chromium/issues/detail?id=809763

Thank you.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/feb3b5d8fc0436f4ae83736f450544142e9a21f1

commit feb3b5d8fc0436f4ae83736f450544142e9a21f1
Author: Wei Li <weili@chromium.org>
Date: Sat Mar 10 06:28:54 2018

Allow mojo services to have blink web sandbox support

Most mojo services are simple utility processes that don't require
blink web sandbox support. However, services such as pdf compositor
would need such support to access and load fonts. This CL does the
following two major tasks:
-- Add SandboxSupportedUtilityBlinkPlatformImpl and implements it
to allow utility process to have the sandbox support when needed;
-- Move LoadFont() interprocess call on MacOS from renderer to
content/common, so it can be used by both renderer and utility
processes.

BUG= 809763 , 813034 

Change-Id: I4f8b50cc5cc31ac68dfbc2ba5b1195fb4e0748cc
Reviewed-on: https://chromium-review.googlesource.com/919968
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542361}
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/chrome/browser/printing/print_browsertest.cc
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/components/printing/service/BUILD.gn
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/components/printing/service/DEPS
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/components/printing/service/pdf_compositor_manifest.json
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/components/printing/service/pdf_compositor_service.cc
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/components/printing/service/pdf_compositor_service_unittest.cc
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/components/printing/service/public/cpp/pdf_compositor_service_factory.cc
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/browser/renderer_host/render_message_filter.cc
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/browser/renderer_host/render_message_filter.h
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/browser/service_manager/common_browser_interfaces.cc
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/child/BUILD.gn
[add] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/child/child_process_sandbox_support_impl_mac.cc
[add] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/child/child_process_sandbox_support_impl_mac.h
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/child/child_thread_impl.cc
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/child/child_thread_impl.h
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/common/BUILD.gn
[add] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/common/font_loader_dispatcher_mac.cc
[add] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/common/font_loader_dispatcher_mac.h
[add] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/common/font_loader_mac.mojom
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/common/render_message_filter.mojom
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/ppapi_plugin/ppapi_blink_platform_impl.cc
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/public/app/mojo/content_renderer_manifest.json
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/public/child/child_thread.h
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/public/test/mock_render_thread.cc
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/public/test/mock_render_thread.h
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/public/utility/utility_thread.h
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/utility/BUILD.gn
[add] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/utility/utility_blink_platform_with_sandbox_support_impl.cc
[add] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/utility/utility_blink_platform_with_sandbox_support_impl.h
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/utility/utility_thread_impl.cc
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/content/utility/utility_thread_impl.h
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/third_party/WebKit/public/platform/linux/WebSandboxSupport.h
[modify] https://crrev.com/feb3b5d8fc0436f4ae83736f450544142e9a21f1/third_party/WebKit/public/platform/mac/WebSandboxSupport.h

Comment 2 by weili@chromium.org, Mar 13 2018

Status: Fixed (was: Assigned)
Added test in the CL above.
►

Sign in to add a comment