Issue metadata
Sign in to add a comment
|
Regression: Unnecessary translation bar is seen after signing out from Gmail account.
Reported by
pranjali...@etouch.net,
Feb 16 2018
|
|||||||||||||||||||||||
Issue descriptionChrome Version: 66.0.3349.0 (Official Build) 63cd2c2dfef0dbc7a588006b72e0ec358026cf11-refs/heads/master@{#537110}(64 bit) OS: Mac(10.12.6, 10.13.1, 10.13.4). Steps to reproduce: 1. Launch chrome and navigate to https://accounts.google.com. 2. Sign in Gmail with valid credentials , click on save button on save password bubble and then sign out from gmail account. 3. Repeat step 2 and observe. Actual: Unnecessary translation bar is seen after signing out from gmail account. Expected: Translation bar should not be seen after signing out from gmail account. This is Regression issue broken in 'M-66’ and Using the per-revision bisect providing the bisect results, Good Build:66.0.3348.0 (Revision: 536935) Bad Build:66.0.3349.0 (Revision: 537110) You are probably looking for a change made after 536968 (known good), but no later than 536969 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/a85265e3f9b269648fab357695479fd56fcd1e2d..605ee9330b375a6e91a99606be0800e6331fe524 Suspect: https://chromium.googlesource.com/chromium/src/+/605ee9330b375a6e91a99606be0800e6331fe524 @xiaochengh: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Note: Issue is not seen on Windows(7,8,8.1,10) and Linux(14.04 LTS). Kindly refer attached screen cast
,
Feb 16 2018
Adding release blocker label for this issue.Please reduce priority or remove if not the case. Thank You!
,
Feb 16 2018
My change resulted in some non-text content in the text dump: <meta http-equiv="refresh" content="0; url=https://accounts.google.com/ServiceLogin?continue=https%3A%2F%2Fmail.google.com%2Fmail%2F&nojavascript=1&service=mail&rm=false&ltmpl=default&scc=1&ss=1&osid=1&emr=1"><style nonce="C7smg7GbgfiWHSn8EJAa3tibnrs">body{opacity:0;}</style>GmailHi Xiaochengxiaochengh@chromium.orgEnter your passwordType the text you hear or seeNextForgot password?AfrikaansazərbaycancatalàČeštinaDanskDeutscheestiEnglish (United Kingdom)English (United States)Español (España)Español (Latinoamérica)euskaraFilipinoFrançais (Canada)Français (France)galegoHrvatskiIndonesiaisiZuluíslenskaItalianoKiswahililatviešulietuviųmagyarMelayuNederlandsnorskpolskiPortuguês (Brasil)Português (Portugal)românăSlovenčinaslovenščinaSuomiSvenskaTiếng ViệtTürkçeΕλληνικάбългарскимонголРусскийсрпскиУкраїнськаქართულიհայերենעבריתاردوالعربيةفارسیአማርኛनेपालीमराठीहिन्दीবাংলাગુજરાતીதமிழ்తెలుగుಕನ್ನಡമലയാളംසිංහලไทยລາວမြန်မာខ្មែរ한국어中文（香港）日本語简体中文繁體中文HelpPrivacyTerms The non-text content is from a NOSCRIPT element.
,
Feb 16 2018
,
Feb 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/797a3802e777fb42a24529261a1af57a8f899e12 commit 797a3802e777fb42a24529261a1af57a8f899e12 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Sun Feb 18 05:41:26 2018 Eliminate NOSCRIPT element from TranslateHelper text dump TranslateHelper uses a sample of the page text to determine the page language. This patch eliminates content of NOSCRIPT elements from the text dump, so that non-text contents in NOSCRIPT elements are not passed to TranslateHelper. Bug: 813009 Change-Id: Icf1781a69d17538103574bd149cb3d5851852a08 Reviewed-on: https://chromium-review.googlesource.com/924111 Reviewed-by: Rachel Blum <groby@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#537557} [modify] https://crrev.com/797a3802e777fb42a24529261a1af57a8f899e12/third_party/WebKit/Source/core/exported/WebFrameContentDumper.cpp
,
Feb 18 2018
Test team: could you verify if the patch in #6 fixes the issue? Thanks!
,
Feb 19 2018
,
Feb 21 2018
mac triage: reassigning to xiaochengh for followup.
,
Feb 21 2018
Test team: Could you test with 66.0.3351.0 or later versions? 66.0.3350.0 was branched at r537342, and doesn't contain my fix attempt. Btw, I can't reproduce this issue locally. I'm wondering if I need the specific test account, since it depends on the text dump of the page, which differs with different accounts
,
Feb 22 2018
Update : Verified above issue in latest Canary #66.0.3352.0 build on Mac(10.12.6, 10.13.1, 10.13.4) OS and the issue is fixed. The fix is working as intended. Kindly review an attached screencast. Thank you!
,
Feb 22 2018
,
Feb 22 2018
mac triage: marking verified :)
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ccfb59af9d1773592076f35d5210b30f9e3ff617 commit ccfb59af9d1773592076f35d5210b30f9e3ff617 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Wed Apr 04 00:57:35 2018 Revert "Eliminate NOSCRIPT element from TranslateHelper text dump" This reverts commit 797a3802e777fb42a24529261a1af57a8f899e12. Reason for revert: The overall approach is a hack that keeps generating regressions Original change's description: > Eliminate NOSCRIPT element from TranslateHelper text dump > > TranslateHelper uses a sample of the page text to determine the page > language. This patch eliminates content of NOSCRIPT elements from the > text dump, so that non-text contents in NOSCRIPT elements are not passed > to TranslateHelper. > > Bug: 813009 > Change-Id: Icf1781a69d17538103574bd149cb3d5851852a08 > Reviewed-on: https://chromium-review.googlesource.com/924111 > Reviewed-by: Rachel Blum <groby@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537557} TBR=groby@chromium.org,eae@chromium.org,tkent@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 813009 Change-Id: Ibb2557436cdb5b07586bc69177f1456dc435568c Reviewed-on: https://chromium-review.googlesource.com/994059 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#547905} [modify] https://crrev.com/ccfb59af9d1773592076f35d5210b30f9e3ff617/third_party/WebKit/Source/core/exported/WebFrameContentDumper.cpp
,
Apr 5 2018
There is one more revert crrev.com/98199e90 landed. Test team: could you test if the issue reproduces with 67.0.3389.0 or later version? Thanks!
,
Apr 5 2018
w.r.t comment#16 Verified the above issue in latest Canary #67.0.3389.0 build on Mac(10.12.6, 10.13.1, 10.13.4) OS and the issue is fixed. The fix is working as intended. Kindly review an attached screencast. Thank you!
,
Apr 5 2018
This bug requires manual review: We are only 11 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 5 2018
Approving reverts in M66. Branch:3359
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34eb1e709d89f5a8a9eabd8c240d9c25517fc0a6 commit 34eb1e709d89f5a8a9eabd8c240d9c25517fc0a6 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Thu Apr 05 18:00:19 2018 Revert "Eliminate NOSCRIPT element from TranslateHelper text dump" This reverts commit 797a3802e777fb42a24529261a1af57a8f899e12. Reason for revert: The overall approach is a hack that keeps generating regressions Original change's description: > Eliminate NOSCRIPT element from TranslateHelper text dump > > TranslateHelper uses a sample of the page text to determine the page > language. This patch eliminates content of NOSCRIPT elements from the > text dump, so that non-text contents in NOSCRIPT elements are not passed > to TranslateHelper. > > Bug: 813009 > Change-Id: Icf1781a69d17538103574bd149cb3d5851852a08 > Reviewed-on: https://chromium-review.googlesource.com/924111 > Reviewed-by: Rachel Blum <groby@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537557} TBR=groby@chromium.org,eae@chromium.org,tkent@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 813009 Change-Id: Ibb2557436cdb5b07586bc69177f1456dc435568c Reviewed-on: https://chromium-review.googlesource.com/994059 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#547905}(cherry picked from commit ccfb59af9d1773592076f35d5210b30f9e3ff617) Reviewed-on: https://chromium-review.googlesource.com/998175 Cr-Commit-Position: refs/branch-heads/3359@{#589} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/34eb1e709d89f5a8a9eabd8c240d9c25517fc0a6/third_party/WebKit/Source/core/exported/WebFrameContentDumper.cpp
,
Apr 5 2018
,
Apr 12 2018
Update : Verified above issue in latest Beta#66.0.3359.106 build on Mac(10.12.6, 10.13.1, 10.13.5) OS and the issue is fixed. The fix is working as intended. Kindly review an attached screencast. Thank you!
|
||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||
Comment 1 by pranjali...@etouch.net
, Feb 16 2018