New issue
Advanced search Search tips

Issue 812998 link

Starred by 1 user
Status: Fixed
Owner:
cfroussios@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Password Export: add colon and remove ellipsis in error message strings

Project Member Reported by maxwalker@chromium.org, Feb 16 2018 
Chrome Version:  66.0.3349.0
OS: Desktop all

Two minor string changes: could you please add a colon after "Try the following tips" and remove the "..." in the "Try again" button as shown in the attached mock? Thanks!
Export - Error Message.png
305 KB View Download

Comment 1 by cfroussios@chromium.org, Feb 16 2018 

Attaching screenshot of coming fix
Screenshot from 2018-02-16 11-43-46.png
63.5 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ff488122c5a0e45b9a89818826f835d7d0584ea

commit 6ff488122c5a0e45b9a89818826f835d7d0584ea
Author: Christos Froussios <cfroussios@chromium.org>
Date: Fri Feb 16 10:54:03 2018

[Password Manager] Export UI string updates

TBR=jcivelli@chromium.org

Bug:  812998 
Change-Id: I34b710517d8c6b066e9f66d6f98863194046ddfd
Reviewed-on: https://chromium-review.googlesource.com/923942
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537279}
[modify] https://crrev.com/6ff488122c5a0e45b9a89818826f835d7d0584ea/chrome/app/settings_strings.grdp

Comment 3 by cfroussios@chromium.org, Feb 16 2018

Status: Fixed (was: Assigned)

Comment 4 by susan.boorgula@chromium.org, Feb 19 2018

Labels: Needs-Feedback
Tried verifying the fix on Windows 10, Mac OS 10.12.6 and Ubuntu 14.04 on the latest Chrome build 66.0.3350.0 by following the below steps.

1. Launched Chrome and navigated to chrome://settings/passwords. Saved more than 100 passwords.
2. Clicked on the 3 dot menu -> Export passwords.
3. Able to export the passwords to the system and cannot observe the above give error message.
Attached the screen cast for reference.

cfroussios@ Request you to please check and confirm if anything is missed from our end in verifying the fix on the latest Canary builds.

Thanks..
812998.webm
4.8 MB View Download

Comment 5 by cfroussios@chromium.org, Feb 19 2018 

To reproduce the error message, you can try one of the following
1. Export to drive without free space (e.g. a usb memory stick that is full)
2. Export to a folder where access is not allowed (you must not be an administrator), e.g.
    * Windows: "Windows\System32"
    * Mac and Linux: "/"
   On some environments, the file selector will prevent you from selecting such folders altogether, thus preventing you from testing the error message.
►

Sign in to add a comment