Stop treating Fuchsia as a POSIX platform |
||||||||||||
Issue descriptionWe currently define |is_posix| when |is_fuchsia| is true, to use Chromium's POSIX implementations of various platform-integration classes. We currently have complexity from Fuchsia-specific specializations, and exceptions to usage of OS_POSIX code blocks under Fuchsia. Removing |is_posix| would mean explicitly opting-in Fuchsia to OS_POSIX conditional code, where necessary (e.g. for //base integration classes like FilePath and File), but since we intend to migrate more code to Fuchsia-native implementations, there will be a tipping-point at which there would be fewer such opt-ins with is_posix=false than there are opt-outs with is_posix=true. We should evaluate how much work remains before we can remove |is_posix| under Fuchsia.
,
Feb 26 2018
May be possible to migrate V8 away from treating Fuchsia as POSIX-with-oddities, ahead of the Chromium-wide migration.
,
Mar 27 2018
,
Mar 27 2018
,
Mar 28 2018
First issue we should solve is automatically adding _fuchsia files for Fuchsia. I am not sure how to treat _posix files. It is quite a large change to add them manually for Fuchsia at this point. Do we expect to have less and less of these in the Fuchsia build as time goes on?
,
Mar 28 2018
Re #5: GN doesn't (and won't) support automagically adding _fuchsia.* files only when building for target_os="fuchsia". The existing Windows, Mac, POSIX, etc automagical handling of source files were grandfathered in, for ease of migration from GYP, I believe. We expect that most of the reliance on _posix.* files will go away as we port more things to Fuchsia-native primitives.
,
Mar 29 2018
FYI the _posix files are added by https://cs.chromium.org/chromium/src/build/config/BUILDCONFIG.gn?type=cs&q=set_sources_assignment_filter&sq=package:chromium&l=403, not by built-in GN magic.
,
Mar 29 2018
Re #7: Thanks James! I'd forgotten precisely where they are implemented in a GN world, but IIRC we still prefer not to add more of them at this point, right?
,
Mar 29 2018
I started putting my thoughts and blockers in this doc: https://docs.google.com/document/d/13Ft6KsZ12C97QUdNn7lwCjLmX2WVJfnhkhyoTXiC9JI/edit# I believe in the short term, we'd want to keep including _posix files for fuchsia, even if we set is_posix to false. It's way too big of a change otherwise.
,
Mar 30 2018
I have something that builds locally and have a clearer idea of how we should proceed. 1) Patch all build files in third_party repositories to use is_posix || is_fuchsia 2) Patch src/ to switch is_posix to false. Keep including _posix files in BUILDCONFIG.gn. 3) Clean up defined(OS_POSIX) && !defined(OS_FUCHSIA) in the source files 4) Stop including _posix files by default - still not certain on how to proceed there, especially with third_party repositories.
,
Mar 30 2018
I updated the doc in comment #8 with the links to WIP CLs for third_party repos. This is the main repo CL: https://crrev.com/c/987377 I would appreciate getting approval / disapproval on the way to proceed before pestering people for third_party reviews. These only concern build files, not specific source files define blocks. The third_party repo changes essentially change (is_posix) to (is_posix || is_fuchsia), this ensures they work with Fuchsia whether is_posix is set to true or false. The main issue is that I cannot run PSQ on Chromium before everything has rolled in. I tested things locally and everything seemed to work though.
,
Mar 30 2018
marshall@->kmarshall@
,
Apr 4 2018
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/8d970f7496a792ceffc0c81a037aafda8932c3fb commit 8d970f7496a792ceffc0c81a037aafda8932c3fb Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Apr 04 18:27:21 2018 Prepare for |is_posix| switch in the Fuchsia build |is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: chromium:812974 Change-Id: Iabe2503db3d6d4cebf1445cb4ab0852b664e1dba Reviewed-on: https://pdfium-review.googlesource.com/29490 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> [modify] https://crrev.com/8d970f7496a792ceffc0c81a037aafda8932c3fb/BUILD.gn
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/dee930847568b85e25ef6db3e87a563057731e32 commit dee930847568b85e25ef6db3e87a563057731e32 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Apr 04 18:28:39 2018 Prepare for |is_posix| switch in the Fuchsia build |is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: 812974 Change-Id: Id84df5e2c481df23ec1cdde8753413a8b7de0ce4 Reviewed-on: https://chromium-review.googlesource.com/987627 Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> [modify] https://crrev.com/dee930847568b85e25ef6db3e87a563057731e32/BUILD.gn
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/buildtools/+/10d701fce52d192005512aa832dc82f9aae72b5d commit 10d701fce52d192005512aa832dc82f9aae72b5d Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Apr 04 17:41:52 2018 Prepare for |is_posix| switch in the Fuchsia build |is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: 812974 Change-Id: I3d8886c0935264fe1455b77ce0835c640cf9f85d [modify] https://crrev.com/10d701fce52d192005512aa832dc82f9aae72b5d/third_party/libc++abi/BUILD.gn
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/021f62798317ae0d1870f74f2f985b5d03384787 commit 021f62798317ae0d1870f74f2f985b5d03384787 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Apr 04 19:10:56 2018 Prepare for |is_posix| switch in the Fuchsia build in freetype/ |is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: 812974 Change-Id: I930c1866c1ee1121fc08720e94b3075b084ee250 Reviewed-on: https://chromium-review.googlesource.com/988795 Reviewed-by: Ben Wagner <bungeman@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548152} [modify] https://crrev.com/021f62798317ae0d1870f74f2f985b5d03384787/third_party/freetype/BUILD.gn
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/284db8b8760eb4a102ad26974d29679acf2ebb65 commit 284db8b8760eb4a102ad26974d29679acf2ebb65 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Apr 04 19:45:58 2018 Prepare for |is_posix| switch in the Fuchsia build in blink |is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: 812974 Change-Id: I13429e796618d3773df720259d672ae26d2390b8 Reviewed-on: https://chromium-review.googlesource.com/988810 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548162} [modify] https://crrev.com/284db8b8760eb4a102ad26974d29679acf2ebb65/third_party/WebKit/Source/modules/webdatabase/BUILD.gn [modify] https://crrev.com/284db8b8760eb4a102ad26974d29679acf2ebb65/third_party/WebKit/Source/platform/BUILD.gn
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/284db8b8760eb4a102ad26974d29679acf2ebb65 commit 284db8b8760eb4a102ad26974d29679acf2ebb65 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Apr 04 19:45:58 2018 Prepare for |is_posix| switch in the Fuchsia build in blink |is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: 812974 Change-Id: I13429e796618d3773df720259d672ae26d2390b8 Reviewed-on: https://chromium-review.googlesource.com/988810 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548162} [modify] https://crrev.com/284db8b8760eb4a102ad26974d29679acf2ebb65/third_party/WebKit/Source/modules/webdatabase/BUILD.gn [modify] https://crrev.com/284db8b8760eb4a102ad26974d29679acf2ebb65/third_party/WebKit/Source/platform/BUILD.gn
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f07821bf0edca518df9e545a2640980f65024976 commit f07821bf0edca518df9e545a2640980f65024976 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Apr 04 19:55:53 2018 Prepare for |is_posix| switch in the Fuchsia build in gpu/ |is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: 812974 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I25c9a760ea6176935cb5bf946a9c5b499d93e640 Reviewed-on: https://chromium-review.googlesource.com/988793 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548168} [modify] https://crrev.com/f07821bf0edca518df9e545a2640980f65024976/gpu/BUILD.gn
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e02fc12d406ed062066451164101c712523d3b1 commit 1e02fc12d406ed062066451164101c712523d3b1 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Apr 04 20:20:46 2018 Prepare for |is_posix| switch in the Fuchsia build in boringssl/ |is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: 812974 Change-Id: Ic0292e13421cecacd54f49a981778cda746c08f0 Reviewed-on: https://chromium-review.googlesource.com/988839 Reviewed-by: Adam Langley <agl@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548179} [modify] https://crrev.com/1e02fc12d406ed062066451164101c712523d3b1/third_party/boringssl/BUILD.gn
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/mini_chromium/+/d64020797e1d5e0bcc24c1506b76320a6f7a5781 commit d64020797e1d5e0bcc24c1506b76320a6f7a5781 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Apr 04 20:25:08 2018 Prepare for |is_posix| switch in the Fuchsia build |is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: chromium:812974 Change-Id: I5cf6c5516d9db332e08dae0368656c35df043649 Reviewed-on: https://chromium-review.googlesource.com/988228 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> [modify] https://crrev.com/d64020797e1d5e0bcc24c1506b76320a6f7a5781/build/BUILD.gn [modify] https://crrev.com/d64020797e1d5e0bcc24c1506b76320a6f7a5781/build/compiler.gni [modify] https://crrev.com/d64020797e1d5e0bcc24c1506b76320a6f7a5781/build/sysroot.gni [modify] https://crrev.com/d64020797e1d5e0bcc24c1506b76320a6f7a5781/base/BUILD.gn
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84579ef3b242fa7c4f582b4385af715d2e06a3a2 commit 84579ef3b242fa7c4f582b4385af715d2e06a3a2 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Apr 04 20:47:31 2018 Prepare for |is_posix| switch in the Fuchsia build in libaom/ |is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: 812974 Change-Id: Id7994872ce40ac1823591b87ec7ef0439d5a8b88 Reviewed-on: https://chromium-review.googlesource.com/988840 Reviewed-by: Johann Koenig <johannkoenig@google.com> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548186} [modify] https://crrev.com/84579ef3b242fa7c4f582b4385af715d2e06a3a2/third_party/libaom/BUILD.gn
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30efd932c4641a19e91dfe9c23265580e7b0d994 commit 30efd932c4641a19e91dfe9c23265580e7b0d994 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Apr 04 21:06:12 2018 Prepare for |is_posix| switch in the Fuchsia build in yasm/ |is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: 812974 Change-Id: I682e0aca08051f4c930ea7b3435bdf3ca0c91d2b Reviewed-on: https://chromium-review.googlesource.com/988811 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548195} [modify] https://crrev.com/30efd932c4641a19e91dfe9c23265580e7b0d994/third_party/yasm/BUILD.gn [modify] https://crrev.com/30efd932c4641a19e91dfe9c23265580e7b0d994/third_party/yasm/yasm_assemble.gni
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/180b94aa7296237c45360a10dcc47ed72c69d8ea commit 180b94aa7296237c45360a10dcc47ed72c69d8ea Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Apr 04 22:15:30 2018 Prepare for |is_posix| switch in the Fuchsia build in libvpx/ |is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: 812974 Change-Id: I50409e8e4198a0b0e281cd6889c90935ca872402 Reviewed-on: https://chromium-review.googlesource.com/988846 Reviewed-by: Johann Koenig <johannkoenig@google.com> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548217} [modify] https://crrev.com/180b94aa7296237c45360a10dcc47ed72c69d8ea/third_party/libvpx/BUILD.gn
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/crashpad/crashpad.git/+/74a56c256b101eb1ded190cbda225a82c3f1872d commit 74a56c256b101eb1ded190cbda225a82c3f1872d Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Apr 04 22:18:25 2018 Prepare for removal of is_posix from the Fuchsia build This also rolls crashpad/third_party/mini_chromium/mini_chromium/ d42eb4101..6e0fdb2e4 (2 commits) https://chromium.googlesource.com/chromium/mini_chromium/+log/d42eb4101236..6e0fdb2e4966 $ git log d42eb4101..6e0fdb2e4 --date=short --no-merges --format='%ad %ae %s' 2018-04-04 scottmg@chromium.org Repair Linux-with-sysroot build after clang update 2018-04-04 fdegans Prepare for |is_posix| switch in the Fuchsia build Created with: roll-dep crashpad/third_party/mini_chromium/mini_chromium Bug: chromium:812974 Change-Id: I3d8efc3124c97981eda63f104a7adfb670babab7 Reviewed-on: https://chromium-review.googlesource.com/988231 Reviewed-by: Mark Mentovai <mark@chromium.org> [modify] https://crrev.com/74a56c256b101eb1ded190cbda225a82c3f1872d/DEPS [modify] https://crrev.com/74a56c256b101eb1ded190cbda225a82c3f1872d/snapshot/BUILD.gn [modify] https://crrev.com/74a56c256b101eb1ded190cbda225a82c3f1872d/test/BUILD.gn [modify] https://crrev.com/74a56c256b101eb1ded190cbda225a82c3f1872d/util/BUILD.gn
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3ca1fab7086421643eb287b20cdea3cc9105704 commit e3ca1fab7086421643eb287b20cdea3cc9105704 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Apr 04 22:19:36 2018 Prepare for |is_posix| switch in the Fuchsia build in mesa/ |is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: 812974 Change-Id: Ibfe71ea6fdd860fc83234fa31b3223339d0b71dc Reviewed-on: https://chromium-review.googlesource.com/988847 Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548219} [modify] https://crrev.com/e3ca1fab7086421643eb287b20cdea3cc9105704/third_party/mesa/BUILD.gn
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d22f6e10583bb8bc625db40a5408e680a27a54b0 commit d22f6e10583bb8bc625db40a5408e680a27a54b0 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Apr 04 23:50:40 2018 Clean up the build files for opus/ This came up as part of an effort to switch |is_posix| to false in Fuchsia. Bug: 812974 Change-Id: Ic8d4b745e4e88620d6ad598223d41d0b3ca08a3f Reviewed-on: https://chromium-review.googlesource.com/988850 Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548254} [modify] https://crrev.com/d22f6e10583bb8bc625db40a5408e680a27a54b0/third_party/opus/BUILD.gn
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58f84d059486796cc3652797eab5eab997720cad commit 58f84d059486796cc3652797eab5eab997720cad Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Thu Apr 05 00:51:57 2018 Remove unused section in build file. Bug: 812974 Change-Id: If3b39236ddc753f8ef3f8caab4b8c2a5b12497fd Reviewed-on: https://chromium-review.googlesource.com/988799 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#548273} [modify] https://crrev.com/58f84d059486796cc3652797eab5eab997720cad/third_party/libjingle_xmpp/BUILD.gn
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b550bdf85371692ae07a6646d0447f2a41add260 commit b550bdf85371692ae07a6646d0447f2a41add260 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Thu Apr 05 01:04:57 2018 Roll src/third_party/ffmpeg/ 5baad9325..dee930847 (1 commit) https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/5baad932589a..dee930847568 $ git log 5baad9325..dee930847 --date=short --no-merges --format='%ad %ae %s' 2018-03-30 fdegans Prepare for |is_posix| switch in the Fuchsia build Created with: roll-dep src/third_party/ffmpeg Bug: 812974 Change-Id: I28381804667b9b6a2fd085545db6bf3c80cd3009 Reviewed-on: https://chromium-review.googlesource.com/996474 Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548276} [modify] https://crrev.com/b550bdf85371692ae07a6646d0447f2a41add260/DEPS
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63478dbbb82de57cdc72a881c2e3276f8dfbd003 commit 63478dbbb82de57cdc72a881c2e3276f8dfbd003 Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Apr 05 05:02:50 2018 Roll src/third_party/pdfium/ dc566b0a7..32942201a (3 commits) https://pdfium.googlesource.com/pdfium.git/+log/dc566b0a76f9..32942201a456 $ git log dc566b0a7..32942201a --date=short --no-merges --format='%ad %ae %s' 2018-04-04 hnakashima Caret blinks with lower frequency in XFA text field. 2018-04-04 fdegans Prepare for |is_posix| switch in the Fuchsia build 2018-04-04 rharrison Expand ~ when present in directory path Created with: roll-dep src/third_party/pdfium BUG= chromium:812974 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3d406862bf3646ba6b53d031eb7b5172c169fbda Reviewed-on: https://chromium-review.googlesource.com/996307 Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548333} [modify] https://crrev.com/63478dbbb82de57cdc72a881c2e3276f8dfbd003/DEPS
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/deps/libsrtp/+/b79b83fb3e39fee9217dfab10e484bb92959c108 commit b79b83fb3e39fee9217dfab10e484bb92959c108 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Apr 04 17:49:45 2018 Prepare for |is_posix| switch in the Fuchsia build |is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: 812974 Change-Id: I3866e63afc2a5bbe44dc29071e3375a22c2630b7 [modify] https://crrev.com/b79b83fb3e39fee9217dfab10e484bb92959c108/BUILD.gn
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/3b348b4d883bce11926c8a33c08e12c7f7f3f168 commit 3b348b4d883bce11926c8a33c08e12c7f7f3f168 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Thu Apr 05 17:24:24 2018 Prepare for |is_posix| switch in the Fuchsia build |is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: chromium:812974 Change-Id: I2ae8e5ef4270cd0acbc7c69bb46d1be9ed4a5c5e Reviewed-on: https://chromium-review.googlesource.com/988253 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#52407} [modify] https://crrev.com/3b348b4d883bce11926c8a33c08e12c7f7f3f168/BUILD.gn
,
Apr 5 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/09a6cd55416e9ff8826d98c4de024b1cfa22104d commit 09a6cd55416e9ff8826d98c4de024b1cfa22104d Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Thu Apr 05 17:25:39 2018 Prepare for |is_posix| switch in the Fuchsia build |is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: chromium:812974 Change-Id: I3bfda3e056ad1e5229834286ce5d095d9204a428 Reviewed-on: https://webrtc-review.googlesource.com/65782 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#22753} [modify] https://crrev.com/09a6cd55416e9ff8826d98c4de024b1cfa22104d/BUILD.gn [modify] https://crrev.com/09a6cd55416e9ff8826d98c4de024b1cfa22104d/common_audio/BUILD.gn [modify] https://crrev.com/09a6cd55416e9ff8826d98c4de024b1cfa22104d/modules/audio_processing/BUILD.gn [modify] https://crrev.com/09a6cd55416e9ff8826d98c4de024b1cfa22104d/modules/desktop_capture/BUILD.gn [modify] https://crrev.com/09a6cd55416e9ff8826d98c4de024b1cfa22104d/modules/video_processing/BUILD.gn [modify] https://crrev.com/09a6cd55416e9ff8826d98c4de024b1cfa22104d/rtc_base/BUILD.gn
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb7df4866c1a44631949bea1fc1f53c708b3046b commit cb7df4866c1a44631949bea1fc1f53c708b3046b Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Thu Apr 05 20:56:25 2018 Prepare for |is_posix| switch in the Fuchsia build in ui/ |is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: 812974 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I884fbeef63c4566ecbcaee9fcc5b598af499aef5 Reviewed-on: https://chromium-review.googlesource.com/988953 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548553} [modify] https://crrev.com/cb7df4866c1a44631949bea1fc1f53c708b3046b/ui/gl/BUILD.gn
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/941edbe914a63c527ec9242eba540daf0524a461 commit 941edbe914a63c527ec9242eba540daf0524a461 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Thu Apr 05 22:02:29 2018 Update Crashpad to 1ebedb05dde4fccb9d9459062a3a9fa9cb28bd5a 74a56c256b10 Prepare for removal of is_posix from the Fuchsia build ba0bd63254a7 Use clang ref:goma instead of ref:latest 1ebedb05dde4 linux: Fix failing exception handler server test Bug: 812974 Change-Id: I9073a1c615356a4dc42973a81674789a33327235 Reviewed-on: https://chromium-review.googlesource.com/998733 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548578} [modify] https://crrev.com/941edbe914a63c527ec9242eba540daf0524a461/third_party/crashpad/README.chromium [modify] https://crrev.com/941edbe914a63c527ec9242eba540daf0524a461/third_party/crashpad/crashpad/DEPS [modify] https://crrev.com/941edbe914a63c527ec9242eba540daf0524a461/third_party/crashpad/crashpad/handler/linux/exception_handler_server_test.cc [modify] https://crrev.com/941edbe914a63c527ec9242eba540daf0524a461/third_party/crashpad/crashpad/snapshot/BUILD.gn [modify] https://crrev.com/941edbe914a63c527ec9242eba540daf0524a461/third_party/crashpad/crashpad/test/BUILD.gn [modify] https://crrev.com/941edbe914a63c527ec9242eba540daf0524a461/third_party/crashpad/crashpad/util/BUILD.gn
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/429a425201693467419c655d75a1209da16d00c3 commit 429a425201693467419c655d75a1209da16d00c3 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Thu Apr 05 23:08:34 2018 Roll src/third_party/openmax_dl/ 63d8cf470..59265e0e9 (1 commit) https://webrtc.googlesource.com/deps/third_party/openmax.git/+log/63d8cf4708c9..59265e0e9105 $ git log 63d8cf470..59265e0e9 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/openmax_dl Bug: 812974 Change-Id: Ie6973eb625671b98e3c4ec81dda3bb2cef252609 Reviewed-on: https://chromium-review.googlesource.com/998626 Reviewed-by: Raymond Toy <rtoy@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548604} [modify] https://crrev.com/429a425201693467419c655d75a1209da16d00c3/DEPS
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2b4839a5ee8347f72e03af3d76054bc8a1b9cc3 commit d2b4839a5ee8347f72e03af3d76054bc8a1b9cc3 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Fri Apr 06 05:36:52 2018 Roll src/buildtools/ 3748a2a90..10d701fce (1 commit) https://chromium.googlesource.com/chromium/buildtools.git/+log/3748a2a90871..10d701fce52d $ git log 3748a2a90..10d701fce --date=short --no-merges --format='%ad %ae %s' 2018-03-30 fdegans Prepare for |is_posix| switch in the Fuchsia build Created with: roll-dep src/buildtools TBR=glider@chromium.org Bug: 812974 Change-Id: I69ab175249b68a0b3bc9a1982556ba0305d8a3a4 Reviewed-on: https://chromium-review.googlesource.com/996481 Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548684} [modify] https://crrev.com/d2b4839a5ee8347f72e03af3d76054bc8a1b9cc3/DEPS
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4123a5e9892f0353f62fe5b80a00f634ca891839 commit 4123a5e9892f0353f62fe5b80a00f634ca891839 Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Apr 06 06:32:58 2018 Roll src/third_party/webrtc/ 4c9b3c840..19aab2ee7 (16 commits) https://webrtc.googlesource.com/src.git/+log/4c9b3c840df3..19aab2ee7c6b $ git log 4c9b3c840..19aab2ee7 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:812974,chromium:827080,chromium:None,chromium:794210,chromium:825524 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If6b26fb8305b2e0d8c796358684d52a63d181a77 Reviewed-on: https://chromium-review.googlesource.com/999352 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548696} [modify] https://crrev.com/4123a5e9892f0353f62fe5b80a00f634ca891839/DEPS
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54ecc45c405bab77c3b082015107806aa8c80b9e commit 54ecc45c405bab77c3b082015107806aa8c80b9e Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Fri Apr 06 20:19:24 2018 Prepare for |is_posix| switch in the Fuchsia build in libwebp/ |is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: 812974 Change-Id: Ibee8491def54881c5c9fefd69c7e88608998b93a Reviewed-on: https://chromium-review.googlesource.com/988805 Reviewed-by: James Zern <jzern@google.com> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548916} [modify] https://crrev.com/54ecc45c405bab77c3b082015107806aa8c80b9e/third_party/libwebp/BUILD.gn
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0dfc24ce0d579e86a812c82e465f7275664d75ec commit 0dfc24ce0d579e86a812c82e465f7275664d75ec Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Fri Apr 06 21:05:45 2018 Roll src/third_party/libsrtp/ 1d45b8e59..fc2345089 (2 commits) https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/1d45b8e599dc..fc2345089a6b $ git log 1d45b8e59..fc2345089 --date=short --no-merges --format='%ad %ae %s' 2018-03-30 fdegans Prepare for |is_posix| switch in the Fuchsia build 2017-07-26 agable Upload libsrtp changes to Gerrit by default Created with: roll-dep src/third_party/libsrtp Bug: 812974 Change-Id: I7c7872d020c2a02ee94e28babdf9e12f62607085 Reviewed-on: https://chromium-review.googlesource.com/998509 Reviewed-by: Patrik Höglund <phoglund@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548926} [modify] https://crrev.com/0dfc24ce0d579e86a812c82e465f7275664d75ec/DEPS
,
Apr 10 2018
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9fba3affd0a3246f2ec851c5f83cc3588a379086 commit 9fba3affd0a3246f2ec851c5f83cc3588a379086 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Thu Apr 12 19:00:48 2018 Stop setting is_posix for Fuchsia. This sets is_posix to false for the Fuchsia build as it will rely less and less on the POSIX implementation. Follow-up CLs will clean up build files from redundant checks and stop including _posix files by default. Bug: 812974 Change-Id: I6dc625ba2d4919a775041b1516e051b471c50e97 Reviewed-on: https://chromium-review.googlesource.com/987377 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#550292} [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/base/BUILD.gn [rename] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/base/power_monitor/power_monitor_device_source_stub.cc [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/base/test/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/build/config/BUILDCONFIG.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/build/config/compiler/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/build/config/fuchsia/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/build/config/posix/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/build/config/sanitizers/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/build/toolchain/toolchain.gni [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/chrome/app/resources/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/chrome/browser/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/components/crash/content/browser/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/content/public/browser/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/content/public/common/zygote_features.gni [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/content/test/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/media/media_options.gni [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/mojo/edk/embedder/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/net/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/third_party/sqlite/BUILD.gn
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/b40cc63e37c6b142b39645d61275ee05a08b4652 commit b40cc63e37c6b142b39645d61275ee05a08b4652 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Fri Apr 13 18:28:45 2018 Fix Fuchsia build configuration. This was missed in the original CL switching |is_posix| to false for Fuchsia. Bug: chromium:812974 Change-Id: I532516296c6b6ece9805c2f986c8dded00a798df Reviewed-on: https://chromium-review.googlesource.com/1011251 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#52599} [modify] https://crrev.com/b40cc63e37c6b142b39645d61275ee05a08b4652/gni/v8.gni
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9fba3affd0a3246f2ec851c5f83cc3588a379086 commit 9fba3affd0a3246f2ec851c5f83cc3588a379086 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Thu Apr 12 19:00:48 2018 Stop setting is_posix for Fuchsia. This sets is_posix to false for the Fuchsia build as it will rely less and less on the POSIX implementation. Follow-up CLs will clean up build files from redundant checks and stop including _posix files by default. Bug: 812974 Change-Id: I6dc625ba2d4919a775041b1516e051b471c50e97 Reviewed-on: https://chromium-review.googlesource.com/987377 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#550292} [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/base/BUILD.gn [rename] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/base/power_monitor/power_monitor_device_source_stub.cc [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/base/test/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/build/config/BUILDCONFIG.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/build/config/compiler/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/build/config/fuchsia/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/build/config/posix/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/build/config/sanitizers/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/build/toolchain/toolchain.gni [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/chrome/app/resources/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/chrome/browser/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/components/crash/content/browser/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/content/public/browser/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/content/public/common/zygote_features.gni [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/content/test/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/media/media_options.gni [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/mojo/edk/embedder/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/net/BUILD.gn [modify] https://crrev.com/9fba3affd0a3246f2ec851c5f83cc3588a379086/third_party/sqlite/BUILD.gn
,
Apr 18 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/450cdf3fc886457b830127d0f469167d81785f2e commit 450cdf3fc886457b830127d0f469167d81785f2e Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Apr 18 00:18:04 2018 Clean up posix-only files. This removes posix-only files from the default source set, forcing them to be explictly included for the desired configurations. Bug: chromium:812974 Change-Id: Ic4a1561f87395801ca4d3936a95a66fd4270c5ef Reviewed-on: https://webrtc-review.googlesource.com/70564 Reviewed-by: Benjamin Wright <benwright@webrtc.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#22913} [modify] https://crrev.com/450cdf3fc886457b830127d0f469167d81785f2e/modules/desktop_capture/BUILD.gn [modify] https://crrev.com/450cdf3fc886457b830127d0f469167d81785f2e/system_wrappers/BUILD.gn
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81dbd304f40b702b10e64aedd8fbefe1c1a826f2 commit 81dbd304f40b702b10e64aedd8fbefe1c1a826f2 Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Apr 18 11:06:22 2018 Roll src/third_party/webrtc/ 4478d9b77..b02644f2b (12 commits) https://webrtc.googlesource.com/src.git/+log/4478d9b7733d..b02644f2b89d $ git log 4478d9b77..b02644f2b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG= chromium:812974 ,chromium:None,chromium:None,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icd96d3e68659f9f0bc8017a17c00109c02edf4f0 Reviewed-on: https://chromium-review.googlesource.com/1016540 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551630} [modify] https://crrev.com/81dbd304f40b702b10e64aedd8fbefe1c1a826f2/DEPS
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/mini_chromium/+/ce9be1361314abd30f130176d42b32a422eac203 commit ce9be1361314abd30f130176d42b32a422eac203 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Apr 18 18:40:03 2018 Set |posix| to false for the Fuchsia build. This follows the chromium change for consistency. Bug: chromium:812974 Change-Id: I1a831219ed02bbe11cc037bebd4a98d2d7d76739 Reviewed-on: https://chromium-review.googlesource.com/1016034 Reviewed-by: Scott Graham <scottmg@chromium.org> [modify] https://crrev.com/ce9be1361314abd30f130176d42b32a422eac203/build/platform.gni
,
Apr 20 2018
,
Apr 24 2018
,
Jan 10
Fixing the grammar in the title at the same time :) This is done, Fuchsia and Posix have been decoupled. |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by cpu@chromium.org
, Feb 20 2018