New issue
Advanced search Search tips

Issue 812955 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Feb 2018
Cc:
sadrul@chromium.org
boliu@chromium.org
ericrk@chromium.org
cblume@chromium.org
chiniforooshan@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Add toplevel traces to WebView display callbacks

Project Member Reported by vmi...@chromium.org, Feb 16 2018 
As noted in  Issue 811584  comment #19, WebView display callbacks run on an Android UI owned thread, where we're missing the default "toplevel" trace instrumentation in the message loop such as is present in Chrome's "MessageLoop::RunTask".

This means that (1) we were missing thread timing for code running on this thread and (2) we could get bogus metric alerts as in  Issue 811584 .

Adding traces to these callbacks with "toplevel" trace category should address this.

Comment 1 by boliu@chromium.org, Feb 16 2018 

is it just adding the "toplevel" category to the trace event? that would be this event:
https://cs.chromium.org/chromium/src/android_webview/browser/render_thread_manager.cc?rcl=50ec3d691f1560dd82781fe8e75e24137b54a52b&l=291

there should be two per frame

> (1) we were missing thread timing for code running on this thread and

that event won't cover android code, so we won't get timing from those events. best we can do I guess
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f2e2f3ad18154cc118413b74e5777c686a5c5c2

commit 3f2e2f3ad18154cc118413b74e5777c686a5c5c2
Author: Bo Liu <boliu@chromium.org>
Date: Fri Feb 16 20:02:58 2018

aw: Make DrawFunctor event toplevel

Bug:  812955 
Change-Id: Ice08cc78a2b3f2849d6fdcb1ce4c0e191088fd79
Reviewed-on: https://chromium-review.googlesource.com/923392
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537393}
[modify] https://crrev.com/3f2e2f3ad18154cc118413b74e5777c686a5c5c2/android_webview/browser/render_thread_manager.cc

Comment 3 by boliu@chromium.org, Feb 16 2018

Status: Fixed (was: Available)
►

Sign in to add a comment