New issue
Advanced search Search tips

Issue 812936 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 781021



Sign in to add a comment

Swarming: stop exposing properties_hash to the user

Project Member Reported by mar...@chromium.org, Feb 16 2018

Issue description

It is an implementation detail and it gets in the way of  issue 781021 .
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/def12ba6672b09997205c1c78c194c806a8c91e9

commit def12ba6672b09997205c1c78c194c806a8c91e9
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Mon Feb 26 20:42:33 2018

Remove properties_hash.

This has always been an implementation detail, and exposing it through the API
is getting in the way of TaskProperties fallback.

This commit doesn't modify properties_hash values, so task deduping is not broken.

R=vadimsh@chromium.org

Bug:  812936 
Change-Id: Id5f63db35c8d7745838d953fc670a6b017d7de1d
Reviewed-on: https://chromium-review.googlesource.com/926541
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/def12ba6672b09997205c1c78c194c806a8c91e9/appengine/swarming/handlers_endpoints.py
[modify] https://crrev.com/def12ba6672b09997205c1c78c194c806a8c91e9/appengine/swarming/handlers_endpoints_test.py
[modify] https://crrev.com/def12ba6672b09997205c1c78c194c806a8c91e9/appengine/swarming/local_smoke_test.py
[modify] https://crrev.com/def12ba6672b09997205c1c78c194c806a8c91e9/appengine/swarming/message_conversion.py
[modify] https://crrev.com/def12ba6672b09997205c1c78c194c806a8c91e9/appengine/swarming/server/service_accounts_test.py
[modify] https://crrev.com/def12ba6672b09997205c1c78c194c806a8c91e9/appengine/swarming/server/task_queues_test.py
[modify] https://crrev.com/def12ba6672b09997205c1c78c194c806a8c91e9/appengine/swarming/server/task_request.py
[modify] https://crrev.com/def12ba6672b09997205c1c78c194c806a8c91e9/appengine/swarming/server/task_request_test.py
[modify] https://crrev.com/def12ba6672b09997205c1c78c194c806a8c91e9/appengine/swarming/server/task_result.py
[modify] https://crrev.com/def12ba6672b09997205c1c78c194c806a8c91e9/appengine/swarming/server/task_result_test.py
[modify] https://crrev.com/def12ba6672b09997205c1c78c194c806a8c91e9/appengine/swarming/server/task_scheduler.py
[modify] https://crrev.com/def12ba6672b09997205c1c78c194c806a8c91e9/appengine/swarming/server/task_scheduler_test.py
[modify] https://crrev.com/def12ba6672b09997205c1c78c194c806a8c91e9/appengine/swarming/server/task_to_run_test.py
[modify] https://crrev.com/def12ba6672b09997205c1c78c194c806a8c91e9/appengine/swarming/swarming_rpcs.py
[modify] https://crrev.com/def12ba6672b09997205c1c78c194c806a8c91e9/client/swarming.py

Comment 2 by mar...@chromium.org, Feb 28 2018

Status: Fixed (was: Assigned)

Sign in to add a comment