New issue
Advanced search Search tips

Issue 812934 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Make sysrq X key not try to kill X server

Project Member Reported by derat@chromium.org, Feb 16 2018

Issue description

I just noticed that sysrq_handle_cros_xkey in v4.4's drivers/tty/sysrq.c looks like it still tries to kill the X server on the second press. We should drop this, unless there's something I'm missing.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2018

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/a298e894a4d4d68738bb3424995711a918202468

commit a298e894a4d4d68738bb3424995711a918202468
Author: Daniel Erat <derat@chromium.org>
Date: Fri Mar 09 03:29:03 2018

CHROMIUM: sysrq: Stop trying to kill X server for 'X' key

We don't run an X server anymore, so make the second press
of the sysrq 'X' key jump straight to causing a panic rather
than trying to send SIGABRT to a nonexistent process.

BUG= chromium:812934 
TEST=first Alt+F10+x restarts Chrome; second reboots

Change-Id: I73db88234dcfaabc7aec54a15e6f848a83ab5ebe
Signed-off-by: Daniel Erat <derat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/954235
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Sonny Rao <sonnyrao@chromium.org>

[modify] https://crrev.com/a298e894a4d4d68738bb3424995711a918202468/drivers/tty/sysrq.c

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 9 2018

Labels: merge-merged-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/c81db6f6e807bb9d09b2f8cba7301782bdf1975b

commit c81db6f6e807bb9d09b2f8cba7301782bdf1975b
Author: Daniel Erat <derat@chromium.org>
Date: Fri Mar 09 12:44:13 2018

CHROMIUM: sysrq: Stop trying to kill X server for 'X' key

We don't run an X server anymore, so make the second press
of the sysrq 'X' key jump straight to causing a panic rather
than trying to send SIGABRT to a nonexistent process.

BUG= chromium:812934 
TEST=first Alt+F10+x restarts Chrome; second reboots

Change-Id: I01d55644d8e471bd1cf5b2a5eb9ab7270405439e
Signed-off-by: Daniel Erat <derat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/956688
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Sonny Rao <sonnyrao@chromium.org>

[modify] https://crrev.com/c81db6f6e807bb9d09b2f8cba7301782bdf1975b/drivers/tty/sysrq.c

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 9 2018

Labels: merge-merged-chromeos-3.10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/274ff6b9630a1be94dbf9077c45e1e84e607ecff

commit 274ff6b9630a1be94dbf9077c45e1e84e607ecff
Author: Daniel Erat <derat@chromium.org>
Date: Fri Mar 09 12:44:20 2018

CHROMIUM: sysrq: Stop trying to kill X server for 'X' key

We don't run an X server anymore, so make the second press
of the sysrq 'X' key jump straight to causing a panic rather
than trying to send SIGABRT to a nonexistent process.

BUG= chromium:812934 
TEST=first Alt+F10+x restarts Chrome; second reboots

Change-Id: I275da4da47639b4762ac1353c0e1dfffae008f66
Signed-off-by: Daniel Erat <derat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/955824
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Sonny Rao <sonnyrao@chromium.org>

[modify] https://crrev.com/274ff6b9630a1be94dbf9077c45e1e84e607ecff/drivers/tty/sysrq.c

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 9 2018

Labels: merge-merged-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/631c93c525ffd9a0672147fa01e62401c5f17905

commit 631c93c525ffd9a0672147fa01e62401c5f17905
Author: Daniel Erat <derat@chromium.org>
Date: Fri Mar 09 12:44:17 2018

CHROMIUM: sysrq: Stop trying to kill X server for 'X' key

We don't run an X server anymore, so make the second press
of the sysrq 'X' key jump straight to causing a panic rather
than trying to send SIGABRT to a nonexistent process.

BUG= chromium:812934 
TEST=first Alt+F10+x restarts Chrome; second reboots

Change-Id: I13d20a99fa27a6e3398bacf6c8a123fc57ef1dff
Signed-off-by: Daniel Erat <derat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/956687
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Sonny Rao <sonnyrao@chromium.org>

[modify] https://crrev.com/631c93c525ffd9a0672147fa01e62401c5f17905/drivers/tty/sysrq.c

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 9 2018

Labels: merge-merged-chromeos-4.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/497563a71a4f1b9d275310f09f09d6eff85b3068

commit 497563a71a4f1b9d275310f09f09d6eff85b3068
Author: Daniel Erat <derat@chromium.org>
Date: Fri Mar 09 12:44:22 2018

CHROMIUM: sysrq: Stop trying to kill X server for 'X' key

We don't run an X server anymore, so make the second press
of the sysrq 'X' key jump straight to causing a panic rather
than trying to send SIGABRT to a nonexistent process.

BUG= chromium:812934 
TEST=first Alt+F10+x restarts Chrome; second reboots

Change-Id: If537aa9337ab341bedebd03ac62a5a907e99ea51
Signed-off-by: Daniel Erat <derat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/956686
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Sonny Rao <sonnyrao@chromium.org>

[modify] https://crrev.com/497563a71a4f1b9d275310f09f09d6eff85b3068/drivers/tty/sysrq.c

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 9 2018

Labels: merge-merged-chromeos-3.8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/9e0703a09c6e258252c13a6c628a8339e571c496

commit 9e0703a09c6e258252c13a6c628a8339e571c496
Author: Daniel Erat <derat@chromium.org>
Date: Fri Mar 09 12:44:15 2018

CHROMIUM: sysrq: Stop trying to kill X server for 'X' key

We don't run an X server anymore, so make the second press
of the sysrq 'X' key jump straight to causing a panic rather
than trying to send SIGABRT to a nonexistent process.

BUG= chromium:812934 
TEST=first Alt+F10+x restarts Chrome; second reboots

Change-Id: Ia4025c48443ad40629b93db9b0123675bed9ea1f
Signed-off-by: Daniel Erat <derat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/955825
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Sonny Rao <sonnyrao@chromium.org>

[modify] https://crrev.com/9e0703a09c6e258252c13a6c628a8339e571c496/drivers/tty/sysrq.c

Comment 7 by derat@chromium.org, Mar 9 2018

Status: Fixed (was: Started)

Sign in to add a comment