New issue
Advanced search Search tips

Issue 812926 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 738611



Sign in to add a comment

Polymer: Migrate iron-input to its latest (2.0.1) version.

Project Member Reported by dpa...@chromium.org, Feb 16 2018

Issue description

There are some breaking changes between current version and 2.0.1, see https://github.com/PolymerElements/iron-input#changes-in-20.

Need to update all usages to conform to the new syntax.
 

Comment 1 by dpa...@chromium.org, Feb 16 2018

Blocking: 738611

Comment 2 by dpa...@chromium.org, Feb 16 2018

Owner: dpa...@chromium.org
Status: Assigned (was: Available)

Comment 4 by dpa...@chromium.org, Mar 20 2018

Newly discovered blocking bug https://github.com/PolymerElements/paper-input/issues/633.

Comment 5 by dpa...@chromium.org, Mar 23 2018

Discovered another bug which affects font-size of all paper-inputs when iron-input is updated to 2.x, https://github.com/PolymerElements/paper-input/issues/636.

Comment 6 by dpa...@chromium.org, Mar 26 2018

Owner: hcarmona@chromium.org
Transferring this issue to hcarmona@.

 - Uploaded progress so far at https://chromium-review.googlesource.com/c/chromium/src/+/981173 (see note posted on the CL).
 - https://github.com/PolymerElements/paper-input/issues/633 has not been fixed yet. Candidate fix is https://github.com/PolymerElements/iron-input/pull/130/files.
 - https://github.com/PolymerElements/paper-input/issues/636 has not been fixed yet. Candidate fix is posted on that bug.

Things to look for when migrating
 - Ensure paper-input instances look correct (same as before, especially font-size which is currently broken).
 - Migrate iron-input usages to the new wrapping syntax (there are a few of them).
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d797a099c8c738d0cb296efcc32c86eeea03626

commit 1d797a099c8c738d0cb296efcc32c86eeea03626
Author: Hector Carmona <hcarmona@chromium.org>
Date: Wed Apr 25 17:24:19 2018

WebUI: Update Polymer paper-input version 2.1.0 -> 2.2.2

This is in preparation of updating iron-input to its latest version

Bug:  812926 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6cbcb4869fadac14956ac5c9e9a9d3d7289dda46
Reviewed-on: https://chromium-review.googlesource.com/1026639
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553624}
[modify] https://crrev.com/1d797a099c8c738d0cb296efcc32c86eeea03626/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/1d797a099c8c738d0cb296efcc32c86eeea03626/third_party/polymer/v1_0/components-chromium/paper-input/bower.json
[modify] https://crrev.com/1d797a099c8c738d0cb296efcc32c86eeea03626/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-addon-behavior-extracted.js
[modify] https://crrev.com/1d797a099c8c738d0cb296efcc32c86eeea03626/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-behavior-extracted.js
[modify] https://crrev.com/1d797a099c8c738d0cb296efcc32c86eeea03626/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-container-extracted.js
[modify] https://crrev.com/1d797a099c8c738d0cb296efcc32c86eeea03626/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-container.html
[modify] https://crrev.com/1d797a099c8c738d0cb296efcc32c86eeea03626/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-extracted.js
[modify] https://crrev.com/1d797a099c8c738d0cb296efcc32c86eeea03626/third_party/polymer/v1_0/components-chromium/paper-input/paper-input.html
[modify] https://crrev.com/1d797a099c8c738d0cb296efcc32c86eeea03626/third_party/polymer/v1_0/components-chromium/paper-input/paper-textarea-extracted.js
[modify] https://crrev.com/1d797a099c8c738d0cb296efcc32c86eeea03626/third_party/polymer/v1_0/components_summary.txt

Project Member

Comment 9 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3547e7a50cd5f0a1f3336fed9413eb1ef2611aee

commit 3547e7a50cd5f0a1f3336fed9413eb1ef2611aee
Author: Hector Carmona <hcarmona@chromium.org>
Date: Tue May 08 23:29:11 2018

WebUI: Refactor pin-keyboard in preparation of iron-input v2 update.

Bug:  812926 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I813c42ac1114c902e812094618dded87581f7327
Reviewed-on: https://chromium-review.googlesource.com/1043495
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557006}
[modify] https://crrev.com/3547e7a50cd5f0a1f3336fed9413eb1ef2611aee/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.html
[modify] https://crrev.com/3547e7a50cd5f0a1f3336fed9413eb1ef2611aee/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.js

Status: Fixed (was: Started)
iron-input was migrated to v2 in https://crrev.com/c/1015644 

Sign in to add a comment