New issue
Advanced search Search tips

Issue 812922 link

Starred by 1 user
Status: Fixed
Owner:
robertogden@chromium.org
Closed: Jul 31
Components:
EstimatedDays: ----
NextAction: 2018-07-24
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Record when and why the data saver statistics were cleared

Project Member Reported by tbansal@chromium.org, Feb 16 2018 
The data saver statistics may be cleared for a variety of reasons:
1. The system clock moved back by one day.
2. The user cleared the statistics in the Chrome extension.
3. The user cleared the statistics in the data saver settings by clicking on "Reset Statistics".
4. (May be) User clearing the browsing history.
5. (May be) There is a error in parsing the on-disk prefs.

We should record using UMA (and may be prefs) when the data saver statistics are cleared, and why they were cleared. This would be useful in debugging the 0 KB savings.

Comment 1 by ryansturm@chromium.org, Feb 20 2018

Status: Available (was: Untriaged)

Comment 2 by sclit...@chromium.org, Apr 11 2018

Owner: robertogden@chromium.org
Status: Assigned (was: Available)
Assigned to robertogden@ since the 0% savings bug is assigned to him.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71f5a41625608d650bdf4302904bd6bde4186352

commit 71f5a41625608d650bdf4302904bd6bde4186352
Author: Robert Ogden <robertogden@chromium.org>
Date: Wed Apr 25 20:35:32 2018

Create generic UMA for why data savings were cleared

This new UMA will replace
DataReductionProxy.SavingsCleared.NegativeSystemClock and add on more
enum values for all the possible reasons the data savings could have
been cleared. This will be done in a follow up CL.

Bug:  812922 
Change-Id: Ibc82d187045444b6ca7812e2fc2097549501c0aa
Reviewed-on: https://chromium-review.googlesource.com/1024880
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553725}
[modify] https://crrev.com/71f5a41625608d650bdf4302904bd6bde4186352/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc
[modify] https://crrev.com/71f5a41625608d650bdf4302904bd6bde4186352/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.h
[modify] https://crrev.com/71f5a41625608d650bdf4302904bd6bde4186352/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc
[modify] https://crrev.com/71f5a41625608d650bdf4302904bd6bde4186352/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/71f5a41625608d650bdf4302904bd6bde4186352/tools/metrics/histograms/histograms.xml
Project Member

Comment 4 by bugdroid1@chromium.org, May 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/794a161da7205b60c7daf9e31805466474b12a9a

commit 794a161da7205b60c7daf9e31805466474b12a9a
Author: Robert Ogden <robertogden@chromium.org>
Date: Thu May 03 01:34:11 2018

Add DataReductionProxy.SavingsCleared.Reason recording

Adds user action reasons and fleshes out all UMA recording around why
data savings may have been cleared.

Also adds another histogram,
DataReductionProxy.DeleteBrowsingHistory.NumBuckets to track how many
buckets are deleted when browsing history is cleared.

Bug:  812922 
Change-Id: I8cf989fa724f23c62bda8232f1215f8ff6b7839a
Reviewed-on: https://chromium-review.googlesource.com/1030880
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555648}
[modify] https://crrev.com/794a161da7205b60c7daf9e31805466474b12a9a/chrome/android/BUILD.gn
[modify] https://crrev.com/794a161da7205b60c7daf9e31805466474b12a9a/chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java
[modify] https://crrev.com/794a161da7205b60c7daf9e31805466474b12a9a/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionStatsPreference.java
[modify] https://crrev.com/794a161da7205b60c7daf9e31805466474b12a9a/chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.cc
[modify] https://crrev.com/794a161da7205b60c7daf9e31805466474b12a9a/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc
[modify] https://crrev.com/794a161da7205b60c7daf9e31805466474b12a9a/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.h
[modify] https://crrev.com/794a161da7205b60c7daf9e31805466474b12a9a/components/data_reduction_proxy/core/browser/BUILD.gn
[modify] https://crrev.com/794a161da7205b60c7daf9e31805466474b12a9a/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc
[modify] https://crrev.com/794a161da7205b60c7daf9e31805466474b12a9a/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.h
[modify] https://crrev.com/794a161da7205b60c7daf9e31805466474b12a9a/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc
[modify] https://crrev.com/794a161da7205b60c7daf9e31805466474b12a9a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
[modify] https://crrev.com/794a161da7205b60c7daf9e31805466474b12a9a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
[modify] https://crrev.com/794a161da7205b60c7daf9e31805466474b12a9a/components/data_reduction_proxy/core/browser/data_usage_store.cc
[modify] https://crrev.com/794a161da7205b60c7daf9e31805466474b12a9a/components/data_reduction_proxy/core/browser/data_usage_store_unittest.cc
[modify] https://crrev.com/794a161da7205b60c7daf9e31805466474b12a9a/components/data_reduction_proxy/proto/data_store.proto
[modify] https://crrev.com/794a161da7205b60c7daf9e31805466474b12a9a/tools/android/eclipse/.classpath
[modify] https://crrev.com/794a161da7205b60c7daf9e31805466474b12a9a/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/794a161da7205b60c7daf9e31805466474b12a9a/tools/metrics/histograms/histograms.xml

Comment 5 by robertogden@chromium.org, May 3 2018

NextAction: 2018-07-24
Setting next action when the above CL should go to stable. We'll check data then

Comment 6 by monor...@bugs.chromium.org, Jul 24 

The NextAction date has arrived: 2018-07-24

Comment 7 by robertogden@chromium.org, Jul 31

Status: Fixed (was: Assigned)
►

Sign in to add a comment