New issue
Advanced search Search tips

Issue 812920 link

Starred by 1 user
Status: Fixed
Owner:
bsep@chromium.org
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Harmony: Disabled checkboxes/radio buttons don't look very disabled

Project Member Reported by bsep@chromium.org, Feb 16 2018 
I happened across a dialog that uses disabled radio buttons and I was very confused at first why I couldn't click on them. See attached screenshot.
cookies-blocked-ntp.PNG
16.2 KB View Download

Comment 1 by bsep@chromium.org, Feb 16 2018 

Screenshot for https://chromium-review.googlesource.com/c/chromium/src/+/923209
cookies-blocked-ntp-final-disabled.PNG
15.7 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f70ae5c0e31e2d9402978a97cdf63755a40b76f

commit 8f70ae5c0e31e2d9402978a97cdf63755a40b76f
Author: Bret Sepulveda <bsep@chromium.org>
Date: Sat Feb 17 05:12:39 2018

Harmony: add disabled colors for checkbox/radio button icons.

Previously the icons would use the active colors, which is confusing.
See screenshot in the associated bug.

Bug:  812920 
Change-Id: I35e11e1b5ec8e1fc95b40ef27e5819b9dd9db008
Reviewed-on: https://chromium-review.googlesource.com/923209
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537532}
[modify] https://crrev.com/8f70ae5c0e31e2d9402978a97cdf63755a40b76f/ui/views/controls/button/checkbox.cc
[modify] https://crrev.com/8f70ae5c0e31e2d9402978a97cdf63755a40b76f/ui/views/controls/button/checkbox.h

Comment 3 by bsep@chromium.org, Feb 17 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment