New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812912 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome anymore
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 545318



Sign in to add a comment

[css-typed-om] Delete StylePropertyMap.update

Project Member Reported by shend@chromium.org, Feb 16 2018

Issue description

StylePropertyMap.update works weirdly, we should just delete it: https://github.com/w3c/css-houdini-drafts/issues/656
 

Comment 1 by nainar@chromium.org, Feb 16 2018

Owner: nainar@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d40ce2a56652a11fe0b223e4e78045438ba5874f

commit d40ce2a56652a11fe0b223e4e78045438ba5874f
Author: Naina Raisinghani <nainar@chromium.org>
Date: Tue Feb 20 02:11:00 2018

Delete StylePropertyMap.update()

This is as there is a bug on the spec highlighting the lack of
 usefulness of the function: https://github.com/w3c/css-houdini-drafts/issues/656

Bug:  812912 
Change-Id: If0b47a4bfa268f55f63e5c80168971164dc63199
Reviewed-on: https://chromium-review.googlesource.com/923501
Commit-Queue: nainar <nainar@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537697}
[modify] https://crrev.com/d40ce2a56652a11fe0b223e4e78045438ba5874f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/interfaces-expected.txt
[delete] https://crrev.com/4cd9cd8fb7a03df1165d1095acfb1dafb063ca07/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/styleMap-update-function.html
[delete] https://crrev.com/4cd9cd8fb7a03df1165d1095acfb1dafb063ca07/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/declared/update.tentative.html
[delete] https://crrev.com/4cd9cd8fb7a03df1165d1095acfb1dafb063ca07/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/inline/update.tentative.html
[modify] https://crrev.com/d40ce2a56652a11fe0b223e4e78045438ba5874f/third_party/WebKit/LayoutTests/external/wpt/interfaces/css-typed-om.idl
[modify] https://crrev.com/d40ce2a56652a11fe0b223e4e78045438ba5874f/third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/declared/delete-rule-crash.html
[modify] https://crrev.com/d40ce2a56652a11fe0b223e4e78045438ba5874f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/d40ce2a56652a11fe0b223e4e78045438ba5874f/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp
[modify] https://crrev.com/d40ce2a56652a11fe0b223e4e78045438ba5874f/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h
[modify] https://crrev.com/d40ce2a56652a11fe0b223e4e78045438ba5874f/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.idl

Comment 3 by nainar@chromium.org, Feb 23 2018

Status: Fixed (was: Assigned)

Sign in to add a comment