New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812906 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 813955



Sign in to add a comment

use FEATURES=force-mirror everywhere

Project Member Reported by vapier@chromium.org, Feb 16 2018

Issue description

we've long used FEATURES=force-mirror in target board builds so that we can guarantee all archives used to build boards are in GS buckets controlled by us (so that if whatever random upstream project goes away/moves files/changes files/whatever) doesn't break us, both historically and with current builds.  yes, we have Manifest files to make sure changes are caught, but that doesn't prevent the breakage in the first place.

however, we've never deployed this feature to the SDK itself.  we should fix that so we have the same reliability guarantees there.
 
Any fundamental reason why mirroring process is not more automated?

i.e. at emerge time, portage checks mirror first, otherwise downloads from SRC_URI, verifies checksums, and optionally *uploads* to the mirror so next time it'll hit the mirror.

Comment 2 by vapier@chromium.org, Feb 16 2018

the mirroring process is automated for Gentoo->CrOS mirrors.  that's where the vast majority of sources come from.

we have no automation for ebuilds that CrOS wrote and is specific to us.  it's debatable whether we would want it ...
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/69912553f69132aaa5349c9a88c1c4e71b6aca55

commit 69912553f69132aaa5349c9a88c1c4e71b6aca55
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Feb 16 09:23:50 2018

Revert "puppy: Allow download from ftp://download.nvidia.com"

This reverts commit 8b7aee78e638c24fbc4b4c0d2e58a90a2ab42d88.

All files CrOS builds from need to be mirrored on our own infra.
The few files that this overlay referred to are now on our GS
mirror, so don't need this anymore.

Plus, ftp://download.nvidia.com doesn't even work anymore, so
change to http:// as those appear to be alive.

BUG= chromium:812906 
TEST=precq passes

Change-Id: Ifc201228a0761385529fc1d1be97c5af0a54441f
Reviewed-on: https://chromium-review.googlesource.com/922764
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org>

[modify] https://crrev.com/69912553f69132aaa5349c9a88c1c4e71b6aca55/overlay-puppy/sys-apps/nvrm/nvrm-2013.04.12.00.00.ebuild
[modify] https://crrev.com/69912553f69132aaa5349c9a88c1c4e71b6aca55/overlay-puppy/x11-drivers/tegra-drivers/tegra-drivers-8.2013.04.12.00.00.ebuild
[modify] https://crrev.com/69912553f69132aaa5349c9a88c1c4e71b6aca55/overlay-puppy/x11-drivers/opengles-bin/opengles-bin-2013.04.12.00.00.ebuild
[modify] https://crrev.com/69912553f69132aaa5349c9a88c1c4e71b6aca55/overlay-puppy/media-libs/openmax-codecs/openmax-codecs-2013.04.12.00.00.ebuild
[modify] https://crrev.com/69912553f69132aaa5349c9a88c1c4e71b6aca55/overlay-puppy/make.conf
[modify] https://crrev.com/69912553f69132aaa5349c9a88c1c4e71b6aca55/overlay-puppy/media-libs/openmax/openmax-2013.04.12.00.00.ebuild

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-nyan-private/+/bc9fc6679aac7655148f7b43cec2607165f65afd

commit bc9fc6679aac7655148f7b43cec2607165f65afd
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Feb 16 23:12:25 2018

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/82dae0dcffe69be2eea3cfd5c13a5104c91abff3

commit 82dae0dcffe69be2eea3cfd5c13a5104c91abff3
Author: Mike Frysinger <vapier@chromium.org>
Date: Sat Feb 17 02:48:02 2018

rust: do not rename arch-specific binary tarball

Upstream Gentoo doesn't do this, and it doesn't make sense to as there
can be more than one "rust-std" tarball based on the arch.

BUG= chromium:812906 
TEST=build still passes

Change-Id: Iaff33608c9cf14cd8ecc1bb3a05756028ecace52
Reviewed-on: https://chromium-review.googlesource.com/924086
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/82dae0dcffe69be2eea3cfd5c13a5104c91abff3/dev-lang/rust/rust-1.24.0.ebuild

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/5cb80cc883e57158fe248d111e4c5ec17c10ed20

commit 5cb80cc883e57158fe248d111e4c5ec17c10ed20
Author: Mike Frysinger <vapier@chromium.org>
Date: Sat Feb 17 05:42:07 2018

nyan: drop -force-mirror

This looks to be copied & pasted from the puppy overlay, but this
overlay doesn't fetch from download.nvidia.com, so it's not even
really needed.

BUG= chromium:812906 
TEST=precq passes

Change-Id: I68af7b41ee190f52ec235d75b749c32135625c28
Reviewed-on: https://chromium-review.googlesource.com/922765
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org>

[modify] https://crrev.com/5cb80cc883e57158fe248d111e4c5ec17c10ed20/overlay-nyan/make.conf

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ba56b7ded904f98a4dcd724d548769f6cc1b4aa8

commit ba56b7ded904f98a4dcd724d548769f6cc1b4aa8
Author: Mike Frysinger <vapier@chromium.org>
Date: Sat Feb 17 20:04:43 2018

rust: rename tarball in Manifest too

The previous commit here changed the SRC_URI but missed the Manifest.

BUG= chromium:812906 
TEST=build still passes

Change-Id: I8c1cc26e62e59e26353984dd930a5d01376da947
Reviewed-on: https://chromium-review.googlesource.com/924543
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/ba56b7ded904f98a4dcd724d548769f6cc1b4aa8/dev-lang/rust/Manifest

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1ff5753808011c4e0a298b1b030ea92fedfda956

commit 1ff5753808011c4e0a298b1b030ea92fedfda956
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Feb 19 10:36:05 2018

sdk: enable FEATURES=force-mirror

We enable this for our target boards already for reliability.
Turn it on for the SDK too.

BUG= chromium:812906 
TEST=chromiumos-sdk bot still passes

Change-Id: Ic9b5157aa85bd19e3d0aac4bd2be968dead44cc0
Reviewed-on: https://chromium-review.googlesource.com/922989
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org>

[modify] https://crrev.com/1ff5753808011c4e0a298b1b030ea92fedfda956/profiles/targets/sdk/make.defaults

Comment 9 by vapier@chromium.org, Feb 19 2018

Owner: vapier@chromium.org
Status: Fixed (was: Available)
Labels: -Pri-3 Restrict-View-Google Pri-2
Status: Assigned (was: Fixed)
Re-opening this issue.
When creating a new chroot (with .cache cleared), cros_sdk is failing to emerge meta-embedded-toolkit.
It is unable to fetch meta-embedded-toolkit-2.8.1.tar.gz
The ebuild for this is in private-overlays/chromeos-overlay/dev-embedded and lists the SRC_URI as:
  SRC_URI="gs://chromeos-localmirror-private/distfiles/${P}.tar.gz"

The tarball is on chromeos-localmirror-private, but not in chromeos-localmirror/distfiles/...
With force-mirror disabled for the sdk, new chroot creation works fine.

I'm not sure if we can add meta-embedded-toolkit-2.8.1.tar.gz to chromeos-localmirror/distfiles (which will make it public).
The alternative seems to be RESTRICT=mirror in the ebuild. There's another copy of the ebuild in private-overlays/chromeos-overlay-oak.

Project Member

Comment 11 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/3fdbad0a527d3668d942b1838222979bb911e098

commit 3fdbad0a527d3668d942b1838222979bb911e098
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Feb 21 00:21:26 2018

Project Member

Comment 12 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay-oak/+/097990ef9ca345d7a0a26b7e54e458bb784fc45c

commit 097990ef9ca345d7a0a26b7e54e458bb784fc45c
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Feb 21 00:21:37 2018

Blocking: 813955
Labels: -Restrict-View-Google
Status: Fixed (was: Assigned)
i've landed the RESTRICT=mirror in this case since we control the GS bucket the SRC_URI is pointing to

Sign in to add a comment