New issue
Advanced search Search tips

Issue 812891 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"DomSerializerTests.SerializeHTMLDOMWithEntitiesInAttributeValue" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Feb 15 2018

Issue description

"DomSerializerTests.SerializeHTMLDOMWithEntitiesInAttributeValue" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySgsSBUZsYWtlIj9Eb21TZXJpYWxpemVyVGVzdHMuU2VyaWFsaXplSFRNTERPTVdpdGhFbnRpdGllc0luQXR0cmlidXRlVmFsdWUM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Labels: -Sheriff-Chromium
Owner: jam@chromium.org
Status: Assigned (was: Untriaged)
Recent flakes are all TSAN. Similar failure in 812689. Assigning to test author for triage. Not disabling given low flake count so far. 

WARNING: ThreadSanitizer: data race (pid=25641)
  Write of size 8 at 0x7b040000bc80 by main thread:
    #0 operator delete(void*) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/tsan/rtl/tsan_new_delete.cc:119:3 (content_browsertests+0x1abc52d)
    #1 skia::SkChromiumEventTracer::~SkChromiumEventTracer() skia/ext/event_tracer_impl.cc:13:7 (content_browsertests+0x6353249)
    #2 operator() third_party/skia/src/utils/SkEventTracer.cpp:52:19 (content_browsertests+0x635b3ef)
    #3 SkEventTracer::SetInstance(SkEventTracer*)::$_0::__invoke() third_party/skia/src/utils/SkEventTracer.cpp:52 (content_browsertests+0x635b3ef)
    #4 at_exit_wrapper() /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:379:3 (content_browsertests+0x1a8a77c)
  Previous read of size 8 at 0x7b040000bc80 by thread T8:
    [failed to restore the stack]
  Thread T8 'TaskSchedulerFo' (tid=25681, running) created by main thread at:
    #0 pthread_create /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:992:3 (content_browsertests+0x1a537d5)
    #1 base::(anonymous namespace)::CreateThread(unsigned long, bool, base::PlatformThread::Delegate*, base::PlatformThreadHandle*, base::ThreadPriority) base/threading/platform_thread_posix.cc:114:13 (content_browsertests+0x5967db6)
    #2 base::PlatformThread::CreateWithPriority(unsigned long, base::PlatformThread::Delegate*, base::PlatformThreadHandle*, base::ThreadPriority) base/threading/platform_thread_posix.cc:199:10 (content_browsertests+0x5967c75)
    #3 Initialize base/task_scheduler/scheduler_worker.cc:123:5 (content_browsertests+0x5953c84)
    #4 base::internal::SchedulerWorker::Thread::Create(scoped_refptr<base::internal::SchedulerWorker>) base/task_scheduler/scheduler_worker.cc:32 (content_browsertests+0x5953c84)
    #5 base::internal::SchedulerWorker::Start() base/task_scheduler/scheduler_worker.cc:211:13 (content_browsertests+0x5953a61)
    #6 base::internal::SchedulerWorkerPoolImpl::CreateRegisterAndStartSchedulerWorkerLockRequired() base/task_scheduler/scheduler_worker_pool_impl.cc:784:16 (content_browsertests+0x594e6c7)
    #7 base::internal::SchedulerWorkerPoolImpl::Start(base::SchedulerWorkerPoolParams const&, scoped_refptr<base::TaskRunner>, base::internal::SchedulerWorkerPoolImpl::WorkerEnvironment) base/task_scheduler/scheduler_worker_pool_impl.cc:229:9 (content_browsertests+0x594dedb)
    #8 base::internal::TaskSchedulerImpl::Start(base::TaskScheduler::InitParams const&) base/task_scheduler/task_scheduler_impl.cc:115:30 (content_browsertests+0x59492e8)
    #9 content::BrowserMainLoop::CreateThreads() content/browser/browser_main_loop.cc:1029:41 (content_browsertests+0x46d2ee6)
    #10 Invoke<content::BrowserMainLoop *> base/bind_internal.h:211:12 (content_browsertests+0x46d8e48)
    #11 MakeItSo<int (content::BrowserMainLoop::*const &)(), content::BrowserMainLoop *> base/bind_internal.h:294 (content_browsertests+0x46d8e48)
    #12 RunImpl<int (content::BrowserMainLoop::*const &)(), const std::__1::tuple<base::internal::UnretainedWrapper<content::BrowserMainLoop> > &, 0> base/bind_internal.h:368 (content_browsertests+0x46d8e48)
    #13 base::internal::Invoker<base::internal::BindState<int (content::BrowserMainLoop::*)(), base::internal::UnretainedWrapper<content::BrowserMainLoop> >, int ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:350 (content_browsertests+0x46d8e48)
    #14 Run base/callback.h:94:12 (content_browsertests+0x4e3998a)
    #15 content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45 (content_browsertests+0x4e3998a)
    #16 content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:977:25 (content_browsertests+0x46d2c3d)
    #17 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:139:17 (content_browsertests+0x46d93da)
    #18 ShellBrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserMainRunner, std::__1::default_delete<content::BrowserMainRunner> > const&) content/shell/browser/shell_browser_main.cc:23:32 (content_browsertests+0x53baeea)
    #19 content::ShellMainDelegate::RunProcess(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&) content/shell/app/shell_main_delegate.cc:322:16 (content_browsertests+0x5357142)
    #20 content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) content/app/content_main_runner.cc:410:35 (content_browsertests+0x45477d2)
    #21 content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:713:12 (content_browsertests+0x4548e71)
    #22 content::ContentServiceManagerMainDelegate::RunEmbedderProcess() content/app/content_service_manager_main_delegate.cc:51:32 (content_browsertests+0x32c986f)
    #23 service_manager::Main(service_manager::MainParams const&) services/service_manager/embedder/main.cc:456:29 (content_browsertests+0x789342c)
    #24 content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:10 (content_browsertests+0x32ca07b)
    #25 content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:309:3 (content_browsertests+0x52dbc16)
    #26 content::ContentBrowserTest::SetUp() content/public/test/content_browser_test.cc:89:20 (content_browsertests+0x52cb9b6)
    #27 testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc (content_browsertests+0x23db3a6)
    #28 testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2651:11 (content_browsertests+0x23dc53d)
    #29 testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2769:28 (content_browsertests+0x23dcd86)
    #30 testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:4665:43 (content_browsertests+0x23e8106)
    #31 testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc (content_browsertests+0x23e7ad5)
    #32 RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2233:46 (content_browsertests+0x532ea76)
    #33 base::TestSuite::Run() base/test/test_suite.cc:272 (content_browsertests+0x532ea76)
    #34 content::ContentTestLauncherDelegate::RunTestSuite(int, char**) content/test/content_test_launcher.cc:108:48 (content_browsertests+0x52d194b)
    #35 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:631:31 (content_browsertests+0x53072db)
    #36 main content/test/content_test_launcher.cc:138:10 (content_browsertests+0x52d18dd)

Comment 2 by falken@chromium.org, Feb 16 2018

Cc: falken@chromium.org
 Issue 812690  has been merged into this issue.

Comment 3 by falken@chromium.org, Feb 16 2018

Components: Internals>Skia
Status: Untriaged (was: Assigned)
TSAN seems to be failing with the same stack on other tests:
FrameTreeBrowserTest.NavigateWithLeftoverFrames
ServiceWorkerBrowserTest.CrossOriginFetchWithSaveData
RenderFrameHostImplBrowserTest.StreamHandleReleasedOnRendererCrash
PlzNavigateNavigationHandleImplBrowserTest.BlockedRequestAfterWebUI

See https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_tsan_rel_ng/251851

Something about SkEventTrace?

Comment 4 by falken@chromium.org, Feb 16 2018

Also:
NavigationMojoResponseBrowserTest.RendererInitiatedSameSiteNavigation
FrameTreeBrowserTest.NavigateWithLeftoverFrames
DomSerializerTests.SerializeHTMLDOMWithoutDocType
DomSerializerTests.SerializeHTMLDOMWithEntitiesInAttributeValue

https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_tsan_rel_ng/251867

Comment 5 by falken@chromium.org, Feb 16 2018

Cc: jam@chromium.org
 Issue 812689  has been merged into this issue.

Comment 6 by mmenke@chromium.org, May 30 2018

Just had DomSerializerTests.SerializeHTMLDOMWithEmptyHead and DomSerializerTests.SerializeHTMLDOMWithEntitiesInAttributeValue flake on Linux ASAN bots in two different CLs.  Seems like these tests are either still flaky, or newly re-flaky.
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Components: -Internals>Skia

Sign in to add a comment