New issue
Advanced search Search tips

Issue 812890 link

Starred by 1 user
Status: Fixed
Owner:
steimel@chromium.org
Closed: Mar 2018
Cc:
mlamouri@chromium.org
amyroberts@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Modern-Media-Controls


Sign in to add a comment

Media Controls do not auto-hide after pointer activity stops

Project Member Reported by hbengali@chromium.org, Feb 15 2018 
Chrome Version: 66.0.3345.0 (Official Build) canary (64-bit)
OS: Mac (but likely affects all desktop platforms)

What steps will reproduce the problem?
(1) Enable New Media Controls flag (chrome://flags/#enable-modern-media-controls)
(2) Navigate to a site that uses native controls (e.g. https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html) and play a video.
(3) Play a video

What is the expected result?

Controls + scrim should auto-hide a few seconds after pointer activity has stopped.

What happens instead?

As the pointer remains over the video, the controls do not auto-hide regardless of time elapsed since last pointer activity. This is particularly notable in full screen where the only way to hide the controls is to click somewhere outside of the scrubber/buttons.

Comment 1 by j...@onerabbit.com.au, Feb 15 2018 

I can reproduce this on Windows 10 and Ubuntu, so affecting all platforms.

Chrome Version: Version 64.0.3282.167 (Official Build) (64-bit)
OS: Windows 10 / Ubuntu 17.10

Comment 2 by mlamouri@chromium.org, Feb 16 2018

Components: -Internals>Media>UI Blink>Media>Controls

Comment 4 by steimel@chromium.org, Mar 7 2018

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b807a550e8920e9dad58ca6a581c8845fd81bc5

commit 2b807a550e8920e9dad58ca6a581c8845fd81bc5
Author: Tommy Steimel <steimel@chromium.org>
Date: Mon Mar 12 19:25:20 2018

Fix modern media controls visibility issues

This CL fixes a couple of visibility issues for the modern media
controls. First, it only toggles the controls visibility on touch
events instead of all click events. Second, it changes the
ShouldHideMediaControls hover check to only use the hover state of the
button panel and timeline instead of the panel itself, which in modern
media controls covers the entire video element. This fixes an issue on
desktop where the controls wouldn't hide during fullscreen since the
controls were always hovered.

Bug:  812890 
Change-Id: I8cb30841020e7f3ffdadc53131a4fa374b4254c2
Reviewed-on: https://chromium-review.googlesource.com/938841
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542564}
[modify] https://crrev.com/2b807a550e8920e9dad58ca6a581c8845fd81bc5/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/2b807a550e8920e9dad58ca6a581c8845fd81bc5/third_party/WebKit/LayoutTests/media/controls/modern/tap-to-hide-controls.html
[modify] https://crrev.com/2b807a550e8920e9dad58ca6a581c8845fd81bc5/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/2b807a550e8920e9dad58ca6a581c8845fd81bc5/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/2b807a550e8920e9dad58ca6a581c8845fd81bc5/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[modify] https://crrev.com/2b807a550e8920e9dad58ca6a581c8845fd81bc5/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp
[modify] https://crrev.com/2b807a550e8920e9dad58ca6a581c8845fd81bc5/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.h

Comment 6 by steimel@chromium.org, Mar 12 2018

Status: Fixed (was: Started)
►

Sign in to add a comment