New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812884 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

CL_STATUS_VIEWER failed at refresh buildbucket credential

Project Member Reported by nxia@chromium.org, Feb 15 2018

Issue description

2018-02-14 15:40:30 default[20180207t115331]  ERROR:root:Failed at getting CL status, change: gerrit_host: "chromium-review.googlesource.com"
2018-02-14 15:40:30 default[20180207t115331]  change_number: 848419
2018-02-14 15:40:30 default[20180207t115331]  patch_number: 15
2018-02-14 15:40:30 default[20180207t115331]  , exception: GetTokenFromServiceAccount() takes no arguments (2 given)
2018-02-14 15:40:30 default[20180207t115331]  Traceback (most recent call last):    File "/home/vmagent/app/v1.py", line 103, in GetCLStatus      status, builds = cl_status_server.GetCLStatusAndBuilds(change)    File "/home/vmagent/app/cl_status_server.py", line 293, in GetCLStatusAndBuilds      builds.extend(_GetCQBuilds(cl_actions))    File "/home/vmagent/app/cl_status_server.py", line 435, in _GetCQBuilds      scheduled_buildbucket_id, False)    File "/home/vmagent/app/chromite/lib/buildbucket_lib.py", line 301, in GetBuildRequest      return self.SendBuildbucketRequest(url, GET_METHOD, None, dryrun)    File "/home/vmagent/app/chromite/lib/buildbucket_lib.py", line 268, in SendBuildbucketRequest      return retry_util.GenericRetry(lambda _: True, 3, try_method)    File "/home/vmagent/app/chromite/lib/retry_util.py", line 244, in GenericRetry      return _run()    File "/home/vmagent/app/chromite/lib/retry_util.py", line 177, in _Wrapper      ret = func(*args, **kwargs)    File "/home/vmagent/app/chromite/lib/retry_util.py", line 243, in _run      return functor(*args, **kwargs)    File "/home/vmagent/app/chromite/lib/buildbucket_lib.py", line 257, in try_method      headers={'Content-Type': 'application/json'},    File "/home/vmagent/app/chromite/lib/auth.py", line 197, in request      force_token_renew=True)  TypeError: GetTokenFromServiceAccount() takes no arguments (2 given)

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_status_viewer/+/cdb48e9b450db2a37acea693610604e78948c3df

commit cdb48e9b450db2a37acea693610604e78948c3df
Author: Ningning Xia <nxia@google.com>
Date: Fri Feb 16 00:48:45 2018

cl_status_server: GetTokenFromServiceAccount takes **kwargs

When buildbucket requests return 401 status code, buildbucket
authentication will be retried with extra kwargs.

BUG= chromium:812884 
TEST=deployed locally and tested.

Change-Id: I6ff8d7aa0b38005860eec0c817f5dab175a7ef35

[modify] https://crrev.com/cdb48e9b450db2a37acea693610604e78948c3df/cl_status_viewer_server/README.md
[modify] https://crrev.com/cdb48e9b450db2a37acea693610604e78948c3df/cl_status_viewer_ui/README.md
[modify] https://crrev.com/cdb48e9b450db2a37acea693610604e78948c3df/cl_status_viewer_server/v1.py
[modify] https://crrev.com/cdb48e9b450db2a37acea693610604e78948c3df/cl_status_viewer_server/cl_status_server.py

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b72f60a853c40e9f61930ca8c5593ca403b9f20e

commit b72f60a853c40e9f61930ca8c5593ca403b9f20e
Author: Ningning Xia <nxia@google.com>
Date: Wed Feb 21 04:31:50 2018

auth: set GetAccessToken to take **kwargs

cl_status_server.GetTokenFromServiceAccount takes no arguments by
default, consolidate cl_status_server.GetTokenFromServiceAccount and
auth.GetAccessToken to take **kwargs.

BUG= chromium:812884 
TEST=unit_tests

Change-Id: I99b8c585848eef8f64106f30097aceeb27f5211e
Reviewed-on: https://chromium-review.googlesource.com/923106
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/b72f60a853c40e9f61930ca8c5593ca403b9f20e/lib/auth.py
[modify] https://crrev.com/b72f60a853c40e9f61930ca8c5593ca403b9f20e/lib/auth_unittest.py

Comment 3 by nxia@chromium.org, Feb 22 2018

Status: Fixed (was: Untriaged)

Sign in to add a comment