New issue
Advanced search Search tips

Issue 812858 link

Starred by 1 user
Status: Fixed
Owner:
mpear...@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Wrong Timestamp Sent for Omnibox Contextual Suggestion Request Logging

Project Member Reported by mpear...@chromium.org, Feb 15 2018 

Discussed in depth in internal bug b/73108133.

In short, the timestamp the contextual suggestion server is trying to log a URL with doesn't match the timestamp used on the navigation to the URL.  It needs to match for logging to work.

The current issue is that the timestamp being sent is in milliseconds, whereas the navigation timestamp is in microseconds.  Multiplying by 1000 doesn't tend to produce matches. :-P
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71360b52af86de3b5ac6ac2cb7025579b7a44cb6

commit 71360b52af86de3b5ac6ac2cb7025579b7a44cb6
Author: Mark Pearson <mpearson@chromium.org>
Date: Thu Feb 22 00:28:54 2018

Omnibox - Contextual Suggestions - Send Timestamp in Microseconds

not milliseconds.

Microseconds since Unix epoch is apparently what the server expects.

Bug: 692471, 812858 
Change-Id: I05199211b85e39301ae6789254bc364560bf8896
Reviewed-on: https://chromium-review.googlesource.com/923001
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538275}
[modify] https://crrev.com/71360b52af86de3b5ac6ac2cb7025579b7a44cb6/components/omnibox/browser/contextual_suggestions_service.cc

Comment 2 by mpear...@chromium.org, Feb 22 2018 

Leaving this bug open until the fix has been verified.  I.e., the contextual suggestion request timestamp matches the timestamp on the navigation.

Comment 3 by mpear...@chromium.org, Feb 22 2018

Summary: Wrong Timestamp Sent for Omnibox Contextual Suggestion Request Logging (was: Wrong Timestamp Sent for Omnibox Contextual Suggestion Request Loggin)

Comment 4 by mpear...@chromium.org, Mar 5 2018

Status: Fixed (was: Assigned)
I'm told it seems like this is working now.
►

Sign in to add a comment