New issue
Advanced search Search tips

Issue 812819 link

Starred by 1 user
Status: Fixed
Owner:
nrpeter@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Initiator field in chrome.webRequest events is empty for unique origins

Project Member Reported by nrpeter@chromium.org, Feb 15 2018 
Chrome Version: 64.0.3282.140
OS: Debian Linux

What steps will reproduce the problem?
(1) Add a listener to chrome.webRequest.onBeforeSendHeaders
(2) Load a page from a Data URI that itself makes a request

What is the expected result?
Some indication that the request was unique rather than missing

What happens instead?
The initiator field is not present
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c12349df233fd24786c532115ada069b1f31a4fb

commit c12349df233fd24786c532115ada069b1f31a4fb
Author: Nick Peterson <nrpeter@chromium.org>
Date: Thu Feb 22 18:31:54 2018

Return "null" as initiator for requests initiated from a unique origin.

Events in chrome.webRequest.* include an optional initiator
string. When the origin that initiated a request was unique the
initiator was not populated. This makes it difficult to tell the
difference between requests that had no actual initiator and those with
a unique initiator.

This change returns the keyword "null" when a request was initiated
from a unique origin. An example of a unique origin is the Data URI.

Bug:  812819 
Change-Id: I24b824a37196fba4a4d7474232ce962e017cf3f4
Reviewed-on: https://chromium-review.googlesource.com/922931
Commit-Queue: Nick Peterson <nrpeter@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538495}
[modify] https://crrev.com/c12349df233fd24786c532115ada069b1f31a4fb/chrome/test/data/extensions/api_test/webrequest/test_types.js
[modify] https://crrev.com/c12349df233fd24786c532115ada069b1f31a4fb/extensions/browser/api/web_request/web_request_event_details.cc
[modify] https://crrev.com/c12349df233fd24786c532115ada069b1f31a4fb/extensions/common/api/web_request.json

Comment 2 by nrpeter@chromium.org, Feb 22 2018

Status: Fixed (was: Started)
►

Sign in to add a comment