New issue
Advanced search Search tips

Issue 812808 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: 2018-03-19
OS: ----
Pri: 3
Type: Task
Team-Security-UX



Sign in to add a comment

Cleanup ChromeMetricsHelper class

Project Member Reported by cthomp@chromium.org, Feb 15 2018

Issue description

As a result of the removal of the Experience Sampling extension API ( issue 810420 ), the ChromeMetricsHelper class [1] seems a bit superfluous now that it doesn't help handle experience sampling events. The only remaining specialization is for captive portal so we may be able to move that logic back into the captive portal interstitials and remove this class. However, this class is currently used by a lot of the interstitials, so we'll need to investigate further. Likely we can refactor the interstitials and get rid of ChromeMetricsHelper.

[1] https://cs.chromium.org/chromium/src/chrome/browser/interstitials/chrome_metrics_helper.h?q=ChromeMetricsHelper&sq=package:chromium&dr=CSs&l=31
 

Comment 1 by cthomp@chromium.org, Feb 15 2018

Labels: M-66
NextAction: 2018-03-19
Setting a next action for next month in case this slips from my queue until after M66.
The NextAction date has arrived: 2018-03-19

Sign in to add a comment