New issue
Advanced search Search tips

Issue 812806 link

Starred by 2 users
Status: Fixed
Owner:
mthiesse@chromium.org
Closed: Feb 2018
Cc:
mthiesse@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Backing out of DOFF returns to exit VR request, crashes when attempting to DOFF again

Project Member Reported by mthiesse@chromium.org, Feb 15 2018 
Not sure if this is doable on ToT, but if something requests DOFF with an explanation and the user hits 'Exit VR' but then backs out of DOFF, they're returned to the request to DOFF. Clicking 'Exit VR' again leads to a assertion failure because the DOFF client was already responded to.

Comment 1 by mthiesse@chromium.org, Feb 15 2018

Cc: mthiesse@chromium.org
 Issue 812768  has been merged into this issue.

Comment 2 by mthiesse@chromium.org, Feb 15 2018 

 Issue 812759  has been merged into this issue.

Comment 3 by mthiesse@chromium.org, Feb 15 2018 

 Issue 812757  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d

commit 8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Wed Feb 21 22:17:16 2018

VR: Make DOFF flows more sane.

The gl thread will now clear the DOFF request state itself when
reporting doff dialog results.

Fixed a crash where if DOFF wasn't optional, re-requesting DOFF caused
a securityException, as Chrome hadn't become the foreground VR app yet.

De-duplicates a bunch of code.

Bug:  812806 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ied0111751f024e07f500c61486408691c6696d1b
Reviewed-on: https://chromium-review.googlesource.com/922801
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538230}
[modify] https://crrev.com/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrExternalNavigationDelegate.java
[modify] https://crrev.com/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d/chrome/browser/vr/browser_ui_interface.h
[modify] https://crrev.com/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d/chrome/browser/vr/elements/audio_permission_prompt.cc
[modify] https://crrev.com/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d/chrome/browser/vr/elements/audio_permission_prompt.h
[modify] https://crrev.com/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d/chrome/browser/vr/elements/audio_permission_prompt_texture.cc
[modify] https://crrev.com/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d/chrome/browser/vr/elements/audio_permission_prompt_texture.h
[modify] https://crrev.com/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d/chrome/browser/vr/elements/exit_prompt.cc
[modify] https://crrev.com/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d/chrome/browser/vr/elements/exit_prompt.h
[modify] https://crrev.com/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d/chrome/browser/vr/elements/exit_prompt_texture.h
[modify] https://crrev.com/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d/chrome/browser/vr/elements/exit_prompt_unittest.cc
[modify] https://crrev.com/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d/chrome/browser/vr/test/mock_browser_ui_interface.h
[modify] https://crrev.com/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d/chrome/browser/vr/ui.cc
[modify] https://crrev.com/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d/chrome/browser/vr/ui.h
[modify] https://crrev.com/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/8a9a1026cdc1df0f2a91c48f32ccb075c1f03f2d/chrome/browser/vr/ui_unittest.cc

Comment 5 by mthiesse@chromium.org, Feb 22 2018

Status: Fixed (was: Started)

Comment 6 by mthiesse@chromium.org, Feb 22 2018 

 Issue 812758  has been merged into this issue.

Comment 7 by dougman@chromium.org, Feb 23 2018

Labels: Test-Manual

Comment 8 by dougman@chromium.org, Mar 8 2018

Labels: -Test-Manual Test-Complete
►

Sign in to add a comment