New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812773 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

Merge Mojo perf test suites

Project Member Reported by oksamyt@chromium.org, Feb 15 2018

Issue description

We have two mojo test binaries for performance tests:

  mojo_public_bindings_perftests
  mojo_public_system_perftests

They should be merged into one binary mojo_perftests.
 
Components: Internals>Mojo>Bindings Internals>Mojo>SystemsAPI
Status: Untriaged
Summary: Merge Mojo perf test suites (was: Merge Mojo test suites)
Description: Show this description

Comment 4 by roc...@chromium.org, Feb 15 2018

Description: Show this description

Comment 5 by roc...@chromium.org, Feb 15 2018

Cc: roc...@chromium.org
Huh, I didn't even know copying a bug was a thing you could do!

I updated the description to reflect the original perftests names. Bug otherwise LGTM. If you're planning to do the work you can also assign the bug to yourself.
Copying an existing bug was easier for me because I got lost in the new bug templates and wasn't sure what to choose. Are there any guidelines for creating bugs in this area/project?
Also, is it OK to assign an untriaged bug? How are the priorities determined?
Cc: oksamyt@chromium.org

Comment 8 by roc...@chromium.org, Feb 21 2018

Typically I just choose "Defect Report from Developer" and wipe out all the prepopulated fields.

As for assignment and status - if im going to work on it, I just mark it Assigned or Started and assign to myself. Untriaged is generally reserved for things which haven't been given any real thought by developers yet, Available for things which are understood but not claimed by anyone.
Labels: OS-Android OS-Chrome OS-Fuchsia OS-iOS OS-Linux OS-Mac OS-Windows
Owner: oksamyt@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32f0a13d8e252532333c0ea31d0f4ad5ca369452

commit 32f0a13d8e252532333c0ea31d0f4ad5ca369452
Author: Oksana Zhuravlova <oksamyt@chromium.org>
Date: Tue Feb 27 00:12:55 2018

Combined three mojo perf test binaries into one mojo_perftests

mojo_perftests includes tests from mojo_public_bindings_perftests,
mojo_public_system_perftests and mojo_message_pipe_perftests. Relevant
infrastructure files were updated (including
//src/build/android/pylib/gtest/gtest_test_instance.py).

Bug:  812773 
Change-Id: I80fa1471a0c8c6c6949bade682a5391c9b40cae3
Reviewed-on: https://chromium-review.googlesource.com/933090
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539322}
[modify] https://crrev.com/32f0a13d8e252532333c0ea31d0f4ad5ca369452/BUILD.gn
[modify] https://crrev.com/32f0a13d8e252532333c0ea31d0f4ad5ca369452/build/android/pylib/gtest/gtest_test_instance.py
[modify] https://crrev.com/32f0a13d8e252532333c0ea31d0f4ad5ca369452/mojo/BUILD.gn
[modify] https://crrev.com/32f0a13d8e252532333c0ea31d0f4ad5ca369452/mojo/edk/system/BUILD.gn
[modify] https://crrev.com/32f0a13d8e252532333c0ea31d0f4ad5ca369452/mojo/edk/test/BUILD.gn
[modify] https://crrev.com/32f0a13d8e252532333c0ea31d0f4ad5ca369452/tools/determinism/deterministic_build_whitelist.pyl

Note: these tests don't reliably pass on android, but since they are not 
run on bots, this is not a high priority issue.
Status: Fixed (was: Started)

Sign in to add a comment