Issue 812770  has been merged into this issue.

This is yet another case where there's a spoof against the already-subtle "By the way, you're in full-screen now whether you like it or not" notice.

mfoltz: could you please help take a look at this, or help get this assigned to the right person?

I can't repro this on Linux.  It seems like a Mac browser UI issue - does it show the fullscreen notification in a different way?  Trent what do you think?

re C#5 - Cast UI overlay the fullscreen notification (This is similar to  bug 752003 ).

+avi who owns a similar macOS-only bug (bug 812060).

I solved this with JS dialogs and popups by dropping fullscreen in those cases. Do we want to make that a more general policy for all dialogs?

johnpallett@ may have some feedback about dropping out of fullscreen when activating the Media Router dialog.  It's a common use case to cast fullscreen video.

Is there a way we can tell when the notification is showing so we can drop out of fullscreen selectively?

There's no easy way of knowing if the notification is showing, plus that means uncertainty for the author of the page as to why showing the media router dialog sometimes kicks you out of fullscreen but sometimes it doesn't.

If you do that, do it all the time.

I hit some dead-ends playing around with window levels and key-value observers. But I found a thing that seems to help: https://chromium-review.googlesource.com/c/chromium/src/+/923227

I've merged  Issue 813815  and  Issue 817809  into this. Issue 812060 is something different - it doesn't actually show a fullscreen notification so there's nothing to obscure.

per https://chromium-review.googlesource.com/c/chromium/src/+/923227#message-79972ff4162f078a3e21572af8e972292e9363b3 I think avi's looking at a cross-platform answer for this.

 Issue 871021  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d41e77125f3de8d722b6d8303599abaf2a91667

commit 3d41e77125f3de8d722b6d8303599abaf2a91667
Author: Avi Drissman <avi@chromium.org>
Date: Mon Aug 27 21:18:08 2018

If a dialog is shown, drop fullscreen.

BUG= 875066 ,  817809 , 792876,  812769 ,  813815 
TEST=included

Change-Id: Ic3d697fa3c4b01f5d7fea77391857177ada660db
Reviewed-on: https://chromium-review.googlesource.com/1185208
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586418}
[modify] https://crrev.com/3d41e77125f3de8d722b6d8303599abaf2a91667/chrome/browser/ui/browser.cc
[modify] https://crrev.com/3d41e77125f3de8d722b6d8303599abaf2a91667/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/3d41e77125f3de8d722b6d8303599abaf2a91667/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/3d41e77125f3de8d722b6d8303599abaf2a91667/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/3d41e77125f3de8d722b6d8303599abaf2a91667/content/browser/web_contents/web_contents_impl_browsertest.cc

*** Boilerplate reminders! ***
Please do NOT publicly disclose details until a fix has been released to all our users. Early public disclosure may cancel the provisional reward. Also, please be considerate about disclosure when the bug affects a core library that may be used by other products. Please do NOT share this information with third parties who are not directly involved in fixing the bug. Doing so may cancel the provisional reward. Please be honest if you have already disclosed anything publicly or to third parties. Lastly, we understand that some of you are not interested in money. We offer the option to donate your reward to an eligible charity. If you prefer this option, let us know and we will also match your donation - subject to our discretion. Any rewards that are unclaimed after 12 months will be donated to a charity of our choosing.
*********************************

The VRP panel decided to award $500 for this report, thanks as ever!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c8c2146c2f99fb7eefb79b170e60f53700f7ab8

commit 1c8c2146c2f99fb7eefb79b170e60f53700f7ab8
Author: Yuri Wiitala <miu@chromium.org>
Date: Wed Sep 19 19:47:42 2018

Dialogs don't drop tab fullscreen when in FullscreenWithinTab mode.

Overrides the default behavior of dropping fullscreen when a tab modal
dialog is opened in the FullscreenWithinTab case. This is because, in
FWT mode, the browser window is in its normal layout (not fullscreened).

Bug:  883535 , 812769 
Change-Id: I1c262954b962d508eb86ef9a8a312bec03ab2332
Reviewed-on: https://chromium-review.googlesource.com/1228976
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592522}
[modify] https://crrev.com/1c8c2146c2f99fb7eefb79b170e60f53700f7ab8/chrome/browser/ui/browser.cc
[modify] https://crrev.com/1c8c2146c2f99fb7eefb79b170e60f53700f7ab8/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/1c8c2146c2f99fb7eefb79b170e60f53700f7ab8/chrome/browser/ui/exclusive_access/fullscreen_controller.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a438e211d0aa6f12eee274b22c4daef442a28eac

commit a438e211d0aa6f12eee274b22c4daef442a28eac
Author: Yuri Wiitala <miu@chromium.org>
Date: Fri Sep 21 20:35:42 2018

Dialogs don't drop tab fullscreen when in FullscreenWithinTab mode.

Overrides the default behavior of dropping fullscreen when a tab modal
dialog is opened in the FullscreenWithinTab case. This is because, in
FWT mode, the browser window is in its normal layout (not fullscreened).

Bug:  883535 , 812769 
Change-Id: I1c262954b962d508eb86ef9a8a312bec03ab2332
Reviewed-on: https://chromium-review.googlesource.com/1228976
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#592522}(cherry picked from commit 1c8c2146c2f99fb7eefb79b170e60f53700f7ab8)
Reviewed-on: https://chromium-review.googlesource.com/1239346
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#565}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/a438e211d0aa6f12eee274b22c4daef442a28eac/chrome/browser/ui/browser.cc
[modify] https://crrev.com/a438e211d0aa6f12eee274b22c4daef442a28eac/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/a438e211d0aa6f12eee274b22c4daef442a28eac/chrome/browser/ui/exclusive_access/fullscreen_controller.h

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot