New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812763 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Improve ethernet device detection on moblab

Project Member Reported by haddowk@chromium.org, Feb 15 2018

Issue description


Currently there are two ways for the bootup script to determine which ethernet port is the LAN ( with the DUT's connected ) and which is WAN ( usually has access to google services via the internet )

1)  By puttin a mac address in a configuration file. ( used by moblab VM )
2)  By looking at device types and assuming the built in network is the WAN and the USB network is the LAN

Next Gen Moblab has 2 build in NIC's so these strategies need to be extended.

Next version will:

1) Check for the configuration file.
   if that is not successful then :
2) Check which interface has an IP address, WAN has IP LAN no IP
   if that is not successful then :
3) Check device types, USB still LAN ( Legacy )
   if that is not successful then :
4) Just pick one interface to be internal one to be external, this allow the device still to boot.




 
Cc: haddowk@chromium.org
 Issue 812764  has been merged into this issue.
 Issue 812765  has been merged into this issue.
 Issue 812766  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/d4bffd52b8abcd4606e20878e7543112dc59b7f3

commit d4bffd52b8abcd4606e20878e7543112dc59b7f3
Author: Keith Haddow <haddowk@chromium.org>
Date: Tue Feb 27 06:07:14 2018

[moblab] Add in retries for the network bridge IP detection.

To give the DHCP server some time to assign an address for the
external network interface, have a retry loop which means we
should wait about 60 seconds for the interface to get an IP

TEST=build and tested on local moblab
BUG= chromium:812763 

Change-Id: I615d956e0d2a224ad88dbdf0ed83c6020c742017
Reviewed-on: https://chromium-review.googlesource.com/938190
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>

[modify] https://crrev.com/d4bffd52b8abcd4606e20878e7543112dc59b7f3/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-network-bridge-init.conf

Sign in to add a comment