New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812729 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

UKM does not regularly schedule rotations

Project Member Reported by holte@chromium.org, Feb 15 2018

Issue description

UkmService::RotateLog in not notifying the scheduler of it's completion, which leads to the scheduler only doing one rotation, until forced by shutdown, backgrounding, or UKM enabled state change.
 

Comment 1 by holte@chromium.org, Feb 15 2018

Cc: holte@chromium.org
 Issue 812731  has been merged into this issue.
 Issue 812732  has been merged into this issue.
 Issue 812743  has been merged into this issue.
 Issue 812793  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a8bf4c52054b40a9160b0db5031aae34ecbda07

commit 0a8bf4c52054b40a9160b0db5031aae34ecbda07
Author: Steven Holte <holte@google.com>
Date: Fri Feb 16 02:42:00 2018

Notify UKM scheduler of RotationFinished.

Bug:812729

Change-Id: I418d2b540302805c08f78d63635f394f02fe3ac5
Reviewed-on: https://chromium-review.googlesource.com/922722
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537131}
[modify] https://crrev.com/0a8bf4c52054b40a9160b0db5031aae34ecbda07/components/ukm/ukm_service.cc

Comment 3 by holte@chromium.org, Feb 20 2018

Labels: Merge-Request-65
Requesting merge to M65 since this impacts the quality of the data.
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 20 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/271f2cfed26e782282b50c88f92eee2c8242beb4

commit 271f2cfed26e782282b50c88f92eee2c8242beb4
Author: Steven Holte <holte@google.com>
Date: Tue Feb 20 22:30:48 2018

Test UKM logs rotation.

Bug:812729

Change-Id: I113527a6c3c7d6ecc8e71f499b39cd7201e4bb73
Reviewed-on: https://chromium-review.googlesource.com/922687
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537912}
[modify] https://crrev.com/271f2cfed26e782282b50c88f92eee2c8242beb4/components/ukm/ukm_service.h
[modify] https://crrev.com/271f2cfed26e782282b50c88f92eee2c8242beb4/components/ukm/ukm_service_unittest.cc

Comment 6 by holte@chromium.org, Feb 20 2018

Cc: nikunjb@chromium.org

Comment 7 by gov...@chromium.org, Feb 20 2018

Pls apply appropriate OSs label. Thank you.

Comment 8 by holte@chromium.org, Feb 20 2018

Labels: OS-Android OS-Chrome OS-iOS OS-Linux OS-Mac OS-Windows

Comment 9 by gov...@chromium.org, Feb 20 2018


Before we approve merge to M65, could you pls confirm followings?

Which you're requesting a merge to M65? 
Is this M65 regression and critical to merge?
Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge?
Any other imp details to justify the merge.

Please note M65 is VERY close to Stable promotion so merge bar is very high. Thank you.

Comment 10 by holte@chromium.org, Feb 20 2018

The change needed for merging is just commit 0a8bf4c52054b40a9160b0db5031aae34ecbda07

The other change is strictly a test.

This is a critical bug that impacts the quality of the metrics data that we are collecting.

We see the change working in Canary and see it reflected in UMA data.

Several teams are depending on this data incl Autofill, Payments, Password management.


Labels: -Merge-Review-65 Merge-Approved-65
Approving merge for 0a8bf4c52054b40a9160b0db5031aae34ecbda07 to M65 branch 3325 based on comment #10. Please merge ASAP so we can pick it up for tomorrow's beta release. Thank you.
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 20 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/581c8e8599b9e051084e8d7fbba15d850927e0e1

commit 581c8e8599b9e051084e8d7fbba15d850927e0e1
Author: Steven Holte <holte@google.com>
Date: Tue Feb 20 23:47:03 2018

Notify UKM scheduler of RotationFinished.

Bug:812729

TBR=holte@google.com

(cherry picked from commit 0a8bf4c52054b40a9160b0db5031aae34ecbda07)

Change-Id: I418d2b540302805c08f78d63635f394f02fe3ac5
Reviewed-on: https://chromium-review.googlesource.com/922722
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#537131}
Reviewed-on: https://chromium-review.googlesource.com/927750
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#521}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/581c8e8599b9e051084e8d7fbba15d850927e0e1/components/ukm/ukm_service.cc

Comment 13 by holte@chromium.org, Feb 27 2018

Status: Fixed (was: Started)

Sign in to add a comment