UKM does not regularly schedule rotations |
||||||||
Issue descriptionUkmService::RotateLog in not notifying the scheduler of it's completion, which leads to the scheduler only doing one rotation, until forced by shutdown, backgrounding, or UKM enabled state change.
,
Feb 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a8bf4c52054b40a9160b0db5031aae34ecbda07 commit 0a8bf4c52054b40a9160b0db5031aae34ecbda07 Author: Steven Holte <holte@google.com> Date: Fri Feb 16 02:42:00 2018 Notify UKM scheduler of RotationFinished. Bug:812729 Change-Id: I418d2b540302805c08f78d63635f394f02fe3ac5 Reviewed-on: https://chromium-review.googlesource.com/922722 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#537131} [modify] https://crrev.com/0a8bf4c52054b40a9160b0db5031aae34ecbda07/components/ukm/ukm_service.cc
,
Feb 20 2018
Requesting merge to M65 since this impacts the quality of the data.
,
Feb 20 2018
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/271f2cfed26e782282b50c88f92eee2c8242beb4 commit 271f2cfed26e782282b50c88f92eee2c8242beb4 Author: Steven Holte <holte@google.com> Date: Tue Feb 20 22:30:48 2018 Test UKM logs rotation. Bug:812729 Change-Id: I113527a6c3c7d6ecc8e71f499b39cd7201e4bb73 Reviewed-on: https://chromium-review.googlesource.com/922687 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#537912} [modify] https://crrev.com/271f2cfed26e782282b50c88f92eee2c8242beb4/components/ukm/ukm_service.h [modify] https://crrev.com/271f2cfed26e782282b50c88f92eee2c8242beb4/components/ukm/ukm_service_unittest.cc
,
Feb 20 2018
,
Feb 20 2018
Pls apply appropriate OSs label. Thank you.
,
Feb 20 2018
,
Feb 20 2018
Before we approve merge to M65, could you pls confirm followings? Which you're requesting a merge to M65? Is this M65 regression and critical to merge? Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge? Any other imp details to justify the merge. Please note M65 is VERY close to Stable promotion so merge bar is very high. Thank you.
,
Feb 20 2018
The change needed for merging is just commit 0a8bf4c52054b40a9160b0db5031aae34ecbda07 The other change is strictly a test. This is a critical bug that impacts the quality of the metrics data that we are collecting. We see the change working in Canary and see it reflected in UMA data. Several teams are depending on this data incl Autofill, Payments, Password management.
,
Feb 20 2018
Approving merge for 0a8bf4c52054b40a9160b0db5031aae34ecbda07 to M65 branch 3325 based on comment #10. Please merge ASAP so we can pick it up for tomorrow's beta release. Thank you.
,
Feb 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/581c8e8599b9e051084e8d7fbba15d850927e0e1 commit 581c8e8599b9e051084e8d7fbba15d850927e0e1 Author: Steven Holte <holte@google.com> Date: Tue Feb 20 23:47:03 2018 Notify UKM scheduler of RotationFinished. Bug:812729 TBR=holte@google.com (cherry picked from commit 0a8bf4c52054b40a9160b0db5031aae34ecbda07) Change-Id: I418d2b540302805c08f78d63635f394f02fe3ac5 Reviewed-on: https://chromium-review.googlesource.com/922722 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#537131} Reviewed-on: https://chromium-review.googlesource.com/927750 Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#521} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/581c8e8599b9e051084e8d7fbba15d850927e0e1/components/ukm/ukm_service.cc
,
Feb 27 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by holte@chromium.org
, Feb 15 2018