New issue
Advanced search Search tips

Issue 812717 link

Starred by 1 user
Status: Started
Owner:
lazyboy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Cleanup extensions/ base::ResetAndReturn on callbacks

Project Member Reported by lazyboy@chromium.org, Feb 15 2018 
We use base::ResetAndReturn in extensions/ code to clear RepeatingCallback-s in a few places. Clean those up to refer to those callbacks as OnceCallback as base::ResetAndReturn usages suggest they really are meant to be called once.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c66c24378863b647b95c6213b5177ac3976714b

commit 8c66c24378863b647b95c6213b5177ac3976714b
Author: Istiaque Ahmed <lazyboy@chromium.org>
Date: Fri Feb 16 17:57:34 2018

Extensions: Store and use RunLoop::QuitClosure as OnceClosure.

It won't be necessary to call base::ResetAndReturn. Use std::move
to Run() those closures instead.

Bug: 812717
Change-Id: Ie8956bfcb23e3411025352d4714a9c928c0869fe
Reviewed-on: https://chromium-review.googlesource.com/920742
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537349}
[modify] https://crrev.com/8c66c24378863b647b95c6213b5177ac3976714b/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc
[modify] https://crrev.com/8c66c24378863b647b95c6213b5177ac3976714b/chrome/browser/extensions/content_verifier_browsertest.cc
[modify] https://crrev.com/8c66c24378863b647b95c6213b5177ac3976714b/chrome/browser/extensions/extension_install_prompt_test_helper.cc
[modify] https://crrev.com/8c66c24378863b647b95c6213b5177ac3976714b/chrome/browser/extensions/extension_install_prompt_test_helper.h
[modify] https://crrev.com/8c66c24378863b647b95c6213b5177ac3976714b/chrome/browser/extensions/extension_reenabler_unittest.cc
[modify] https://crrev.com/8c66c24378863b647b95c6213b5177ac3976714b/extensions/browser/api/runtime/restart_after_delay_api_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d917560a10f4a74a61b0213c963050841052d0a

commit 1d917560a10f4a74a61b0213c963050841052d0a
Author: Istiaque Ahmed <lazyboy@chromium.org>
Date: Fri Feb 16 18:25:03 2018

Extensions: Cleanup usages of ResetAndReturn on OnceCallbacks.

These do not need base::ResetAndReturn, use std::move(callack).Run()
instead.

Change-Id: Ifa90ffffcae8e64fd8cced276e482b3ecf21d6a9
Bug: 812717
Reviewed-on: https://chromium-review.googlesource.com/920645
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537353}
[modify] https://crrev.com/1d917560a10f4a74a61b0213c963050841052d0a/chrome/browser/extensions/api/identity/identity_apitest.cc
[modify] https://crrev.com/1d917560a10f4a74a61b0213c963050841052d0a/chrome/browser/extensions/chrome_app_icon_unittest.cc
[modify] https://crrev.com/1d917560a10f4a74a61b0213c963050841052d0a/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc
[modify] https://crrev.com/1d917560a10f4a74a61b0213c963050841052d0a/chrome/browser/ui/views/extensions/pwa_confirmation_view.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ceaa4d195bda6edbbb19bcd6763c0baa3449bac

commit 8ceaa4d195bda6edbbb19bcd6763c0baa3449bac
Author: Istiaque Ahmed <lazyboy@chromium.org>
Date: Fri Feb 16 20:00:49 2018

Extensions: Use OnceCallbacks in FileReader.

The callbacks in FileReader are used as once callbacks, but they
are declared to be RepeatingCallbacks. Fix this.

Bug: 812717
Change-Id: I89badc6bbd3583fc510d47218bb7bb69d537964a
Reviewed-on: https://chromium-review.googlesource.com/919704
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537392}
[modify] https://crrev.com/8ceaa4d195bda6edbbb19bcd6763c0baa3449bac/extensions/browser/api/execute_code_function.cc
[modify] https://crrev.com/8ceaa4d195bda6edbbb19bcd6763c0baa3449bac/extensions/browser/file_reader.cc
[modify] https://crrev.com/8ceaa4d195bda6edbbb19bcd6763c0baa3449bac/extensions/browser/file_reader.h
►

Sign in to add a comment