New issue
Advanced search Search tips

Issue 812715 link

Starred by 1 user
Status: Fixed
Owner:
l...@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: cannot open command menu on Sources panel

Project Member Reported by l...@chromium.org, Feb 15 2018 
What steps will reproduce the problem?
(1) Open DevTools Sources panel
(2) Open command menu 'Ctrl-shift-P'

What is the expected result?
Command menu should appear populated with lots of items

What happens instead?
Command menu appears empty
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e663d59577471bb81162359dc7ea09af1f210416

commit e663d59577471bb81162359dc7ea09af1f210416
Author: Erik Luo <luoe@chromium.org>
Date: Fri Feb 16 02:43:45 2018

DevTools: fix Sources extensions with Command Menu entries

- Adds a check for valid CommandMenu extensions (category actions
  must have a title, otherwise CommandMenu fails to populate)
- Fixes 'debugger.previous/next-call-frame's title
- Adds 'Step*' actions to CommandMenu

Bug:  812715 
Change-Id: I9396f797d474556c593b678c372f9423bf2d04b1
Reviewed-on: https://chromium-review.googlesource.com/922505
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537134}
[modify] https://crrev.com/e663d59577471bb81162359dc7ea09af1f210416/third_party/WebKit/Source/devtools/front_end/sources/module.json
[modify] https://crrev.com/e663d59577471bb81162359dc7ea09af1f210416/third_party/WebKit/Source/devtools/front_end/ui/ActionRegistry.js

Comment 2 by l...@chromium.org, Feb 16 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment