New issue
Advanced search Search tips

Issue 812711 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

BadValueError: duration and exit_code must be set with state Execution timed out

Project Member Reported by mar...@chromium.org, Feb 15 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/726b1617ac2cbc689a4fa45153ae605e363c29d9

commit 726b1617ac2cbc689a4fa45153ae605e363c29d9
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Fri Mar 23 20:59:53 2018

[swarming] Relax duration and exit_code in task result

It used to require both to be set or not. Relax this rule, as this happens in
case of internal failure. Having this rule just causes even more trouble.

Condense the unit test a bit by created default expectations and then overriding
the expected difference. This highlights the difference more and shorten the
code.

This will help reduce the number of BOT_DIED caused by improper TIMED_OUT
handling.

Bug: 812711
Change-Id: I2b0d55f4b79732bb42db7bc0745759460755ffcb
Reviewed-on: https://chromium-review.googlesource.com/978381
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/726b1617ac2cbc689a4fa45153ae605e363c29d9/appengine/swarming/server/task_result.py
[modify] https://crrev.com/726b1617ac2cbc689a4fa45153ae605e363c29d9/appengine/swarming/server/task_result_test.py

Sign in to add a comment