New issue
Advanced search Search tips

Issue 812710 link

Starred by 2 users
Status: Fixed
Owner:
jsaul@google.com
Closed: Jul 10
Cc:
dlkumar@google.com
ma...@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Clean up AutofillCreditCardBankNameDisplay experiment flag

Project Member Reported by jsaul@google.com, Feb 15 2018 
The AutofillCreditCardBankNameDisplay experiment is now being rolled out to 100% on all platforms.  Please do the following work:
- Clean up its flag
- Remove it from fieldtrial_testing_config
- Set the Finch configs to max_version where the flag was cleaned up

Comment 1 by jsaul@google.com, Feb 15 2018

Description: Show this description

Comment 2 by jsaul@google.com, Feb 15 2018

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e363dc219abb57a818406fffcad3bb30555dab4c

commit e363dc219abb57a818406fffcad3bb30555dab4c
Author: Jared Saul <jsaul@google.com>
Date: Fri Feb 16 19:07:47 2018

Clean up kAutofillCreditCardBankNameDisplay flag

Bug:  812710 
Change-Id: I4344c258668c5017a0a145e487ca2eb526bd49bc
Reviewed-on: https://chromium-review.googlesource.com/923281
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#537368}
[modify] https://crrev.com/e363dc219abb57a818406fffcad3bb30555dab4c/chrome/browser/about_flags.cc
[modify] https://crrev.com/e363dc219abb57a818406fffcad3bb30555dab4c/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/e363dc219abb57a818406fffcad3bb30555dab4c/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/e363dc219abb57a818406fffcad3bb30555dab4c/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/e363dc219abb57a818406fffcad3bb30555dab4c/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/e363dc219abb57a818406fffcad3bb30555dab4c/components/autofill/core/browser/credit_card.cc
[modify] https://crrev.com/e363dc219abb57a818406fffcad3bb30555dab4c/components/autofill/core/browser/credit_card_unittest.cc
[modify] https://crrev.com/e363dc219abb57a818406fffcad3bb30555dab4c/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/e363dc219abb57a818406fffcad3bb30555dab4c/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/e363dc219abb57a818406fffcad3bb30555dab4c/tools/metrics/histograms/enums.xml
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae93aa1ca751f10fc35bde299e68124ca347d9a0

commit ae93aa1ca751f10fc35bde299e68124ca347d9a0
Author: Jared Saul <jsaul@google.com>
Date: Fri Mar 23 19:04:39 2018

Revert "Clean up kAutofillCreditCardBankNameDisplay flag"

This reverts commit e363dc219abb57a818406fffcad3bb30555dab4c.

Reason for revert: Not convinced metrics are good; performing flag holdback

Original change's description:
> Clean up kAutofillCreditCardBankNameDisplay flag
>
> Bug:  812710 
> Change-Id: I4344c258668c5017a0a145e487ca2eb526bd49bc
> Reviewed-on: https://chromium-review.googlesource.com/923281
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Commit-Queue: Jared Saul <jsaul@google.com>
> Cr-Commit-Position: refs/heads/master@{#537368}

TBR=mathp@chromium.org,rkaplow@chromium.org,sebsg@chromium.org,jsaul@google.com

Bug:  812710 
Change-Id: I0f15c86af76e686ef4ab55a0313831461503d758
Reviewed-on: https://chromium-review.googlesource.com/974342
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#545544}
[modify] https://crrev.com/ae93aa1ca751f10fc35bde299e68124ca347d9a0/chrome/browser/about_flags.cc
[modify] https://crrev.com/ae93aa1ca751f10fc35bde299e68124ca347d9a0/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/ae93aa1ca751f10fc35bde299e68124ca347d9a0/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/ae93aa1ca751f10fc35bde299e68124ca347d9a0/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/ae93aa1ca751f10fc35bde299e68124ca347d9a0/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/ae93aa1ca751f10fc35bde299e68124ca347d9a0/components/autofill/core/browser/credit_card.cc
[modify] https://crrev.com/ae93aa1ca751f10fc35bde299e68124ca347d9a0/components/autofill/core/browser/credit_card_unittest.cc
[modify] https://crrev.com/ae93aa1ca751f10fc35bde299e68124ca347d9a0/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/ae93aa1ca751f10fc35bde299e68124ca347d9a0/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/ae93aa1ca751f10fc35bde299e68124ca347d9a0/tools/metrics/histograms/enums.xml
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 27 2018

Labels: merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0eae8f96e459250dfdb685e87c19757f7a1b778

commit b0eae8f96e459250dfdb685e87c19757f7a1b778
Author: Jared Saul <jsaul@google.com>
Date: Tue Mar 27 21:22:08 2018

Revert "Clean up kAutofillCreditCardBankNameDisplay flag"

This reverts commit e363dc219abb57a818406fffcad3bb30555dab4c.

Reason for revert: Not convinced metrics are good; performing flag holdback

Original change's description:
> Clean up kAutofillCreditCardBankNameDisplay flag
>
> Bug:  812710 
> Change-Id: I4344c258668c5017a0a145e487ca2eb526bd49bc
> Reviewed-on: https://chromium-review.googlesource.com/923281
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Commit-Queue: Jared Saul <jsaul@google.com>
> Cr-Commit-Position: refs/heads/master@{#537368}

TBR=jsaul@google.com, mathp@chromium.org, rkaplow@chromium.org, sebsg@chromium.org

(cherry picked from commit ae93aa1ca751f10fc35bde299e68124ca347d9a0)

Bug:  812710 
Change-Id: I0f15c86af76e686ef4ab55a0313831461503d758
Reviewed-on: https://chromium-review.googlesource.com/974342
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#545544}
Reviewed-on: https://chromium-review.googlesource.com/982602
Cr-Commit-Position: refs/branch-heads/3359@{#474}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/b0eae8f96e459250dfdb685e87c19757f7a1b778/chrome/browser/about_flags.cc
[modify] https://crrev.com/b0eae8f96e459250dfdb685e87c19757f7a1b778/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/b0eae8f96e459250dfdb685e87c19757f7a1b778/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/b0eae8f96e459250dfdb685e87c19757f7a1b778/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/b0eae8f96e459250dfdb685e87c19757f7a1b778/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/b0eae8f96e459250dfdb685e87c19757f7a1b778/components/autofill/core/browser/credit_card.cc
[modify] https://crrev.com/b0eae8f96e459250dfdb685e87c19757f7a1b778/components/autofill/core/browser/credit_card_unittest.cc
[modify] https://crrev.com/b0eae8f96e459250dfdb685e87c19757f7a1b778/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/b0eae8f96e459250dfdb685e87c19757f7a1b778/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/b0eae8f96e459250dfdb685e87c19757f7a1b778/tools/metrics/histograms/enums.xml
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ef6bc5d9cb1aa4418468a2a93a585d4223f7a15

commit 8ef6bc5d9cb1aa4418468a2a93a585d4223f7a15
Author: Jared Saul <jsaul@google.com>
Date: Fri Jun 22 19:08:08 2018

Set AutofillCreditCardBankNameDisplay to ENABLED_BY_DEFAULT at top-of-tree

Bug:  812710 
Change-Id: I38b1e3f647c857ac1c6d8cbcfbd8eaafe61e4407
Reviewed-on: https://chromium-review.googlesource.com/1112208
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#569723}
[modify] https://crrev.com/8ef6bc5d9cb1aa4418468a2a93a585d4223f7a15/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/8ef6bc5d9cb1aa4418468a2a93a585d4223f7a15/components/autofill/core/browser/credit_card_unittest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34432f65f1a6ab8f25c873422321b2dd68c02e96

commit 34432f65f1a6ab8f25c873422321b2dd68c02e96
Author: Jared Saul <jsaul@google.com>
Date: Tue Jul 10 17:16:07 2018

Clean up kAutofillCreditCardBankNameDisplay flag

This originally happened in CL 923281, but was reverted in CL 974342 in
order to run a 1% holdback.  The results are in and we wish to keep the
feature going.

Bug:  812710 
Change-Id: I7ccd47f3641b3329d083aa5df311b520562b1273
Reviewed-on: https://chromium-review.googlesource.com/1130937
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#573785}
[modify] https://crrev.com/34432f65f1a6ab8f25c873422321b2dd68c02e96/chrome/browser/about_flags.cc
[modify] https://crrev.com/34432f65f1a6ab8f25c873422321b2dd68c02e96/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/34432f65f1a6ab8f25c873422321b2dd68c02e96/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/34432f65f1a6ab8f25c873422321b2dd68c02e96/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/34432f65f1a6ab8f25c873422321b2dd68c02e96/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/34432f65f1a6ab8f25c873422321b2dd68c02e96/components/autofill/core/browser/credit_card.cc
[modify] https://crrev.com/34432f65f1a6ab8f25c873422321b2dd68c02e96/components/autofill/core/browser/credit_card_unittest.cc
[modify] https://crrev.com/34432f65f1a6ab8f25c873422321b2dd68c02e96/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/34432f65f1a6ab8f25c873422321b2dd68c02e96/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/34432f65f1a6ab8f25c873422321b2dd68c02e96/tools/metrics/histograms/enums.xml

Comment 8 by jsaul@google.com, Jul 10

Status: Fixed (was: Assigned)
►

Sign in to add a comment