New issue
Advanced search Search tips

Issue 812696 link

Starred by 1 user
Status: Fixed
Owner:
jsaul@google.com
Closed: May 2018
Cc:
dlkumar@google.com
ma...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Clean up client-side code for upload credit card save CVC fix flow

Project Member Reported by jsaul@google.com, Feb 15 2018 
The CVC fix flow and its accompanying experiment flag is fully rolled out to Desktop, but should be reverted during the Partial Data project as they are *not* mutually exclusive and the Partial Data project provides a better overall experience.

This bug exists for tracking purposes of removing the CVC fix flow code once it is no longer in use.

Comment 1 by jsaul@google.com, Feb 15 2018

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, May 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0

commit 5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0
Author: Jared Saul <jsaul@google.com>
Date: Tue May 01 23:55:00 2018

[Autofill] Remove code for CVC fix flow during credit card upload save

The CVC fix flow ran from M62-M64 on Desktop (just M64 on Mac) but was
disabled in M65 with the launch of Partial Data Project, and can now be
removed entirely.

Bug:  812696 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I555d6ac0996e514702a21d39b0046c85681f4682
Reviewed-on: https://chromium-review.googlesource.com/1034103
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Rachel Blum <groby@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#555234}
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/android_webview/browser/aw_autofill_client.cc
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/android_webview/browser/aw_autofill_client.h
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/chrome/browser/about_flags.cc
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/chrome/browser/ui/autofill/save_card_bubble_controller_impl_browsertest.cc
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/chrome/browser/ui/cocoa/autofill/save_card_bubble_view_unittest.mm
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/chrome/browser/ui/views/autofill/dialog_view_ids.h
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/chrome/browser/ui/views/autofill/save_card_bubble_views.h
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/components/autofill/core/browser/credit_card_save_manager.h
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/components/autofill/core/browser/credit_card_save_manager_unittest.cc
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/components/autofill/core/browser/test_autofill_client.h
[delete] https://crrev.com/02cdbb3e4ff8fedaa5306d461fceca2139b0abdd/components/autofill/core/browser/ui/mock_save_card_bubble_controller.cc
[delete] https://crrev.com/02cdbb3e4ff8fedaa5306d461fceca2139b0abdd/components/autofill/core/browser/ui/mock_save_card_bubble_controller.h
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/components/autofill/core/browser/ui/save_card_bubble_controller.h
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/components/autofill_strings.grdp
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/components/test/data/autofill/credit_card_upload_form_address_and_cc.html
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/ios/web_view/internal/autofill/web_view_autofill_client_ios.h
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
[modify] https://crrev.com/5f6a7ca2a3145e12c1cebe399c722c5bbe0517a0/tools/metrics/histograms/enums.xml

Comment 3 by jsaul@google.com, May 2 2018

Status: Fixed (was: Assigned)

Comment 4 by ma...@chromium.org, May 2 2018 

Phew! Thanks for that.

Comment 5 by jsaul@google.com, May 2 2018 

Gladly. :) It was a lot bigger than I remembered!
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64c540a750df6adb453c0f8e6e63800d8948d04c

commit 64c540a750df6adb453c0f8e6e63800d8948d04c
Author: Jared Saul <jsaul@google.com>
Date: Mon Jun 25 23:24:36 2018

[Autofill] Remove CVC fix flow CurrentFlowStep constants

(Missed this during https://chromium-review.googlesource.com/c/chromium/src/+/1034103)

Bug:  812696 
Change-Id: Ib1ad5f1e8a0c1cb187c0265232119b1417b88e95
Reviewed-on: https://chromium-review.googlesource.com/1114178
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#570235}
[modify] https://crrev.com/64c540a750df6adb453c0f8e6e63800d8948d04c/chrome/browser/ui/views/autofill/save_card_bubble_views.h
►

Sign in to add a comment