New issue
Advanced search Search tips

Issue 812684 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Record visible load time metric for images

Project Member Reported by rajendrant@chromium.org, Feb 15 2018

Issue description

The metric should track how long the user has to wait for a visible image or iframe to load completely. This metric will help understand how much delay does lazyload of images/iframes incurs users.

There will also be sub-histograms for each level of effective connection type, i.e. *.[2GSlow|2G|3G|4G], that get recorded if the current effective connection type matches.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1d023d3d3ca0c6c1484872285f542d6e8eb5d1e

commit a1d023d3d3ca0c6c1484872285f542d6e8eb5d1e
Author: rajendrant <rajendrant@chromium.org>
Date: Mon Feb 26 19:13:38 2018

Record visible load time metric for images

This metric tracks how long the user has to wait for a visible image to
load completely. This metric will help understand how much delay does
lazyload of images incurs users.

Bug:  812684 
Change-Id: Ic97c9a192254a2b64d9f2427d8694d6e36759db9
Reviewed-on: https://chromium-review.googlesource.com/831530
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#539221}
[modify] https://crrev.com/a1d023d3d3ca0c6c1484872285f542d6e8eb5d1e/third_party/WebKit/Source/core/loader/ImageLoader.cpp
[modify] https://crrev.com/a1d023d3d3ca0c6c1484872285f542d6e8eb5d1e/third_party/WebKit/Source/core/loader/ImageLoader.h
[modify] https://crrev.com/a1d023d3d3ca0c6c1484872285f542d6e8eb5d1e/tools/metrics/histograms/histograms.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/208f274e4bcb51748bba83071aa70011ceafa385

commit 208f274e4bcb51748bba83071aa70011ceafa385
Author: Juan Antonio Navarro Pérez <perezju@chromium.org>
Date: Thu Mar 01 13:14:30 2018

Revert "Record visible load time metric for images"

This reverts commit a1d023d3d3ca0c6c1484872285f542d6e8eb5d1e.

Reason for revert: Causes large battery usage regression on Go devices.

Original change's description:
> Record visible load time metric for images
> 
> This metric tracks how long the user has to wait for a visible image to
> load completely. This metric will help understand how much delay does
> lazyload of images incurs users.
> 
> Bug:  812684 
> Change-Id: Ic97c9a192254a2b64d9f2427d8694d6e36759db9
> Reviewed-on: https://chromium-review.googlesource.com/831530
> Commit-Queue: rajendrant <rajendrant@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: Scott Little <sclittle@chromium.org>
> Reviewed-by: Fredrik Söderquist <fs@opera.com>
> Cr-Commit-Position: refs/heads/master@{#539221}

TBR=rkaplow@chromium.org,fs@opera.com,hiroshige@chromium.org,sclittle@chromium.org,rajendrant@chromium.org,schenney@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  812684 
Bug: 816944
Change-Id: I000e532a22150dc600b3e49337a8507cdeace504
Reviewed-on: https://chromium-review.googlesource.com/942861
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540140}
[modify] https://crrev.com/208f274e4bcb51748bba83071aa70011ceafa385/third_party/WebKit/Source/core/loader/ImageLoader.cpp
[modify] https://crrev.com/208f274e4bcb51748bba83071aa70011ceafa385/third_party/WebKit/Source/core/loader/ImageLoader.h
[modify] https://crrev.com/208f274e4bcb51748bba83071aa70011ceafa385/tools/metrics/histograms/histograms.xml

Summary: Record visible load time metric for images (was: Record visible load time metric for images and iframes)
I'm splitting out the iframe visible load time into it's own bug, so it can be tracked separately:  Issue 827717 
Components: -Blink>Previews Blink>Loader>LazyLoad
Labels: M-69
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01fc2265e89ddd4d1308464d1970cc0155d480c6

commit 01fc2265e89ddd4d1308464d1970cc0155d480c6
Author: rajendrant <rajendrant@chromium.org>
Date: Thu Aug 30 03:06:06 2018

Record visible load time metric for images

This metric tracks how long the user has to wait for a visible image to
load completely. This metric will help understand how much delay does
lazyload of images incurs users. The metric is recorded only when
enabled via field trial.

Bug:  812684 
Change-Id: I484fc04f2435ae584300bb3dcd4cd33defddc450
Reviewed-on: https://chromium-review.googlesource.com/1192986
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587431}
[modify] https://crrev.com/01fc2265e89ddd4d1308464d1970cc0155d480c6/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/01fc2265e89ddd4d1308464d1970cc0155d480c6/third_party/blink/renderer/core/html/html_image_element.h
[modify] https://crrev.com/01fc2265e89ddd4d1308464d1970cc0155d480c6/third_party/blink/renderer/core/html/lazy_load_image_observer.cc
[modify] https://crrev.com/01fc2265e89ddd4d1308464d1970cc0155d480c6/third_party/blink/renderer/core/html/lazy_load_image_observer.h
[modify] https://crrev.com/01fc2265e89ddd4d1308464d1970cc0155d480c6/third_party/blink/renderer/core/loader/image_loader.cc
[modify] https://crrev.com/01fc2265e89ddd4d1308464d1970cc0155d480c6/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment