base::JSONValueConverter offers only heap-allocated repeated converters
Reported by
claudiom...@gmail.com,
Feb 15 2018
|
||
Issue descriptionJSONValueConverter requires vector<std::unique<T>> whenever you're setting up a repeated converter. The possible reason for this is to avoid an extra copy/move operation when checking if the conversion should go ahead. It would be good to consider if the possibility of having an extra move. This would be really beneficial for cases in which it is required std::vector<std::unique<int>>. We can also consider a) checking the value or b) having a is convertible that doesn't involve really converting the value, but rather wrapping the possible access in a adapter.
,
Mar 9 2018
As this issue is related to JSONValueConverter, adding 'TE-NeedsTriageHelp' label for further help in triaging this issue. Thanks..
,
Mar 9 2018
I have already submitted a CL weeks ago, regarding JSONValueConverter. But it has been a bit cold: https://chromium-review.googlesource.com/c/chromium/src/+/922462 |
||
►
Sign in to add a comment |
||
Comment 1 by sindhu.chelamcherla@chromium.org
, Feb 20 2018