New issue
Advanced search Search tips

Issue 812677 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Security



Sign in to add a comment

Security DCHECK failure: line_layout_item.IsLayoutInline() || line_layout_item.IsEqual(this) in LayoutBlo

Project Member Reported by ClusterFuzz, Feb 15 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4728647156760576

Fuzzer: bj_broddelwerk
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Security DCHECK failure
Crash Address: 
Crash State:
  line_layout_item.IsLayoutInline() || line_layout_item.IsEqual(this) in LayoutBlo
  blink::LayoutBlockFlow::CreateLineBoxes
  blink::LayoutBlockFlow::ConstructLine
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=535341:535343

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4728647156760576

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Feb 15 2018

Components: Blink>Layout
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.

Comment 2 by e...@chromium.org, Feb 15 2018

Labels: Pri-1
Owner: kojii@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 16 2018

Labels: M-66
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 16 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by kojii@chromium.org, Feb 19 2018

Cc: futhark@chromium.org
Looking, but unable to reproduce, tried:
* Run the test on local Win
* Run the test on local Linux ASAN
* Run the test using "/google/data/ro/teams/clusterfuzz-tools/releases/clusterfuzz reproduce 4728647156760576"

```
New crash type:
New crash state:


Original crash type: Security DCHECK failure
Original crash state:
  line_layout_item.IsLayoutInline() || line_layout_item.IsEqual(this) in LayoutBlockFlowLine.cpp
  blink::LayoutBlockFlow::CreateLineBoxes
  blink::LayoutBlockFlow::ConstructLine

The stacktrace doesn't match the original stacktrace.
Try again (3 times). Press Ctrl+C to stop trying to reproduce.

UnreproducibleError: The crash cannot be reproduced after trying 3 times.
Here are things you can try:
- Run outside XVFB (e.g. you will be able to see the launched program on screen.) with `--disable-xvfb`, which is especially useful for Chrome.
- Run with the downloaded build by adding `--build download`.
- Run `build/install-build-deps.sh` to ensure all dependencies are installed.
- Run with more number of trials by adding `-i 10`, which is especially good for gesture-related testcases.
- Use gdb to debug by adding `--enable-debug`.
```

Within the regressed range, this one looks more suspicious, but the test doesn't use shadow nor slots.
  Introduce slot-in-flat-tree behind experimental flag.
  https://chromium-review.googlesource.com/c/chromium/src/+/871150
cc'ing rune in case he has some better idea.

Ran another regressed/fixed job to see if it still reproduces on the bot.

Comment 6 by kojii@chromium.org, Feb 22 2018

Status: WontFix (was: Assigned)
I still can't reproduce this locally.

Also "clusterfuzz reproduce 4728647156760576" now shows:

The following packages have unmet dependencies:
 libxcursor1-dbg : Depends: libxcursor1 (= 1:1.1.14-1+deb9u1) but 1:1.1.15-1 is to be installed
E: Unable to correct problems, you have held broken packages.

but I can't find this package.

% sudo apt-get install libxcursor1=1:1.1.14-1+deb9u1 
Reading package lists... Done
Building dependency tree       
Reading state information... Done
E: Version '1:1.1.14-1+deb9u1' for 'libxcursor1' was not found

...giving up.
Project Member

Comment 7 by ClusterFuzz, Mar 1 2018

Labels: Needs-Feedback
ClusterFuzz testcase 4728647156760576 is still reproducing on tip-of-tree build (trunk).

If this testcase was not reproducible locally or unworkable, ignore this notification and we will file another bug soon with hopefully a better and workable testcase.

Otherwise, if this is not intended to be fixed (e.g. this is an intentional crash), please add ClusterFuzz-Ignore label to prevent future bug filing with similar crash stacktrace.
Project Member

Comment 8 by ClusterFuzz, Mar 2 2018

Labels: OS-Windows
Project Member

Comment 9 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 10 by sheriffbot@chromium.org, May 31 2018

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment