Promote shorter suggestions more aggressively |
||
Issue description"docs" in my profile always autocompletes to a really long URL, because there are a couple of Google Docs I go to all the time. That's not a bad result, but I also visit the root "docs.google.com" site frequently, and I should get autocompleted to that first. HistoryURLProvider::PromoteOrCreateShorterSuggestion() will accomplish this as long as the short URL has been visited at least a third as often as the long one. I think keying off visit count here is incorrect. We should either key off typed count or use either one ("if typed a third as often or visited a third as often, ..."). In my profile, that would fix this issue, since the short URL has typed/visit counts of 8/9 and the long one 13/253.
,
Feb 16 2018
I'm not that experienced with SQLite, but would this expression work:
sql.append(" ? AND url < :end AND url = substr(:end, 1, length(url)) "
"AND hidden = 0 AND (visit_count >= ? OR typed_count >= ?) "
"ORDER BY url LIMIT 1");
I'm using parenthesis for the sub expression to check if either of the values apply, but I'm not sure if that's a valid SQLite expression.
,
Feb 16 2018
By the way... I have a CL for this, which I'm gonna submit soon. I've noticed there are no tests for this functionality. I gladly work on the necessary test if some pointers were provided on how to approach it.
,
Feb 16 2018
cl for this request: https://chromium-review.googlesource.com/#/c/chromium/src/+/923734
,
Feb 20 2018
,
Mar 27 2018
Bug 787067 (apologies: restricted view), which is about launching zero suggest on iOS, implies that this is an issue. When users can select the names of popular (to them) site, they end up needing to delete text less. If they have to type it, sometimes they have to delete an overly-long suggestion. Looking at other data too, it appears * on desktop, about half the time (maybe 60%) that users have to delete text, it's because a URL suggestion was too aggressive. Searches are less of a problem. * on mobile, about a quarter of the time that users have to delete text, it's because a URL suggestion was too aggressive. Searches are the main problem there. |
||
►
Sign in to add a comment |
||
Comment 1 by mpear...@chromium.org
, Feb 15 2018Status: Available (was: Untriaged)