NavigationAndLoadCallbacksTest.StopFinishedNavigation is failing on devices |
|||||||
Issue descriptionHere are some examples: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone11-device-x64/builds/2764 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone11-device-x64/builds/2763 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone11-device-x64/builds/2762 Detailed error log: NavigationAndLoadCallbacksTest.StopFinishedNavigation: unknown file: Failure Unexpected mock function call - returning directly. Function call: DidStopLoading(0x10350e0e0) Google Mock tried the following 1 expectation, but it didn't match: ../../ios/web/web_state/navigation_and_load_callbacks_inttest.mm:1215: EXPECT_CALL(observer_, DidStopLoading(web_state()))... Expected: all pre-requisites are satisfied Actual: the following immediate pre-requisites are not satisfied: ../../ios/web/web_state/navigation_and_load_callbacks_inttest.mm:1212: pre-requisite #0 (end of pre-requisites) Expected: to be called once Actual: never called - unsatisfied and active ../../ios/web/web_state/navigation_and_load_callbacks_inttest.mm:1215: Failure Actual function call count doesn't match EXPECT_CALL(observer_, DidStopLoading(web_state()))... Expected: to be called once Actual: never called - unsatisfied and active ../../ios/web/web_state/navigation_and_load_callbacks_inttest.mm:1212: Failure Actual function call count doesn't match EXPECT_CALL(observer_, DidFinishNavigation(web_state(), _))... Expected: to be called once Actual: never called - unsatisfied and active ../../ios/web/web_state/navigation_and_load_callbacks_inttest.mm:1210: Failure Actual function call count doesn't match EXPECT_CALL(*decider_, ShouldAllowResponse(_, true))... Expected: to be called once Actual: never called - unsatisfied and active
,
Feb 15 2018
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/642bca64be756d248febcbdee1db2079bcfc18fc commit 642bca64be756d248febcbdee1db2079bcfc18fc Author: Yuke Liao <liaoyuke@chromium.org> Date: Thu Feb 15 18:53:46 2018 [iOS] Disable StopFinishedNavigation on devices. NavigationAndLoadCallbacksTest.StopFinishedNavigation is failing consistently on devices. Bug: 812669 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I35912dc09646bf8dcfdbbbccebe5774cdc060ef2 Reviewed-on: https://chromium-review.googlesource.com/922321 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#537089} [modify] https://crrev.com/642bca64be756d248febcbdee1db2079bcfc18fc/ios/web/web_state/navigation_and_load_callbacks_inttest.mm
,
Feb 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/023726930755e32a64d95867c2d56f003a267376 commit 023726930755e32a64d95867c2d56f003a267376 Author: Rohit Rao <rohitrao@chromium.org> Date: Fri Feb 23 14:32:29 2018 [ios] Disables two NavigationAndLoadCallbacksTest tests on device. BUG= 812669 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4445dc30b8ce2d26265f878287dff4919e780ba3 Reviewed-on: https://chromium-review.googlesource.com/934521 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#538776} [modify] https://crrev.com/023726930755e32a64d95867c2d56f003a267376/ios/web/web_state/navigation_and_load_callbacks_inttest.mm
,
Mar 15 2018
Eugene have you already reviewed this test disable?
,
Mar 15 2018
,
Mar 15 2018
This test was recently written and never worked correctly on the device, so this is not a regression. Lowering priority to P2.
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a43b0863af7e02e48042d84215fc3618facfc894 commit a43b0863af7e02e48042d84215fc3618facfc894 Author: Eugene But <eugenebut@google.com> Date: Wed Mar 28 17:42:50 2018 Enable NavigationAndLoadCallbacksTest.FailedLoad. CL which disabled the test does not explain the reason for disabling. The bug linked in TODO does not have any comments related to FailedLoad test. This test passed locally and on the device bots. Enabling the test, maybe the problem has gone. Bug: 812669 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I39d9b0098e395206e67e248b51c9efc82ea57f68 Reviewed-on: https://chromium-review.googlesource.com/982266 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#546537} [modify] https://crrev.com/a43b0863af7e02e48042d84215fc3618facfc894/ios/web/web_state/navigation_and_load_callbacks_inttest.mm
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d81834af992272ad1847b8c7ec7c8a928ec21ff9 commit d81834af992272ad1847b8c7ec7c8a928ec21ff9 Author: Eugene But <eugenebut@google.com> Date: Mon May 14 17:20:53 2018 Speculative fix for NavigationAndLoadCallbacksTest.StopFinishedNavigation Wait until the navigation is committed before stopping the load. Bug: 812669 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7f8d65bd2ee6e4a6617257ad83e19cc9a9ba5c2e Reviewed-on: https://chromium-review.googlesource.com/1054707 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#558354} [modify] https://crrev.com/d81834af992272ad1847b8c7ec7c8a928ec21ff9/ios/web/web_state/navigation_and_load_callbacks_inttest.mm
,
May 21 2018
,
May 21 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by liaoyuke@chromium.org
, Feb 15 2018