Issue metadata
Sign in to add a comment
|
FullscreenTestCase/testShowHeaderWhenChildTabCloses is flaky on devices |
||||||||||||||||||||||
Issue description
,
Mar 15 2018
Kurt have you already reviewed this disabled test?
,
Mar 15 2018
,
Mar 15 2018
Sorry, have not looked into this. Will take a look at this tomorrow.
,
Mar 16 2018
The NextAction date has arrived: 2018-03-16
,
Mar 19 2018
Any update here Kurt?
,
Mar 20 2018
,
Mar 22 2018
,
Mar 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4383a791f180a25c3ef5952233e4f13bd2e33af commit b4383a791f180a25c3ef5952233e4f13bd2e33af Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Sun Mar 25 19:37:22 2018 [iOS] Only verify error code when link tapping fails. The behavior of TapWebViewElementWithId() for links that close a WebState is flaky on both simulator and device, regardless of whether the Phase 1 UI Reboot flag is enabled. This CL updates FullscreenTestCase.testShowHeaderWhenChildTabCloses to check for the error code only if the link tap is unsuccessful. Note that the closure of the Tab and the visibility of the toolbar is still verified after this occurs, so the test will still catch fullscreen regressions after this change. Bug: 812664 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia56293763e185eeb615a5f734aa9a3a473f0b424 Reviewed-on: https://chromium-review.googlesource.com/974791 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545713} [modify] https://crrev.com/b4383a791f180a25c3ef5952233e4f13bd2e33af/ios/chrome/browser/ui/fullscreen/fullscreen_egtest.mm
,
Mar 25 2018
,
Mar 25 2018
This bug requires manual review: Less than 19 days to go before AppStore submit on M66 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 26 2018
Please verify in canary
,
Mar 26 2018
@cmasso This verification request is directed to... the test owner kkhorimoto?
,
Mar 26 2018
,
Mar 27 2018
Since this does not require manual verification, then I Kurt should verify. Kurt, I am approving the merge upon verification of the fix in canary
,
Mar 27 2018
It looks like there have not been any failures of this test since being reenabled on device, so I will cherry-pick now. https://uberchromegw.corp.google.com/i/internal.bling.main/waterfall?builder=iphone10-device-x64 https://uberchromegw.corp.google.com/i/internal.bling.main/waterfall?builder=ipad10-device-x64
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d18463ba74c2268929b3a61307cf8204baeef8d commit 2d18463ba74c2268929b3a61307cf8204baeef8d Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Tue Mar 27 01:36:06 2018 [iOS] Only verify error code when link tapping fails. The behavior of TapWebViewElementWithId() for links that close a WebState is flaky on both simulator and device, regardless of whether the Phase 1 UI Reboot flag is enabled. This CL updates FullscreenTestCase.testShowHeaderWhenChildTabCloses to check for the error code only if the link tap is unsuccessful. Note that the closure of the Tab and the visibility of the toolbar is still verified after this occurs, so the test will still catch fullscreen regressions after this change. Bug: 812664 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia56293763e185eeb615a5f734aa9a3a473f0b424 Reviewed-on: https://chromium-review.googlesource.com/974791 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#545713}(cherry picked from commit b4383a791f180a25c3ef5952233e4f13bd2e33af) Reviewed-on: https://chromium-review.googlesource.com/981613 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#460} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/2d18463ba74c2268929b3a61307cf8204baeef8d/ios/chrome/browser/ui/fullscreen/fullscreen_egtest.mm |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Feb 15 2018