New issue
Advanced search Search tips

Issue 812662 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Disable devtools while entering or exiting locked fullscreen mode

Project Member Reported by isandrk@chromium.org, Feb 15 2018

Issue description

Any running devtools instances are a security liability in the locked fullscreen mode as they may allow the user to escape the mode. Shut down all devtool instances on entering/exiting this special mode.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0c709de4223ff4875be04d8ebe3baac6b2c6b9b

commit c0c709de4223ff4875be04d8ebe3baac6b2c6b9b
Author: Ivan Sandrk <isandrk@google.com>
Date: Wed Feb 21 14:47:12 2018

Close devtools on entering/exiting locked fullscreen mode

Any running devtools instances are a security liability in the locked fullscreen
mode as they may allow the user to escape the mode. Shut down all devtool
instances on entering/exiting this special mode.

Also do a small refactoring of the code for this feature inside tabs_api.cc.

Bug:  chromium:812662 
Change-Id: Ib66b59093ff1f8ec2e76dcd2f776100bd96f9344
Reviewed-on: https://chromium-review.googlesource.com/922203
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Ivan Ĺ andrk <isandrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538098}
[modify] https://crrev.com/c0c709de4223ff4875be04d8ebe3baac6b2c6b9b/chrome/browser/extensions/api/tabs/tabs_api.cc
[modify] https://crrev.com/c0c709de4223ff4875be04d8ebe3baac6b2c6b9b/chrome/browser/ui/browser_command_controller.cc

Labels: -M-65 M-66
Status: Fixed (was: Started)
Status: asddsadsad (was: Fixed)
Status: Fixed (was: asddsadsad)
Status: Verified (was: Fixed)
As verified on M66.0.3359.28 10452.8.0 dev parrot, devtools is not available during locked full screen mode and is available after exiting the full screen mode.

Sign in to add a comment