New issue
Advanced search Search tips

Issue 812660 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

builder page: "time" column is confusing

Project Member Reported by no...@chromium.org, Feb 15 2018

Issue description

Milo builder page, e.g. https://luci-milo.appspot.com/p/v8-internal/builders/luci.v8-internal.ci/v8_linux64_perf_2
has "time" column, but it does not say that is "end time". It is not obvious in particular because the table itself is ordered by creation time.
 

Comment 1 by estaab@chromium.org, Feb 22 2018

Owner: hinoka@chromium.org
Status: Assigned (was: Untriaged)
So the proposal is to just change it to "End Time"? Seems straightforward enough.

Comment 2 by no...@chromium.org, Feb 23 2018

at the very least, yes.

note that the table would not be ordered by that column, though.

Comment 3 by efoo@chromium.org, Mar 1 2018

Labels: LUCI-Backlog
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/a6a8e58d4ee99046883251e60d04733dcbda6d04

commit a6a8e58d4ee99046883251e60d04733dcbda6d04
Author: Ryan Tseng <hinoka@google.com>
Date: Thu Mar 01 18:49:24 2018

[milo] Builder view: Rename 'Time' column to 'Finished time'

Bug:  812660 
Change-Id: Ib315af1c71cf27233488cd2bb4fc67a9ff6d19dd
Reviewed-on: https://chromium-review.googlesource.com/941557
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/a6a8e58d4ee99046883251e60d04733dcbda6d04/milo/frontend/appengine/templates/pages/builder.html
[modify] https://crrev.com/a6a8e58d4ee99046883251e60d04733dcbda6d04/milo/frontend/expectations/buildbot.builder-Basic_Test_with_builds.html

Comment 5 by efoo@chromium.org, Mar 2 2018

Labels: -LUCI-Backlog LUCI-Chromium-CQSets

Comment 6 by hinoka@chromium.org, Mar 13 2018

Status: Fixed (was: Assigned)

Sign in to add a comment