New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812658 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Credit Card Autofill Touch Bar Support for Views

Project Member Reported by spqc...@chromium.org, Feb 15 2018

Issue description

The credit card autofill touch bar does not currently work for Views.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70a4ce306b0b6d4ef033dd02d73da7dc04f1799c

commit 70a4ce306b0b6d4ef033dd02d73da7dc04f1799c
Author: spqchan <spqchan@chromium.org>
Date: Tue Feb 20 19:49:04 2018

[Mac] Credit Card Autofill Touch Bar Refactor

Move the credit card autofill touch bar logic from
AutofillPopupViewCocoa to AutofillPopupControllerImplMac
so that is can be used on both Toolkit and Cocoa
autofill popups.

Bug:  812658 
Change-Id: Ic8d788dddabb909edee46da46899d759447a7c7d
Reviewed-on: https://chromium-review.googlesource.com/915438
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537852}
[modify] https://crrev.com/70a4ce306b0b6d4ef033dd02d73da7dc04f1799c/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/70a4ce306b0b6d4ef033dd02d73da7dc04f1799c/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
[modify] https://crrev.com/70a4ce306b0b6d4ef033dd02d73da7dc04f1799c/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
[add] https://crrev.com/70a4ce306b0b6d4ef033dd02d73da7dc04f1799c/chrome/browser/ui/autofill/autofill_popup_controller_impl_mac.h
[add] https://crrev.com/70a4ce306b0b6d4ef033dd02d73da7dc04f1799c/chrome/browser/ui/autofill/autofill_popup_controller_impl_mac.mm
[modify] https://crrev.com/70a4ce306b0b6d4ef033dd02d73da7dc04f1799c/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.h
[modify] https://crrev.com/70a4ce306b0b6d4ef033dd02d73da7dc04f1799c/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm
[delete] https://crrev.com/fccdfe2744e1f0ad9c610ea656b52408a001774b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa_unittest.mm
[add] https://crrev.com/70a4ce306b0b6d4ef033dd02d73da7dc04f1799c/chrome/browser/ui/cocoa/autofill/credit_card_autofill_touch_bar_controller.h
[add] https://crrev.com/70a4ce306b0b6d4ef033dd02d73da7dc04f1799c/chrome/browser/ui/cocoa/autofill/credit_card_autofill_touch_bar_controller.mm
[add] https://crrev.com/70a4ce306b0b6d4ef033dd02d73da7dc04f1799c/chrome/browser/ui/cocoa/autofill/credit_card_autofill_touch_bar_controller_unittest.mm
[modify] https://crrev.com/70a4ce306b0b6d4ef033dd02d73da7dc04f1799c/chrome/browser/ui/cocoa/web_textfield_touch_bar_controller.h
[modify] https://crrev.com/70a4ce306b0b6d4ef033dd02d73da7dc04f1799c/chrome/browser/ui/cocoa/web_textfield_touch_bar_controller.mm
[modify] https://crrev.com/70a4ce306b0b6d4ef033dd02d73da7dc04f1799c/chrome/test/BUILD.gn

Status: Fixed (was: Assigned)

Sign in to add a comment