New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812657 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 781754



Sign in to add a comment

Add support for WebSettingsCompat in chromium

Project Member Reported by gsennton@chromium.org, Feb 15 2018

Issue description

This is the chromium side part of implementing WebSettingsCompat.

Corresponding buganizer part: b/73454029
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f3669c32a20f4bb559fa93a1ee0b33db9a8089e

commit 1f3669c32a20f4bb559fa93a1ee0b33db9a8089e
Author: Gustav Sennton <gsennton@google.com>
Date: Fri Feb 16 21:52:13 2018

Move MessagePort related functionality to SharedWebViewChromium.

Move MessagePort related functionality from WebViewChromium to
SharedWebViewChromium so the support library glue layer can avoid
depending on WebViewChromium.

Bug:  812657 
Change-Id: Iacd6c0e2dd0ffd1e8307ffb06a70cb00a2a71202
Reviewed-on: https://chromium-review.googlesource.com/924207
Commit-Queue: Gustav Sennton <gsennton@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537422}
[modify] https://crrev.com/1f3669c32a20f4bb559fa93a1ee0b33db9a8089e/android_webview/glue/java/src/com/android/webview/chromium/SharedWebViewChromium.java
[modify] https://crrev.com/1f3669c32a20f4bb559fa93a1ee0b33db9a8089e/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
[modify] https://crrev.com/1f3669c32a20f4bb559fa93a1ee0b33db9a8089e/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3fcc3e0d7908ae3f1f9bb6b70365780624be278

commit c3fcc3e0d7908ae3f1f9bb6b70365780624be278
Author: Gustav Sennton <gsennton@google.com>
Date: Mon Feb 26 16:22:59 2018

Add support for WebSettingsCompat.

Also add a webkit-to-compat converter object which takes webkit objects,
and returns the implementation for the corresponding Compat-object.
E.g. WebSettings -> implementation for WebSettingsCompat.

Bug:  812657 
Change-Id: Ifb5507ec3f4f620621ab05b73d643abcc184cf85
Reviewed-on: https://chromium-review.googlesource.com/922623
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Gustav Sennton <gsennton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539153}
[modify] https://crrev.com/c3fcc3e0d7908ae3f1f9bb6b70365780624be278/android_webview/glue/java/src/com/android/webview/chromium/WebkitToSharedGlueConverter.java
[modify] https://crrev.com/c3fcc3e0d7908ae3f1f9bb6b70365780624be278/android_webview/support_library/BUILD.gn
[modify] https://crrev.com/c3fcc3e0d7908ae3f1f9bb6b70365780624be278/android_webview/support_library/boundary_interfaces/BUILD.gn
[modify] https://crrev.com/c3fcc3e0d7908ae3f1f9bb6b70365780624be278/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/WebSettingsBoundaryInterface.java
[modify] https://crrev.com/c3fcc3e0d7908ae3f1f9bb6b70365780624be278/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/WebViewProviderFactoryBoundaryInterface.java
[add] https://crrev.com/c3fcc3e0d7908ae3f1f9bb6b70365780624be278/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/WebkitToCompatConverterBoundaryInterface.java
[add] https://crrev.com/c3fcc3e0d7908ae3f1f9bb6b70365780624be278/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebSettingsAdapter.java
[modify] https://crrev.com/c3fcc3e0d7908ae3f1f9bb6b70365780624be278/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java
[add] https://crrev.com/c3fcc3e0d7908ae3f1f9bb6b70365780624be278/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebkitToCompatConverterAdapter.java

Status: Fixed (was: Assigned)

Sign in to add a comment